From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E69AAEB64DA for ; Wed, 19 Jul 2023 06:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yQUSwxgSIF8Vx93b2VOAyAy6+tqWVCVI5meAZEJti6o=; b=0E8ASw1Iu+jDPw ivj6EAAWelQA+bxNONu+USg74Fosh6R7ksPKyC2M6mewF6j37OLeqG2riBt0F8yEEmA2u7Qfg0ES9 dDB46qw9gCMxUwojcIjStl4njoC6u1MG35eVYLSH+VkiCn0CSRP7y1bzVHag3OyRvVHK0PAXxN4FK dfW7xrpX1pMf4sRk3LEMRshaYV+Zs1HNeDfWaGaKSLhpwMId+w+Yfot4eYxwSfSZWRSawVXTlvQJj pVndiKyCU1Wcr7tZrDHtAcxEI/tVRUMX0HHQLqk+/tdsmYGIzPS6MPw8v270AfUOPd18BjtxZJTdf VTMuvSRUfA/11tYPmlQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM0Pv-005asl-0Q; Wed, 19 Jul 2023 06:12:07 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM0Ps-005aqa-16 for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 06:12:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SPDU5kPWAAgPJ4oaKrt1JSYg4VjyFkkAo26/4HsJa04=; b=VyAOpm3lcIcXCppisOtbpYmoJU PozHRxXtWvHDIz0UELK+PI7Fe1q8+t/H3GOOobzTcqSJmTYL6rOQcbcuN0w7k+XHZ+H5clFNL4/F4 3c9mLnYMaKxnxDgAM+V48P3/0hNgldZXWysSll5WrmZsoXzPQPD5IyNnIWyaKAb7ipFYiUskJh/Dl E6x0GeyYMOrtK+v9VHC24mwf2wx5zMs78MYUmIir9hoLJ1SQmnm3DOy+iRoqMUywufxkEdNwveJiu Z55NX0ey9jARfHSb2vNwatxx1DYs+HLk4ItM9AjKQ8uFiNXydY1mNnX2ZXPlYf8Fgu2trgjezZg7G UWQwrh6w==; Received: from mailrelay6-1.pub.mailoutpod2-cph3.one.com ([2a02:2350:5:405::1]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLnAd-00BkGR-2h for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2023 16:03:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=SPDU5kPWAAgPJ4oaKrt1JSYg4VjyFkkAo26/4HsJa04=; b=dLsM4dKkdPGEHfWhE3vOWnFlgqVcbUyXZFIoRiB/sV84rIprOtRr96GG5UiY7rQPW2Ga+rHh+MiZm OGndJTN+MK6X0+EncQLeUWmTInpQOJALijDi8u7SecoAqs+Nd5Sx6EhoSt1Xus1NTKsfKw/a6kCQNT 8dfK+wUCKqBJLVM1AMgGxEIhOZU6HT1HuzvQUlcbBfhTq9aTbimXYpbC4tLA6ZZsY871YPtEgk4pYY /advwv9+3ZzFLVjfrKdDKRoRb2pk3cMIwlOD7koEju4ysS7pFM/8q64GJXrGTsazm1+EfEJwccSxUD LkEQHA4RNjKEvAf/fNbe47i7J1S0YqA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=SPDU5kPWAAgPJ4oaKrt1JSYg4VjyFkkAo26/4HsJa04=; b=D8EVbIV6H9KKEcuAqA4UX2ud8rTkGapXb7xDfioVd2x2qEvtJTYdzfwETPQFuaCb0ZyBBXolk6RU2 ejcFqvTAA== X-HalOne-ID: 4bc5dc98-2582-11ee-b1c1-6f01c1d0a443 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay6 (Halon) with ESMTPSA id 4bc5dc98-2582-11ee-b1c1-6f01c1d0a443; Tue, 18 Jul 2023 15:46:45 +0000 (UTC) Date: Tue, 18 Jul 2023 17:46:44 +0200 From: Sam Ravnborg To: Ying Liu Cc: Alexander Stein , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "neil.armstrong@linaro.org" , "conor+dt@kernel.org" , "rfoss@kernel.org" , "andrzej.hajda@intel.com" , "jonas@kwiboo.se" , "s.hauer@pengutronix.de" , "jernej.skrabec@gmail.com" , "robh+dt@kernel.org" , "Laurent.pinchart@ideasonboard.com" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "kernel@pengutronix.de" , dl-linux-imx Subject: Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support Message-ID: <20230718154644.GD688726@ravnborg.org> References: <20230717061831.1826878-1-victor.liu@nxp.com> <20230717061831.1826878-10-victor.liu@nxp.com> <3174425.5fSG56mABF@steina-w> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_170327_986675_D2D96266 X-CRM114-Status: GOOD ( 11.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ying Liu, On Tue, Jul 18, 2023 at 09:00:25AM +0000, Ying Liu wrote: > > > + if (IS_ERR(dsi->regmap)) { > > > + ret = PTR_ERR(dsi->regmap); > > > + DRM_DEV_ERROR(dev, "failed to get block ctrl regmap: > > %d\n", ret); > > > > Could you use dev_err_probe here instead? > > Maybe, it's better to keep using DRM_DEV_ERROR to achieve consistent > error log format across the driver which is implemented in drm_dev_printk(). > I see other DRM drivers do the same. All the DRM_* macros are deprecated. New code shall use drm_*, dev_* or pr_ as appropriate. The appropriate variant here is dev_err_probe(). Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel