From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 263A8C0015E for ; Wed, 19 Jul 2023 16:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jd+bB7BhpMulwyP4J8FhF77A+Y3hhu91+YgNsUHga4A=; b=ETHJmyx8ib/e7bhpg33H4rFUkR vu7w2i+Pp4Q+GTbKCIScD4kr5m4DYXJZkUWe4BefMeVOjMIL9hqkJ6KzF7HXS8Mwwbl+8+dyuau2H pXqCigoadau8Nllbvkj/WFCIZD8HvxmPYovlWF5eTFaj5hVPQ4CNSneG36CBSg48+ZqIMHBJIiQEV UQLf7czjqJ7Q3ZOk3LM8iO4bBqM2G6Q2hf3sJzQsa6En7Z6td4+PN2aHD/hWhXS2hGrECBsJSmXey eYCH5+XF26XKx41C1ACN83X5Jq0JxePI92wFMjDA15cwo038pJYrBOVW79QAF2ymlTbPGdKIeLZEx TM88nxBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMAAB-008A7f-1f; Wed, 19 Jul 2023 16:36:32 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMAA8-008A6R-0V for linux-arm-kernel@lists.infradead.org; Wed, 19 Jul 2023 16:36:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A0AB161629; Wed, 19 Jul 2023 16:36:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7F60C433C8; Wed, 19 Jul 2023 16:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689784586; bh=T67KVuMsXJyOHPpyRG/bF4u+lVYth3Zf4FyYGoex53A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y3ZdEYbupgVsJzit/TJjMBMI1pQ8pnMPk2eY2TJHizVHcRhCCIs2G6wSKmru9CuYg ruEp67kxjdVKQIPZVkMwSI6CdpryX0NZpAYAhYUDUruC6T9xnyuEMf2dXWHR4kmH3k ewV2JPjapcDFamJ7uVoBOsUQ5oUAjoqYdB8sIQD9OXmyPECcbB7PxQXvDBxym+NuMm J5WscmACVaQfmSU4drA+8IVI/cCN8A5AHBdzlsBrYvP5My+3Cg3Ej9st3hAK9Jtp6S uvKnK/Cg/MX8z/aNRtrEtQAbBROe2du8KC3a2UsYabJm5jWi4G3npRk+0opcqGD520 SgmaXBE+V5bjg== Date: Wed, 19 Jul 2023 17:36:21 +0100 From: Conor Dooley To: Pranavi Somisetty Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, michal.simek@amd.com, harini.katakam@amd.com, git@amd.com, radhey.shyam.pandey@amd.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] dt-bindings: net: xilinx_gmii2rgmii: Convert to json schema Message-ID: <20230719-sizzling-heaving-bc802f2ed2ae@spud> References: <20230719061808.30967-1-pranavi.somisetty@amd.com> MIME-Version: 1.0 In-Reply-To: <20230719061808.30967-1-pranavi.somisetty@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230719_093628_253173_4601DFC4 X-CRM114-Status: GOOD ( 15.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1236683778464591838==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1236683778464591838== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZZlRDUsAAGIHGb0l" Content-Disposition: inline --ZZlRDUsAAGIHGb0l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 19, 2023 at 12:18:08AM -0600, Pranavi Somisetty wrote: > Convert the Xilinx GMII to RGMII Converter device tree binding > documentation to json schema. > This converter is usually used as gem <---> gmii2rgmii <---> external phy > and, it's phy-handle should point to the phandle of the external phy. >=20 > Signed-off-by: Pranavi Somisetty > --- > Changes v2: > 1. Changed description for the property "reg". > 2. Added a reference to the description of "phy-handle" property. Seems fine to me, one /minor/ nit that I don't expect to be addressed. Reviewed-by: Conor Dooley Thanks, Conor. > diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yam= l b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml > new file mode 100644 > index 000000000000..9d22382a64ba > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml > +examples: > + - | > + mdio { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + phy: ethernet-phy@0 { > + reg =3D <0>; > + }; > + gmiitorgmii@8 { > + compatible =3D "xlnx,gmii-to-rgmii-1.0"; > + reg =3D <8>; > + phy-handle =3D <&phy>; > + }; Ideally, add a blank line before child nodes. > + }; > --=20 > 2.36.1 >=20 --ZZlRDUsAAGIHGb0l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZLgRBQAKCRB4tDGHoIJi 0pFDAQCmtiE2GnotCBnhox3kae5HrWkNtj3/Tv6uGBwnTLajtAEAiiBsXMRS3sfZ PMfmBowd0X1+f9ihnG6IfCkO/fQ2pgg= =Asfq -----END PGP SIGNATURE----- --ZZlRDUsAAGIHGb0l-- --===============1236683778464591838== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1236683778464591838==--