From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4E7FEB64DA for ; Wed, 19 Jul 2023 05:40:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m797nbNZn0g5dkfuPmFqYVwT+PWVGozU2yGb6AliwvQ=; b=pYd7gmEu9d/yuc EBQhNkB7Ae/2bQWNbao9SYy8+b03Q+9wHu8IS9JGghqvVxh+HXyYmjsvTvgjUuCEFc3Q9ydP3Dssk i793UaP+8GIYBtuEKu0xrYPJoZwzHx7JqlNJFrfFmNX6S58h3iEnJiOj6maAcgem0m3pJ8l5Meo3s qYOr3HWCSMJmr9d5l/gJgzVM2q+c8gb9+Qn9x/v8VM932WFGECDCTdo3W9kQpKDbIhIhlALzwiRbV s3rXfJhDnRd7u2+NqUSU1Af1BBdRQBYRoZG5Hz/Bs+wSGVGd53k6jvv1e3NAFAib5aHQqKp2XRM8i R0rqaaavhW36c+iqpGBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qLzvV-005NWJ-0D; Wed, 19 Jul 2023 05:40:41 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLzvU-005NVq-14 for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 05:40:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=n09O1picfwGAHMELohyQhOk3rOTV7+3yO5kT2Jom2Vw=; b=nPqHwj6GaTnDvf8h3NhSpt1k7K 2q+DXfZgiT/dboPQM3f9IJE1hzPhSnwIpNKpXQChlWWa1HADoqyof98Ob4qjCeRr9GdQjzAbShVZL bDZXwXwFkOZA29qt+powLhMUfNj0gylnokgYNiZGReJuKKtLMJXD2VSGVdJjFYzK3ufRj0SNOdtAt mM64hFurr6lGeHQ1ThbvptrIpcm1dA6htoSqOAx3uebYle8LGoq4uW9T2RDV0W6RN3dQrkJIeJB89 J+TKJ/4UVcqV6NHBVlOXh9dwAmnAi1h8i/JoQQu4casrWlOy/fIILDmtQ94B3zuFHedpS8ADLtTh8 YGp5k+SA==; Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLwUo-00CSOs-39 for linux-arm-kernel@lists.infradead.org; Wed, 19 Jul 2023 02:00:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3F81261626; Wed, 19 Jul 2023 02:00:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F57EC433C7; Wed, 19 Jul 2023 02:00:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689732047; bh=0Da2X8oEjmvpZcG54rKflLyO7Pl8sCdTksCZgqJcsOM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=syIXk2+ZWrj7aJ63qNhkQZzNKFeKeAG2cbgL1igugVG2d+v5Ph5M04dTErXOeU57W 0Noh7hduTV9jG5UuKGaA3OyxX5WdqovKPPvcq9a/x4+/gCXljbh1P7yPwIUCLZEweo ff5wfpv9gpqieFgNVuXCixFpKUSgNq+gXzV35L4MQ2rQt9L2lqTYWIY3bw05CYPcmC fnvurc3j0FRH/QfbpBqqSgmsCuOBFA88uqmqyw9jmYc7FNTJ2gwp4JjazcUz9Am1GW rRxxQiNpoHsiFy57J3HRtrYjeYMLBEzAi4Z/K12XJ80IiJQXBqmLd2zKNHqwpIQlS3 kXLQklf0s76uw== Date: Wed, 19 Jul 2023 10:00:35 +0800 From: Shawn Guo To: Hugo Villeneuve Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Hugo Villeneuve , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: imx8mn-var-som-symphony: fix USB OTG Message-ID: <20230719020035.GS9559@dragon> References: <20230705174932.3652479-1-hugo@hugovil.com> <20230718063715.GL9559@dragon> <20230718100344.ebeae4ee79c299bcd6fee733@hugovil.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230718100344.ebeae4ee79c299bcd6fee733@hugovil.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230719_030058_276121_C8DAC93B X-CRM114-Status: GOOD ( 27.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 18, 2023 at 10:03:44AM -0400, Hugo Villeneuve wrote: > On Tue, 18 Jul 2023 14:37:15 +0800 > Shawn Guo wrote: > > > On Wed, Jul 05, 2023 at 01:49:32PM -0400, Hugo Villeneuve wrote: > > > From: Hugo Villeneuve > > > > > > USB OTG is currently broken on the Variscite Symphony EVK and imx8mn > > > nano SOM. > > > > > > The PTN5150 circuitry on newer versions of the Symphony EVK board has > > > a non-standard configuration in which the PTN5150 IRQ pin is left > > > unconnected, and the PTN5150 ID pin is connected to GPIO1_IO11. This > > > requires changes to the ptn5150 driver to support this new mode. > > > Variscite have indicated their intention to submit those changes > > > upstream. > > > > > > In the meantime, import device tree changes from linux-5.15 branch of > > > varigit repos to at least make the USB OTG port operate correctly in > > > host mode. > > > > > > Fixes: 7358e05bddca ("arm64: dts: imx8mn-var-som-symphony: Add Variscite Symphony board with VAR-SOM-MX8MN") > > > > Has USB OTG been ever worked at all? If the answer is no, it's not > > a fix but a new feature, and I would suggest you rework the patch > > subject and drop the Fixes tag. > > Hi Shawn, > it never worked for me since commit 7358e05bddca, but it may have > something to do with the new hardware board version (>=1.4a) that I > have. It probably worked for older boards (< 1.4a) altough I cannot > confirm it without old hardware. > > Let me know if you want me to remove the Fixes tag. The change doesn't look like a bug fix as it stands. Please rework the patch subject and remove the Fixes tag. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel