From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CF52C0015E for ; Wed, 19 Jul 2023 15:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ghNSqrh/p4asbMdKDcA72536fdA4FmCzwR1hBx26eG4=; b=sNpNrRekPiMIFg eBWMt4EI+7JKc53Ed7bQ40wHOqTZ/efRYWdLeszYm+Nkv6Fh9Bd6e+QFOggnDsQ0bKJwOP43rhqe0 bFJT68hFKneZ3HMaLg+icLgjVfipn9jR8bKUH51QOw/9gY53WWd1+dqRODLHChkNYy8ViGg3DpQip k98K38b7Xcbs8OeatnrpUMqhPQwM/LzdWg9Tr4+F76jK+WEU/cHtlCIDXJPwIyfb6Raoc7DZbGB9J f6AQ4Td1ixJV7UnvvvH98TGd4FXqebbZbFdOYsDvcIMeg3j8oxSHiY2SxZxUY3rdoB+YdKZvpawHD Bg/2J79CU/+WHQLCO2IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM9AY-007wto-2n; Wed, 19 Jul 2023 15:32:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM9AV-007wsf-1K for linux-arm-kernel@lists.infradead.org; Wed, 19 Jul 2023 15:32:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 433EB2F4; Wed, 19 Jul 2023 08:33:28 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 671393F6C4; Wed, 19 Jul 2023 08:32:43 -0700 (PDT) Date: Wed, 19 Jul 2023 16:32:40 +0100 From: Sudeep Holla To: Ulf Hansson Cc: Cristian Marussi , Viresh Kumar , Nishanth Menon , Stephen Boyd , Nikunj Kela , Prasad Sodagudi , Alexandre Torgue , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/11] cpufreq: scmi: Drop redundant ifdef in scmi_cpufreq_probe() Message-ID: <20230719153240.khiuqehl2r2dd6l7@bogus> References: <20230713141738.23970-1-ulf.hansson@linaro.org> <20230713141738.23970-12-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230713141738.23970-12-ulf.hansson@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230719_083247_532064_494FD22A X-CRM114-Status: GOOD ( 20.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 13, 2023 at 04:17:38PM +0200, Ulf Hansson wrote: > We have stubs for devm_of_clk_add_hw_provider(), so there should be no need > to protect this with the '#ifdef CONFIG_COMMON_CLK'. Let's drop it to clean > up the code a bit. > > Signed-off-by: Ulf Hansson > --- > > Changes in v2: > - New patch. > > --- > > drivers/cpufreq/scmi-cpufreq.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > index b42f43d9bd89..ab967e520355 100644 > --- a/drivers/cpufreq/scmi-cpufreq.c > +++ b/drivers/cpufreq/scmi-cpufreq.c > @@ -326,11 +326,9 @@ static int scmi_cpufreq_probe(struct scmi_device *sdev) > if (IS_ERR(perf_ops)) > return PTR_ERR(perf_ops); > > -#ifdef CONFIG_COMMON_CLK I am not sure if it is no longer possible but at the time of addition of this it was possible to build with CONFIG_COMMON_CLK=n and any error was reported[1] I didn't want to add Kconfig dependency as this driver doesn't use any other clock apis and this was added to meet some OPP(?) requirement IIRC. We can drop the call to devm_of_clk_add_hw_provider if that is not the case. I need to check it again as I can't recall all the details right now. -- Regards, Sudeep [1] https://www.uwsg.indiana.edu/hypermail/linux/kernel/2012.0/04953.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel