linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static
@ 2023-07-19 22:20 Min-Hua Chen
  2023-07-20 18:53 ` Sven Peter
  0 siblings, 1 reply; 3+ messages in thread
From: Min-Hua Chen @ 2023-07-19 22:20 UTC (permalink / raw)
  To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Joerg Roedel,
	Will Deacon, Robin Murphy
  Cc: Min-Hua Chen, asahi, linux-arm-kernel, iommu, linux-kernel

This patch fixes the following sprse warning:

drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol 'apple_dart_pm_ops' was not declared. Should it be static?

No functional change intended.

Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---
 drivers/iommu/apple-dart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
index 8af64b57f048..2082081402d3 100644
--- a/drivers/iommu/apple-dart.c
+++ b/drivers/iommu/apple-dart.c
@@ -1276,7 +1276,7 @@ static __maybe_unused int apple_dart_resume(struct device *dev)
 	return 0;
 }
 
-DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, apple_dart_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, apple_dart_resume);
 
 static const struct of_device_id apple_dart_of_match[] = {
 	{ .compatible = "apple,t8103-dart", .data = &apple_dart_hw_t8103 },
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static
  2023-07-19 22:20 [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static Min-Hua Chen
@ 2023-07-20 18:53 ` Sven Peter
  2023-07-20 23:18   ` Min-Hua Chen
  0 siblings, 1 reply; 3+ messages in thread
From: Sven Peter @ 2023-07-20 18:53 UTC (permalink / raw)
  To: Min-Hua Chen, Hector Martin, Alyssa Rosenzweig, Joerg Roedel,
	Will Deacon, Robin Murphy
  Cc: asahi, linux-arm-kernel, iommu, linux-kernel

On Thu, Jul 20, 2023, at 00:20, Min-Hua Chen wrote:
> This patch fixes the following sprse warning:

typo: sparse

>
> drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol 
> 'apple_dart_pm_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---

Acked-by: Sven Peter <sven@svenpeter.dev>

Thanks,


Sven

>  drivers/iommu/apple-dart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
> index 8af64b57f048..2082081402d3 100644
> --- a/drivers/iommu/apple-dart.c
> +++ b/drivers/iommu/apple-dart.c
> @@ -1276,7 +1276,7 @@ static __maybe_unused int 
> apple_dart_resume(struct device *dev)
>  	return 0;
>  }
> 
> -DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, 
> apple_dart_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, 
> apple_dart_resume);
> 
>  static const struct of_device_id apple_dart_of_match[] = {
>  	{ .compatible = "apple,t8103-dart", .data = &apple_dart_hw_t8103 },
> -- 
> 2.34.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static
  2023-07-20 18:53 ` Sven Peter
@ 2023-07-20 23:18   ` Min-Hua Chen
  0 siblings, 0 replies; 3+ messages in thread
From: Min-Hua Chen @ 2023-07-20 23:18 UTC (permalink / raw)
  To: sven
  Cc: alyssa, asahi, iommu, joro, linux-arm-kernel, linux-kernel,
	marcan, minhuadotchen, robin.murphy, will

Hi Sven,

>On Thu, Jul 20, 2023, at 00:20, Min-Hua Chen wrote:
>> This patch fixes the following sprse warning:
>
>typo: sparse

thanks for catching this.

>>
>> drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol 
>> 'apple_dart_pm_ops' was not declared. Should it be static?
>>
>> No functional change intended.
>>
>> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
>> ---
>
>Acked-by: Sven Peter <sven@svenpeter.dev>

I'll submit v2 with your Acked-by tag.

thanks,
Min-Hua

>Thanks,
>
>
>Sven


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-20 23:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-19 22:20 [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static Min-Hua Chen
2023-07-20 18:53 ` Sven Peter
2023-07-20 23:18   ` Min-Hua Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).