* [PATCH v2] iommu/apple-dart: mark apple_dart_pm_ops static
@ 2023-07-20 23:21 Min-Hua Chen
2023-08-07 12:28 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Min-Hua Chen @ 2023-07-20 23:21 UTC (permalink / raw)
To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Joerg Roedel,
Will Deacon, Robin Murphy
Cc: Min-Hua Chen, asahi, linux-arm-kernel, iommu, linux-kernel
This patch fixes the following sparse warning:
drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol 'apple_dart_pm_ops' was not declared. Should it be static?
No functional change intended.
Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
Acked-by: Sven Peter <sven@svenpeter.dev>
---
Change since v1:
fix a typo
---
drivers/iommu/apple-dart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
index 8af64b57f048..2082081402d3 100644
--- a/drivers/iommu/apple-dart.c
+++ b/drivers/iommu/apple-dart.c
@@ -1276,7 +1276,7 @@ static __maybe_unused int apple_dart_resume(struct device *dev)
return 0;
}
-DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, apple_dart_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, apple_dart_resume);
static const struct of_device_id apple_dart_of_match[] = {
{ .compatible = "apple,t8103-dart", .data = &apple_dart_hw_t8103 },
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] iommu/apple-dart: mark apple_dart_pm_ops static
2023-07-20 23:21 [PATCH v2] iommu/apple-dart: mark apple_dart_pm_ops static Min-Hua Chen
@ 2023-08-07 12:28 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2023-08-07 12:28 UTC (permalink / raw)
To: Min-Hua Chen
Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, Will Deacon,
Robin Murphy, asahi, linux-arm-kernel, iommu, linux-kernel
On Fri, Jul 21, 2023 at 07:21:54AM +0800, Min-Hua Chen wrote:
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> Acked-by: Sven Peter <sven@svenpeter.dev>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-07 12:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-20 23:21 [PATCH v2] iommu/apple-dart: mark apple_dart_pm_ops static Min-Hua Chen
2023-08-07 12:28 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).