linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5] ARM: dts: bcm5301x: Add SEAMA compatibles
@ 2023-07-22 21:07 Linus Walleij
  2023-07-28 16:12 ` Florian Fainelli
  0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2023-07-22 21:07 UTC (permalink / raw)
  To: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki,
	Broadcom internal kernel review list
  Cc: linux-arm-kernel, Linus Walleij

This adds SEAMA compatibles to the firmware partition of these
two D-Link devices.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
This type of firmware partition appear in some devices in
NAND flash, so we need to be able to tag the partitions
with the appropriate type.

The origin of the "SEAttle iMAge" is unknown.
---
Changes in v5:
- Resend just the ARM DTS change
- Link to v4: https://lore.kernel.org/r/20230713-seama-partitions-v4-0-69e577453d40@linaro.org

Changes in v4:
- Drop the false tagging of #address-cells etc
- Link to v3: https://lore.kernel.org/r/20230707-seama-partitions-v3-0-6aa9391b46bb@linaro.org

Changes in v3:
- Drop reference from partitions.yaml again
- Drop select: false
- Use unevaluatedProperties
- Link to v2: https://lore.kernel.org/r/20230705-seama-partitions-v2-0-9d349f0d5ab7@linaro.org

Changes in v2:
- Make the binding clearly childless
- Link to v1: https://lore.kernel.org/r/20230506-seama-partitions-v1-0-5806af1e4ac7@linaro.org
---
The required bindings are applied to the MTD tree.
---
 arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts | 1 +
 arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts b/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts
index 51ce510b3e3a..c914569ddd5e 100644
--- a/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts
@@ -33,6 +33,7 @@ partitions {
 				#size-cells = <1>;
 
 				partition@0 {
+					compatible = "seama";
 					label = "firmware";
 					reg = <0x00000000 0x08000000>;
 				};
diff --git a/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts b/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts
index 60744f82c2b7..f050acbea0b2 100644
--- a/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts
@@ -149,6 +149,7 @@ partitions {
 		 * partitions: this device uses SEAMA.
 		 */
 		firmware@0 {
+			compatible = "seama";
 			label = "firmware";
 			reg = <0x00000000 0x08000000>;
 		};

---
base-commit: 1d5653084d36db5cb55ff359bf74e8e721165bb8
change-id: 20230506-seama-partitions-b620117b9985

Best regards,
-- 
Linus Walleij <linus.walleij@linaro.org>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v5] ARM: dts: bcm5301x: Add SEAMA compatibles
  2023-07-22 21:07 [PATCH v5] ARM: dts: bcm5301x: Add SEAMA compatibles Linus Walleij
@ 2023-07-28 16:12 ` Florian Fainelli
  2023-07-28 18:38   ` Linus Walleij
  0 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2023-07-28 16:12 UTC (permalink / raw)
  To: Linus Walleij, Florian Fainelli, Hauke Mehrtens,
	Rafał Miłecki, Broadcom internal kernel review list
  Cc: linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 640 bytes --]

Hi Linus,

On 7/22/2023 2:07 PM, Linus Walleij wrote:
> This adds SEAMA compatibles to the firmware partition of these
> two D-Link devices.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> This type of firmware partition appear in some devices in
> NAND flash, so we need to be able to tag the partitions
> with the appropriate type.
> 
> The origin of the "SEAttle iMAge" is unknown.

I applied v4 before by ensuring that it applied to the 
arch/arm/boot/dts/broadcom/ folder, shall I replace that commit with v5 
here?

https://github.com/Broadcom/stblinux/commit/72ec77d74d28be7359ef77971cdee38b60af9e49
-- 
Florian

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v5] ARM: dts: bcm5301x: Add SEAMA compatibles
  2023-07-28 16:12 ` Florian Fainelli
@ 2023-07-28 18:38   ` Linus Walleij
  2023-07-28 18:40     ` Florian Fainelli
  0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2023-07-28 18:38 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki,
	Broadcom internal kernel review list, linux-arm-kernel

On Fri, Jul 28, 2023 at 6:12 PM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:

> On 7/22/2023 2:07 PM, Linus Walleij wrote:
> > This adds SEAMA compatibles to the firmware partition of these
> > two D-Link devices.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > This type of firmware partition appear in some devices in
> > NAND flash, so we need to be able to tag the partitions
> > with the appropriate type.
> >
> > The origin of the "SEAttle iMAge" is unknown.
>
> I applied v4 before by ensuring that it applied to the
> arch/arm/boot/dts/broadcom/ folder, shall I replace that commit with v5
> here?

No need, it's the same. I was just resending it.
Thanks and sorry for the confusion!

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v5] ARM: dts: bcm5301x: Add SEAMA compatibles
  2023-07-28 18:38   ` Linus Walleij
@ 2023-07-28 18:40     ` Florian Fainelli
  0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2023-07-28 18:40 UTC (permalink / raw)
  To: Linus Walleij, Florian Fainelli
  Cc: Hauke Mehrtens, Rafał Miłecki,
	Broadcom internal kernel review list, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 826 bytes --]

On 7/28/23 11:38, Linus Walleij wrote:
> On Fri, Jul 28, 2023 at 6:12 PM Florian Fainelli
> <florian.fainelli@broadcom.com> wrote:
> 
>> On 7/22/2023 2:07 PM, Linus Walleij wrote:
>>> This adds SEAMA compatibles to the firmware partition of these
>>> two D-Link devices.
>>>
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>> ---
>>> This type of firmware partition appear in some devices in
>>> NAND flash, so we need to be able to tag the partitions
>>> with the appropriate type.
>>>
>>> The origin of the "SEAttle iMAge" is unknown.
>>
>> I applied v4 before by ensuring that it applied to the
>> arch/arm/boot/dts/broadcom/ folder, shall I replace that commit with v5
>> here?
> 
> No need, it's the same. I was just resending it.
> Thanks and sorry for the confusion!

It's all good, thanks!
-- 
Florian


[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-28 18:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-22 21:07 [PATCH v5] ARM: dts: bcm5301x: Add SEAMA compatibles Linus Walleij
2023-07-28 16:12 ` Florian Fainelli
2023-07-28 18:38   ` Linus Walleij
2023-07-28 18:40     ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).