From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB390C001DC for ; Thu, 27 Jul 2023 08:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=15sDBGI87+3GymMc4XFj3qH+EGNCkLF3OB6o15fBjIQ=; b=p+NcKTkdymIsS7 GOVIPU5fTj+G7nKFhLVrQk8pv4H607rSmyEt5QPHmx8gU/k9rKCp5uPb6VSWEzYWmWRvqO+e0Uo46 +UW6Q7OnJJbGepg1w0fMzyeWDr3oOCAX2i2bG6miUKFi3ir6DfNducG5/xUSl1qtdMPtsNS28pyti OsZvc7Ei5jHNlIqM+Ar8GNeAGFrTYX1xohoD/25lOyrJ6xYBtXVxrcxZCXp3fepVERTPEWd+tKROc RALggLQGjHPkhrZkTJL0481OfhrQOV/rUkIZnClal5Da2zq8NQhmxFkU2TaSn03bq+eM00kT/aKHI atCKCeopmwieJqhLimAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOwWO-00Chvh-2s; Thu, 27 Jul 2023 08:38:57 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOwWM-00Chv9-0V for linux-arm-kernel@lists.infradead.org; Thu, 27 Jul 2023 08:38:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5F73D61DA9; Thu, 27 Jul 2023 08:38:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21134C433C7; Thu, 27 Jul 2023 08:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690447132; bh=YVvOjlN4QplbkTfUU8STJw6R9WuXHmqKUY5GkeuIEdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GmQUMygFjMhCHkEk7yNzMmMF6abTQoBE2kpsz8puTVGsKxh+A8yAAolQbhGOvnKFn PX400gUHtC/md1+4FBlUB3OYXsMjOYgkKwM+ZIxh1gxpI6ayza3MPoQmdeTkzAItdC M0CP3Qlru2Qin1PNkXBUmOJerKsiyGL//2j76TVcheZxpbXYzYKryaiwychlQTvuth efNcp05P1eooNxVwWENa8dx/DKi9SqdqyHy4qIUGkbBTlUoulOi6WsP9svaovm6ZND qfy7gEwkAu2t6z9ECQ6tWo5JHKeH+hOVMO5q4VYuQpy6wCWuScZ9KLJXDWVf9DVMWN LPx+ZGdwdQ+IQ== Date: Thu, 27 Jul 2023 10:38:49 +0200 From: Andi Shyti To: carlos.song@nxp.com Cc: aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, xiaoning.wang@nxp.com, haibo.chen@nxp.com, linux-imx@nxp.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] i2c: imx-lpi2c: directly return ISR when detect a NACK Message-ID: <20230727083849.qcsmgqds3wyre72t@intel.intel> References: <20230727030347.3552992-1-carlos.song@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230727030347.3552992-1-carlos.song@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_013854_244445_E3CDED9F X-CRM114-Status: GOOD ( 10.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Carlos, On Thu, Jul 27, 2023 at 11:03:47AM +0800, carlos.song@nxp.com wrote: > From: Carlos Song > > A NACK flag in ISR means i2c bus error. In such condition, > there is no need to do read/write operation. > > In this patch, i2c will check MSR_NDF, MSR_RDF and MSR_TDF > flag in turn, it's making mutually exclusive NACK/read/write. > So when a NACK is received(MSR_NDF), i2c will return ISR > directly and then stop i2c transfer. > > Signed-off-by: Carlos Song thanks! Reviewed-by: Andi Shyti Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel