From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 176EAC001DC for ; Thu, 27 Jul 2023 13:31:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tE187hDKNaUAfOWAKrSlXDzctdVl29Tg/LOz8G/MUQM=; b=OOpJ6PpijBkKV6 8ZnZbAYtJ3U2JKxzuUwV5Sncm+Fl54G5GPbgExPrGb7LAihy3Ma4XgTKxTZwSlQ/ml1DlpWBWxw9c 8gYUyCbhhA9G01YHC0aXLi/k0rkhgUPJpMzd8tL3VEnpdjP3zVtWSl1dGWZljLouDQOoe7KPpTheC pu018iitRY5cYSI+rqBlcC+K7PMrwy5Gv1xzf1Cvwg7l2C8Of6V7MV82ysta8v287rJHoZZ/HRycD WoPi8UaHnrHQWfsgEL4CKoBCotMHdwgGQA8c85AvgexQ1xmcE9JMad83GgCGxsQ9Hc2wmzYQj+YQC BJBJdFiXzpQZlydJfkYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qP151-00EZKh-0U; Thu, 27 Jul 2023 13:30:59 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qP14y-00EZII-0O for linux-arm-kernel@lists.infradead.org; Thu, 27 Jul 2023 13:30:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6B07161E84; Thu, 27 Jul 2023 13:30:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33BA2C433C7; Thu, 27 Jul 2023 13:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690464654; bh=LV01kr3qsrJi1EDGWuqWhLrfy7F4nZBAVqWzOvclfKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P0vXmgVOAS07LL1gN3Y8D3UAEZagkSeUNGNX3FPmVe85eyY6IGwd3Lj9hB8pa78ly 41fOE2jetCyxStXoxb3iH2SKpk0MRQ0ffnhqMY6f2616tWdRstMZekrOWKR3KghJ76 XdpytBMSq1NxhNVTj3GW0p7PgjX/smTfQpkr0lXFbqZ1lCSRExmm606y0gO78kyfO+ VzKvM0w4rYWb3PWHInv7Zu2Kpg5OOQ51PJPLwdLv/JEaCAskxaf/6CZ/LR0YgxCpZ0 7D621aE4wcD3I6cW/bdRe8aFqoC6p+h9RJd91ETimDhKgY/g/1qYBpS3oadY4KBMAA zbKFnUSHlWDLQ== Date: Thu, 27 Jul 2023 15:30:51 +0200 From: Andi Shyti To: Chen Jiahao Cc: broonie@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next] spi: s3c64xx: Clean up redundant dev_err_probe() Message-ID: <20230727133051.jjngbtdqvclfyolk@intel.intel> References: <20230727131635.2898051-1-chenjiahao16@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230727131635.2898051-1-chenjiahao16@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_063056_227271_FEB2EC11 X-CRM114-Status: UNSURE ( 9.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chen, On Thu, Jul 27, 2023 at 09:16:35PM +0800, Chen Jiahao wrote: > Referring to platform_get_irq()'s definition, the return value has > already been checked if ret < 0, and printed via dev_err_probe(). > Calling dev_err_probe() one more time outside platform_get_irq() > is obviously redundant. > > Removing dev_err_probe() outside platform_get_irq() to clean up > above problem. > > Signed-off-by: Chen Jiahao Reviewed-by: Andi Shyti Thanks, Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel