From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D18F5C0015E for ; Thu, 27 Jul 2023 15:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9oeleJgD88JfNSOfAV6y/cMpmuub+yB4Ws7xs+lXXNo=; b=NhtXVsWHL8BZp3 ksF06C3NRkgyaDfxfi1uzD3DpcyJzbCnK9ppIgLdhqcqZC4zSSQ/B7iJdqAzzWzCHSy07eGDaPxDw lufgJ149WTqcpUQ/WnNyVbbcIfe4O4i3KJQzNEG7bQW+a30Ji36rUhj0C9H2WSKXImUd45fvL5uZR lNLlED1ckaK1FOhxIv+sQdGHMk75/fNzeVRu7hHjF7RnswL7R0gfy1H2mrel5neIEhDc4OiEJkQCv S+Y4X9ozK8vtSEElRyfVti2sv/QhcX78K9/yzXw/FnZ7HWiD7ar+ErFcbIAy5oTXx9dXLDdVcZby0 zSwC+kou8nkCKnlmsM6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qP2UI-00FZg6-1E; Thu, 27 Jul 2023 15:01:10 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qP2Tx-00FZPH-2O for linux-arm-kernel@lists.infradead.org; Thu, 27 Jul 2023 15:00:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 24EB861E9A; Thu, 27 Jul 2023 15:00:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F260C433C7; Thu, 27 Jul 2023 15:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690470048; bh=xK7Ub5uts6ZqW0uNEPNO/65yJ7tQxvMALn4ycps0P1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ISc2eBWEQIMT8jOdH/6ZNpiSIOp5EnIavPwuLBKP3PkSZ5bgHgCpmbMGNwFRjmFZN 57lu8UIh27zwDX3CXMcEzpcoNo8ht3rEo0iaN0MuI76UnnC6WW5+RbIRnaXAKGhrT0 xjQa4kx1MEEb5EycLHUgeZCmIoH2IL94f88TDatk28UKpU0Zx2S23r4C5zJ8f3kQAn SWE30j34fpO7k8T32ICBuMyZTk0hq1mL2pYMecR+vkQEe6T/gNP623CDbnGj27HQFx 56+GpOS8rX11jG6/cMwKYjIK1ar+21Nw3KleZwqw4BgVRx1Qf3/rmtnmnNLqfoxrQG hImyC+hq/MOWQ== Date: Thu, 27 Jul 2023 16:00:43 +0100 From: Will Deacon To: Lorenzo Pieralisi Cc: Catalin Marinas , Guanghui Feng , guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, alikernel-developer@linux.alibaba.com Subject: Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info() Message-ID: <20230727150042.GC19940@willie-the-truck> References: <1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_080049_854628_15F9EBF1 X-CRM114-Status: GOOD ( 22.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 27, 2023 at 04:17:49PM +0200, Lorenzo Pieralisi wrote: > On Thu, Jul 27, 2023 at 02:59:02PM +0100, Catalin Marinas wrote: > > On Thu, Jul 27, 2023 at 03:39:27PM +0200, Lorenzo Pieralisi wrote: > > > On Mon, Jul 17, 2023 at 07:33:45PM +0800, Guanghui Feng wrote: > > > > According to the ARM IORT specifications DEN 0049 issue E, > > > > the "Number of IDs" field in the ID mapping format reports > > > > the number of IDs in the mapping range minus one. > > > > > > > > In iort_node_get_rmr_info(), we erroneously skip ID mappings > > > > whose "Number of IDs" equal to 0, resulting in valid mapping > > > > nodes with a single ID to map being skipped, which is wrong. > > > > > > > > Fix iort_node_get_rmr_info() by removing the bogus id_count > > > > check. > > > > > > > > Fixes: 491cf4a6735a ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions") > > > > Signed-off-by: Guanghui Feng > > > > --- > > > > drivers/acpi/arm64/iort.c | 3 --- > > > > 1 file changed, 3 deletions(-) > > > > > > Acked-by: Lorenzo Pieralisi > > > > > > Catalin/Will, > > > > > > can you pick this up please ? > > > > Would you like it merged in 6.5 or 6.6 is fine? > > It is definitely a fix - I don't think that's super urgent > though, bug has been there since v6.0 so the fix can probably > wait to trickle back from v6.6. On the flip side, it's a fix, Hanjun has tested it and we have a few weeks in case we need to revert it. So I'd be inclined to say Catalin should pick it up for 6.5, unless there's a good reason to wait? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel