From: Dhruva Gole <d-gole@ti.com>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: <sre@kernel.org>, <matthias.bgg@gmail.com>,
<angelogioacchino.delregno@collabora.com>, <agross@kernel.org>,
<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
<linux-pm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH -next v2] power: supply: Remove redundant dev_err_probe() for platform_get_irq_byname()
Date: Fri, 28 Jul 2023 13:44:45 +0530 [thread overview]
Message-ID: <20230728081445.bmij44pfbckyyrr7@dhruva> (raw)
In-Reply-To: <20230727113550.2599335-1-ruanjinjie@huawei.com>
On Jul 27, 2023 at 19:35:50 +0800, Ruan Jinjie wrote:
> There is no need to call the dev_err_probe() function directly to print
> a custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message
> in case of a failure.
Ah yes, good catch!
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> v2:
> - clarify the commit title
> ---
> drivers/power/supply/mt6370-charger.c | 4 +---
> drivers/power/supply/qcom_pmi8998_charger.c | 3 +--
> 2 files changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Dhruva Gole <d-gole@ti.com>
>
> diff --git a/drivers/power/supply/mt6370-charger.c b/drivers/power/supply/mt6370-charger.c
> index f27dae5043f5..571cf00dde07 100644
> --- a/drivers/power/supply/mt6370-charger.c
> +++ b/drivers/power/supply/mt6370-charger.c
> @@ -849,9 +849,7 @@ static int mt6370_chg_init_irq(struct mt6370_priv *priv)
> ret = platform_get_irq_byname(to_platform_device(priv->dev),
> mt6370_chg_irqs[i].name);
> if (ret < 0)
> - return dev_err_probe(priv->dev, ret,
> - "Failed to get irq %s\n",
> - mt6370_chg_irqs[i].name);
> + return ret;
>
> priv->irq_nums[i] = ret;
> ret = devm_request_threaded_irq(priv->dev, ret, NULL,
> diff --git a/drivers/power/supply/qcom_pmi8998_charger.c b/drivers/power/supply/qcom_pmi8998_charger.c
> index d16c5ee17249..ce7392e7d8b8 100644
> --- a/drivers/power/supply/qcom_pmi8998_charger.c
> +++ b/drivers/power/supply/qcom_pmi8998_charger.c
> @@ -922,8 +922,7 @@ static int smb2_init_irq(struct smb2_chip *chip, int *irq, const char *name,
>
> irqnum = platform_get_irq_byname(to_platform_device(chip->dev), name);
> if (irqnum < 0)
> - return dev_err_probe(chip->dev, irqnum,
> - "Couldn't get irq %s byname\n", name);
> + return irqnum;
>
> rc = devm_request_threaded_irq(chip->dev, irqnum, NULL, handler,
> IRQF_ONESHOT, name, chip);
> --
> 2.34.1
>
--
Best regards,
Dhruva Gole <d-gole@ti.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-28 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 11:35 [PATCH -next v2] power: supply: Remove redundant dev_err_probe() for platform_get_irq_byname() Ruan Jinjie
2023-07-28 8:14 ` Dhruva Gole [this message]
2023-09-12 19:08 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728081445.bmij44pfbckyyrr7@dhruva \
--to=d-gole@ti.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ruanjinjie@huawei.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox