Re: [PATCH 8/8] mtd: rawnand: qcom: Fix address parsing within ->exec_op()

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sricharan Ramabadhran <quic_srichara@quicinc.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
	Md Sadre Alam <quic_mdalam@quicinc.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	"Michael Walle" <michael@walle.cc>,
	<linux-mtd@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 8/8] mtd: rawnand: qcom: Fix address parsing within ->exec_op()
Date: Fri, 28 Jul 2023 09:55:17 +0200	[thread overview]
Message-ID: <20230728095518.1b93454f@xps-13> (raw)
In-Reply-To: <f022d84c-0fe1-7b21-eccf-bc0ba4fd871f@quicinc.com>

Hi Sricharan,

quic_srichara@quicinc.com wrote on Fri, 28 Jul 2023 09:44:37 +0530:

> Hi Miquel,
> 
> On 7/28/2023 8:03 AM, Sricharan Ramabadhran wrote:
> > Hi Miquel,
> > 
> > On 7/27/2023 8:29 PM, Miquel Raynal wrote:  
> >> Hi Sadre,
> >>
> >> mani@kernel.org wrote on Mon, 17 Jul 2023 12:08:43 +0530:
> >>  
> >>> On Sun, Jul 16, 2023 at 04:46:12PM +0200, Miquel Raynal wrote:  
> >>>> The naddrs variable is initialized but not used. Fixing this could have
> >>>> been a matter of dropping the variable, but the right way to do it >>>> looks
> >>>> a bit more complex: we can avoid useless writes to the q_op >>>> structure by
> >>>> using it. In practice we could even have possible out-of-bound bugs >>>> with
> >>>> the existing implementation. Let's fix all that by just performing the
> >>>> right number of assignments in the addr{1,2}_reg fields.
> >>>>
> >>>> Fixes: 89550beb098e ("mtd: rawnand: qcom: Implement exec_op()")
> >>>> Reported-by: kernel test robot <lkp@intel.com>
> >>>> Closes: >>>> https://lore.kernel.org/oe-kbuild-all/202307131959.PdPSC86K-lkp@intel.com/ >>>>
> >>>> Closes: >>>> https://lore.kernel.org/oe-kbuild-all/202307131730.NOYbcjBr-lkp@intel.com/ >>>>
> >>>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>  
> >>>
> >>> LGTM! But I'm relying on Sadre to test it.
> >>>
> >>> Acked-by: Manivannan Sadhasivam <mani@kernel.org>  
> >>
> >> I don't think I've received feedback from Sadre, I would like to close
> >> these issues, can you please test and give us feedback?
> >>  
> > 
> >   Sorry for the delay in response. Testing this, will respond back
> >   shortly today.  
> 
>   Tested this series on ipq8074-hk01 board.
>   Tested bootcheck, both /dev/mtd and /dev/mtdblock for data integrity.
>   All looks fine. So,
> 
>   Tested-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>

Thanks for the test! I'll take the series now then.

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel