From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19A8FC0015E for ; Fri, 28 Jul 2023 16:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=er+Paq/HGjIpkhrGY+RBypgCdHruzl39gSq/Hy7WvRY=; b=HfTDbaL9xiI6gB 9kRNKj3+0p6hgfSViaTgI5htEDYcZUK7IJkDhpFgtWrVaT/lZg3qI0AKZtn6gRUHfvk22O9ILn2+a Q38go0X5iK7WWsqcnXMyipuDCCRB7nNKsfA6kdyszN+EhXNyTtDkPVj7vkUb/vUkDnUGpqLIhQfas uyyfmUZ4SVaTfX2CQk1EDdWbcHm69Mvga/fDawFyV6Q6hqXK2d1n3c/TXCWCgxRZfuXHIHUeYZ8jh vLaaU7p4u6luc67/UbOJ8dxVW+xPYn9XG2VVkIEP0ZGyXbS4unEqMtFVDXcjhkwwhmf/5BVM/8VI/ +epnDD2O0PhZvEZmF1UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPQCV-0042jc-33; Fri, 28 Jul 2023 16:20:23 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPQCS-0042jA-24 for linux-arm-kernel@lists.infradead.org; Fri, 28 Jul 2023 16:20:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1BE1F62197; Fri, 28 Jul 2023 16:20:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 177EBC433C8; Fri, 28 Jul 2023 16:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690561219; bh=54MBqcw7ll+B/9DNGmX7N8jbDcKh/YfDc7wKAAwwCSQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kXUW4yU3b9+EbfFAnlCu5wXpY78EhCMIaXLkksSu9SjyKIUgi9VByK834Y5kXsYYe owTZYS0/58fjy0KvMP0s12fWFQ4EISUtvzgfGCUSRBM2xFG9IYFwe4jq+rJpU1LJ2k ReAvnUXdVONC4Fq3IHPTRNgBRfM4SE2CzJDcAXIq38bQ7aLz+MgmtIujXVQDklYBRs Ipw/lr1SFDR0Qbq7/XnYDzW8BcaU66EKBgGk03SXF5jrpf3SkVQca6hd3OOIrGBbJm j0oESWznR+asqrsdzpz4mdUCrjUh/LTtoJt7gsrpMYb5iJh1OThWX1wp3SkOO4gwyM TonJVT03FnJCQ== Date: Fri, 28 Jul 2023 17:20:13 +0100 From: Will Deacon To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, Mark Brown , James Clark , Rob Herring , Marc Zyngier , Suzuki Poulose , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org Subject: Re: [PATCH V13 - RESEND 02/10] arm64/perf: Add BRBE registers and fields Message-ID: <20230728162011.GA22050@willie-the-truck> References: <20230711082455.215983-1-anshuman.khandual@arm.com> <20230711082455.215983-3-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230711082455.215983-3-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230728_092020_724152_EE0827E1 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 11, 2023 at 01:54:47PM +0530, Anshuman Khandual wrote: > This adds BRBE related register definitions and various other related field > macros there in. These will be used subsequently in a BRBE driver which is > being added later on. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Tested-by: James Clark > Reviewed-by: Mark Brown > Signed-off-by: Anshuman Khandual > --- > arch/arm64/include/asm/sysreg.h | 103 +++++++++++++++++++++ > arch/arm64/tools/sysreg | 158 ++++++++++++++++++++++++++++++++ > 2 files changed, 261 insertions(+) > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index b481935e9314..f95e30c13c8b 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -163,6 +163,109 @@ > #define SYS_DBGDTRTX_EL0 sys_reg(2, 3, 0, 5, 0) > #define SYS_DBGVCR32_EL2 sys_reg(2, 4, 0, 7, 0) > > +#define __SYS_BRBINFO(n) sys_reg(2, 1, 8, ((n) & 0xf), ((((n) & 0x10)) >> 2 + 0)) > +#define __SYS_BRBSRC(n) sys_reg(2, 1, 8, ((n) & 0xf), ((((n) & 0x10)) >> 2 + 1)) > +#define __SYS_BRBTGT(n) sys_reg(2, 1, 8, ((n) & 0xf), ((((n) & 0x10)) >> 2 + 2)) It's that time on a Friday but... aren't these macros busted? I think you need brackets before adding the offset, otherwise wouldn't, for example, target registers 0-15 all access info register 0 and __SYS_BRBTGT(16) would then start accessing source register 0? I'm surprised that the compiler doesn't warn about this, but even more surprised that you managed to test this. Please tell me I'm wrong! Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel