From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B23EEB64DD for ; Sat, 29 Jul 2023 00:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3aQaVDXlBbUcEgkeLiSfgUWNii6/qcMKsYrIgkTTnDo=; b=ONiHdFy5mK50NL Gacl18dJeURgfbPNbn3ZzwF1rbJ3pJZK6Uq6WfvVevZtkENbf/smlvbL9qA8uE455VWXSbXUJuFKD +kCnyieORU77xb5xOdBohU5FTzPfTk5GlZdWUQsECscEtPOU5sHQ0b3jG7OumSqTSE2E3YM/xGoyO cB9vOgeYZbN4/aNfi0ZtX/yyyLRQhBUhSVZjM04F2u/29aTOobuF3yFOjCTfqmFEeIwZAgv7AKygg 14U+RYuxNr394ayibvb0dgd/5lq3c8cMFhMRThDontY+wxoMNM9mvZg00Kqnz/Ab6jXByvxDxodz6 C4d8yXELn78JS+f5ay8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPXmH-005bWf-1y; Sat, 29 Jul 2023 00:25:49 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPXmE-005bVt-2Z for linux-arm-kernel@lists.infradead.org; Sat, 29 Jul 2023 00:25:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4DA1762224; Sat, 29 Jul 2023 00:25:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FAACC433C7; Sat, 29 Jul 2023 00:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690590345; bh=xoYh6nl7Ymq+oEY+0iyKXVVHHgnEX73mQRAcXMXhUfA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BCiqoZRADYsp7o6W43xzzcFifZX/tdqC4zkUqVu6R4lkllSL+7EE0vp6+VLek8YBq Y6dJlZmalMnKiLu/4TKlRrBiBnAI1qDC+3pVNkOD6JbfGasZ4MjshJkm09OWQFFays VpfMI6e3Um+iCDfsKebGSboT8UH4PO70WLFF880LAlBfYz9N57xl17hAkBY+gDf7D3 1SchvxhtDTIocM1Fm8VJhpuwLhdq0GALw0ftDZ77FZ4oFBr144+3vD+etwu9NhSLiO iD6f/vTZMcWLuHAZ/RAnCe4VoWRS88niwBzOycLaSGvIE24lo7GMJ1Fcs3wfcp7H4r aczenDH6y1PNg== Date: Fri, 28 Jul 2023 17:25:43 -0700 From: Jakub Kicinski To: MD Danish Anwar Cc: Randy Dunlap , Roger Quadros , Simon Horman , Vignesh Raghavendra , Andrew Lunn , Richard Cochran , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Eric Dumazet , "David S. Miller" , , , , , , , Subject: Re: [PATCH v12 06/10] net: ti: icssg-prueth: Add ICSSG ethernet driver Message-ID: <20230728172543.2d5f5660@kernel.org> In-Reply-To: <20230727112827.3977534-7-danishanwar@ti.com> References: <20230727112827.3977534-1-danishanwar@ti.com> <20230727112827.3977534-7-danishanwar@ti.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230728_172546_912794_79AA73CC X-CRM114-Status: UNSURE ( 7.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 27 Jul 2023 16:58:23 +0530 MD Danish Anwar wrote: > +/* Classifier helpers */ > +void icssg_class_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac); > +void icssg_class_set_host_mac_addr(struct regmap *miig_rt, const u8 *mac); > +void icssg_class_disable(struct regmap *miig_rt, int slice); > +void icssg_class_default(struct regmap *miig_rt, int slice, bool allmulti); > +void icssg_ft1_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac_addr); > + > +/* Buffer queue helpers */ > +int icssg_queue_pop(struct prueth *prueth, u8 queue); > +void icssg_queue_push(struct prueth *prueth, int queue, u16 addr); > +u32 icssg_queue_level(struct prueth *prueth, int queue); If you create the prototypes when the functions are added there will be less need for __maybe_unused. Compiler only cares about prototypes existing, not whether actual callers are in place. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel