linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet block
@ 2023-07-29 11:04 Rafał Miłecki
  2023-07-29 14:08 ` Arınç ÜNAL
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Rafał Miłecki @ 2023-07-29 11:04 UTC (permalink / raw)
  To: Thomas Bogendoerfer
  Cc: Arınç ÜNAL, Sergio Paracuellos, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Greg Kroah-Hartman, linux-mips,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

Use order as specified in the binding (first "ethif" then "fe").

This fixes:
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:0: 'ethif' was expected
        From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:1: 'fe' was expected
        From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml

Fixes: 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/mips/boot/dts/ralink/mt7621.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
index 7caed0d14f11..73035d4f4cc1 100644
--- a/arch/mips/boot/dts/ralink/mt7621.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
@@ -300,9 +300,9 @@ ethernet: ethernet@1e100000 {
 		compatible = "mediatek,mt7621-eth";
 		reg = <0x1e100000 0x10000>;
 
-		clocks = <&sysc MT7621_CLK_FE>,
-			 <&sysc MT7621_CLK_ETH>;
-		clock-names = "fe", "ethif";
+		clocks = <&sysc MT7621_CLK_ETH>,
+			 <&sysc MT7621_CLK_FE>;
+		clock-names = "ethif", "fe";
 
 		#address-cells = <1>;
 		#size-cells = <0>;
-- 
2.35.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet block
  2023-07-29 11:04 [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet block Rafał Miłecki
@ 2023-07-29 14:08 ` Arınç ÜNAL
  2023-08-01  6:42   ` Arınç ÜNAL
  2023-07-31 10:32 ` AngeloGioacchino Del Regno
  2023-08-01  6:33 ` Sergio Paracuellos
  2 siblings, 1 reply; 5+ messages in thread
From: Arınç ÜNAL @ 2023-07-29 14:08 UTC (permalink / raw)
  To: Rafał Miłecki, Thomas Bogendoerfer
  Cc: Sergio Paracuellos, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Greg Kroah-Hartman, linux-mips, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, Rafał Miłecki

On 29.07.2023 14:04, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Use order as specified in the binding (first "ethif" then "fe").
> 
> This fixes:
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:0: 'ethif' was expected
>          From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:1: 'fe' was expected
>          From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
> 
> Fixes: 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

I'm not sure if I should agree with this patch. The relevant parts of 
the schema for mediatek,mt7621-eth were added way later than the 
existing bindings on mt7621.dtsi. Why don't we address this on the 
schema along with a bunch of other issues the patch for 
mediatek,mt7621-eth brought?

Arınç

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet block
  2023-07-29 11:04 [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet block Rafał Miłecki
  2023-07-29 14:08 ` Arınç ÜNAL
@ 2023-07-31 10:32 ` AngeloGioacchino Del Regno
  2023-08-01  6:33 ` Sergio Paracuellos
  2 siblings, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-07-31 10:32 UTC (permalink / raw)
  To: Rafał Miłecki, Thomas Bogendoerfer
  Cc: Arınç ÜNAL, Sergio Paracuellos, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Greg Kroah-Hartman, linux-mips, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, Rafał Miłecki

Il 29/07/23 13:04, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Use order as specified in the binding (first "ethif" then "fe").
> 
> This fixes:
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:0: 'ethif' was expected
>          From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:1: 'fe' was expected
>          From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
> 
> Fixes: 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet block
  2023-07-29 11:04 [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet block Rafał Miłecki
  2023-07-29 14:08 ` Arınç ÜNAL
  2023-07-31 10:32 ` AngeloGioacchino Del Regno
@ 2023-08-01  6:33 ` Sergio Paracuellos
  2 siblings, 0 replies; 5+ messages in thread
From: Sergio Paracuellos @ 2023-08-01  6:33 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Thomas Bogendoerfer, Arınç ÜNAL, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Greg Kroah-Hartman, linux-mips,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	Rafał Miłecki

On Sat, Jul 29, 2023 at 1:04 PM Rafał Miłecki <zajec5@gmail.com> wrote:
>
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Use order as specified in the binding (first "ethif" then "fe").
>
> This fixes:
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:0: 'ethif' was expected
>         From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: ethernet@1e100000: clock-names:1: 'fe' was expected
>         From schema: Documentation/devicetree/bindings/net/mediatek,net.yaml
>
> Fixes: 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  arch/mips/boot/dts/ralink/mt7621.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thanks,
    Sergio Paracuellos

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet block
  2023-07-29 14:08 ` Arınç ÜNAL
@ 2023-08-01  6:42   ` Arınç ÜNAL
  0 siblings, 0 replies; 5+ messages in thread
From: Arınç ÜNAL @ 2023-08-01  6:42 UTC (permalink / raw)
  To: Rafał Miłecki, Thomas Bogendoerfer
  Cc: Sergio Paracuellos, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
	Greg Kroah-Hartman, linux-mips, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, Rafał Miłecki

I haven't received anything arguing with this so my answer is still no.

Also, this patch changes the lines introduced with b2f471a26721 
("staging: mt7621-dts: make use of new 'mt7621-clk'").

Arınç

On 29.07.2023 17:08, Arınç ÜNAL wrote:
> On 29.07.2023 14:04, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> Use order as specified in the binding (first "ethif" then "fe").
>>
>> This fixes:
>> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: 
>> ethernet@1e100000: clock-names:0: 'ethif' was expected
>>          From schema: 
>> Documentation/devicetree/bindings/net/mediatek,net.yaml
>> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: 
>> ethernet@1e100000: clock-names:1: 'fe' was expected
>>          From schema: 
>> Documentation/devicetree/bindings/net/mediatek,net.yaml
>>
>> Fixes: 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> I'm not sure if I should agree with this patch. The relevant parts of 
> the schema for mediatek,mt7621-eth were added way later than the 
> existing bindings on mt7621.dtsi. Why don't we address this on the 
> schema along with a bunch of other issues the patch for 
> mediatek,mt7621-eth brought?
> 
> Arınç

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-01  6:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-29 11:04 [PATCH] mips: dts: ralink: reorder MT7621 clocks in Ethernet block Rafał Miłecki
2023-07-29 14:08 ` Arınç ÜNAL
2023-08-01  6:42   ` Arınç ÜNAL
2023-07-31 10:32 ` AngeloGioacchino Del Regno
2023-08-01  6:33 ` Sergio Paracuellos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).