From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50E8DC0015E for ; Sun, 30 Jul 2023 03:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+4jzrsUSvJnjr3LpcU3ziDD98wEFsMBKApeP5DIt3Ww=; b=bxO/WbFAEu+GlJ 3YF0dUmbibedXJd4QeFdtLNOxjm+mP9qGVROXmg9MfDwL0H2ZIOg++m7qPQF8UKesvbqwo69g7qOc 5ucCKim/gm4pibl9ipOJPV0QhUxNel6r+/Cs9Q7Wl3OZR2nmL3a8Gipt6m8E8PG2yXDSGzPuP41sf ImmzES/ggI22E58KhhshZ8O5N1KXr7CIQ4il6mds6XAC4Qdy5KphYOuOkS2WTRFq7JOBr1dbEDgGX OBoV+Uj34Ppt/zuDT4syIazd4MlwigOnJFyQkopb4Vro3XQS+g39OClDFyBg8rVlhmhieK0HqlRvm +S6MsHE96W3+F3x3kfbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPwgq-009lMq-2Z; Sun, 30 Jul 2023 03:01:52 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPwgm-009lLD-1f for linux-arm-kernel@lists.infradead.org; Sun, 30 Jul 2023 03:01:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ECE5F60765; Sun, 30 Jul 2023 03:01:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1431C433C8; Sun, 30 Jul 2023 03:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690686097; bh=y7zjaCepfGyihTSLnmL3Mq/+VnrmlfJ9HetaB/1wc7M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jG5bpSBNCPLIgGdMWSxGiLs9Ljnse0247UXOqDnZGYCHLBRKlVmoZ/tRAegRaj+Ha 1glSnLOij0P61SBlkGS1RstMtxUFquLiQdJijqyXtjneGbQpBdhye1lv4K7un7O2Lq cMJykJowSpTfbNmsVv5FObn1RdU9fhDHOQgVxEKROjtIame73urzDIIENsJi4xgZqK t3OhMiY+/2fZVT3l+t9bzgdhzsegYZS5F0vxCouc34phie8zxPpY4o7t780kv7cVLJ YK6TgOzdHpaSkFG1zH3bLMff3QpzTzwu9mWLtLuEmr7hQVUvhsd9L8piqaCKku11NR lPuRtWYQ2fpkw== Date: Sun, 30 Jul 2023 11:01:23 +0800 From: Shawn Guo To: Josua Mayer Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Li Yang Subject: Re: [PATCH v3 4/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board Message-ID: <20230730030123.GS151430@dragon> References: <20230619090026.22713-1-josua@solid-run.com> <20230619090026.22713-5-josua@solid-run.com> <20230718024607.GY9559@dragon> <1ab424ee-21a8-9ca4-e792-3222e68e1098@solid-run.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1ab424ee-21a8-9ca4-e792-3222e68e1098@solid-run.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230729_200148_623665_3BEF66D1 X-CRM114-Status: GOOD ( 25.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 23, 2023 at 12:37:38PM +0200, Josua Mayer wrote: > Hi Shawn, > > Thank you for reviewing. > > Note I have added a general question inline below. > > Am 18.07.23 um 04:46 schrieb Shawn Guo: > > On Mon, Jun 19, 2023 at 12:00:26PM +0300, Josua Mayer wrote: > > > Add support for the SolidRun LX2162A System on Module (SoM), and the > > > Clearfog evaluation board. > > > > +&dpmac11 { > > > + status = "okay"; > > We generally end property list with 'status'. > Okay, I will change the order for v4. > > > > Shawn > > > > > + phys = <&serdes_2 0>; > > > + phy-handle = <ðernet_phy2>; > > > + phy-connection-type = "sgmii"; > > > +}; > > > + > > > +&emdio1 { > > > + /* > > > + * SoM has a phy at address 1 connected to SoC Ethernet Controller 1. > > > + * It competes for WRIOP MAC17, and no connector has been wired. > > > + */ > > > + /delete-node/ ethernet-phy@1; > Perhaps somebody can help here on what is best practice: > As outlined in the comment the SoM includes an ethernet phy at address 1, > which is not used at all by the Clearfog carrier. > > What is the best practice for unused but available components? If you are saying the connector is not wired on Clearfog, it might make more sense to give it a disabled status in clearfog dts, IMO. Shawn > > The phy can still communicate on mdio - just it will never receive rgmii > signals from ether cpu or carrier. > I am leaning towards just keeping it with status okay, if only for the > prospect that a smart driver might put it in a power-saving mode. > > > > + > > > + ethernet_phy0: ethernet-phy@8 { > > > + compatible = "ethernet-phy-ieee802.3-c45"; > > > + reg = <8>; > > > + max-speed = <1000>; > > > + }; > > > + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel