linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: imx6q-cm-fx6: Remove invalid SPI flash entry
@ 2023-07-31 13:34 Fabio Estevam
  2023-07-31 13:34 ` [PATCH 2/3] ARM: dts: imx50-evk: Use generic node name for SPI NOR flash Fabio Estevam
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-07-31 13:34 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
	linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

"st,m25p" is not a valid compatible according to jedec,spi-nor.yaml.

Remove it.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx6q-cm-fx6.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-cm-fx6.dts b/arch/arm/boot/dts/nxp/imx/imx6q-cm-fx6.dts
index ffb3b8eeae5d..95b49fc83f7b 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-cm-fx6.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-cm-fx6.dts
@@ -263,7 +263,7 @@ &ecspi1 {
 	flash@0 {
 		#address-cells = <1>;
 		#size-cells = <1>;
-		compatible = "st,m25p", "jedec,spi-nor";
+		compatible = "jedec,spi-nor";
 		spi-max-frequency = <20000000>;
 		reg = <0>;
 	};
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] ARM: dts: imx50-evk: Use generic node name for SPI NOR flash
  2023-07-31 13:34 [PATCH 1/3] ARM: dts: imx6q-cm-fx6: Remove invalid SPI flash entry Fabio Estevam
@ 2023-07-31 13:34 ` Fabio Estevam
  2023-07-31 13:34 ` [PATCH 3/3] ARM: dts: imx53-smd: Remove invalid SPI flash entry Fabio Estevam
  2023-08-06 12:23 ` [PATCH 1/3] ARM: dts: imx6q-cm-fx6: " Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-07-31 13:34 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
	linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Node names should be generic, so use 'flash' as the SPI NOR flash node
name.

This fixes the following schema warning:

imx53-smd.dtb: m25p32@1: $nodename:0: 'm25p32@1' does not match '^(flash|.*sram|nand)(@.*)?$'
	from schema $id: http://devicetree.org/schemas/mtd/jedec,spi-nor.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx50-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx50-evk.dts b/arch/arm/boot/dts/nxp/imx/imx50-evk.dts
index 4ea5c23f181b..3f45c01d9cce 100644
--- a/arch/arm/boot/dts/nxp/imx/imx50-evk.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx50-evk.dts
@@ -23,7 +23,7 @@ &cspi {
 	cs-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>, <&gpio4 13 GPIO_ACTIVE_LOW>;
 	status = "okay";
 
-	flash: m25p32@1 {
+	flash: flash@1 {
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "m25p32", "jedec,spi-nor";
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] ARM: dts: imx53-smd: Remove invalid SPI flash entry
  2023-07-31 13:34 [PATCH 1/3] ARM: dts: imx6q-cm-fx6: Remove invalid SPI flash entry Fabio Estevam
  2023-07-31 13:34 ` [PATCH 2/3] ARM: dts: imx50-evk: Use generic node name for SPI NOR flash Fabio Estevam
@ 2023-07-31 13:34 ` Fabio Estevam
  2023-08-06 12:23 ` [PATCH 1/3] ARM: dts: imx6q-cm-fx6: " Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-07-31 13:34 UTC (permalink / raw)
  To: shawnguo
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
	linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

"st,m25p" is not a valid compatible according to jedec,spi-nor.yaml.

Remove it.

Also, node names should be generic, so use 'flash' as the SPI NOR flash
node name.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx53-smd.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx53-smd.dts b/arch/arm/boot/dts/nxp/imx/imx53-smd.dts
index f8d17967a67e..55435dfdff8a 100644
--- a/arch/arm/boot/dts/nxp/imx/imx53-smd.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx53-smd.dts
@@ -67,10 +67,10 @@ zigbee: mc1323@0 {
 		reg = <0>;
 	};
 
-	flash: m25p32@1 {
+	flash: flash@1 {
 		#address-cells = <1>;
 		#size-cells = <1>;
-		compatible = "st,m25p32", "st,m25p", "jedec,spi-nor";
+		compatible = "st,m25p32", "jedec,spi-nor";
 		spi-max-frequency = <20000000>;
 		reg = <1>;
 
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] ARM: dts: imx6q-cm-fx6: Remove invalid SPI flash entry
  2023-07-31 13:34 [PATCH 1/3] ARM: dts: imx6q-cm-fx6: Remove invalid SPI flash entry Fabio Estevam
  2023-07-31 13:34 ` [PATCH 2/3] ARM: dts: imx50-evk: Use generic node name for SPI NOR flash Fabio Estevam
  2023-07-31 13:34 ` [PATCH 3/3] ARM: dts: imx53-smd: Remove invalid SPI flash entry Fabio Estevam
@ 2023-08-06 12:23 ` Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2023-08-06 12:23 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
	linux-arm-kernel, Fabio Estevam

On Mon, Jul 31, 2023 at 10:34:19AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> "st,m25p" is not a valid compatible according to jedec,spi-nor.yaml.
> 
> Remove it.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied all, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-08-06 12:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-31 13:34 [PATCH 1/3] ARM: dts: imx6q-cm-fx6: Remove invalid SPI flash entry Fabio Estevam
2023-07-31 13:34 ` [PATCH 2/3] ARM: dts: imx50-evk: Use generic node name for SPI NOR flash Fabio Estevam
2023-07-31 13:34 ` [PATCH 3/3] ARM: dts: imx53-smd: Remove invalid SPI flash entry Fabio Estevam
2023-08-06 12:23 ` [PATCH 1/3] ARM: dts: imx6q-cm-fx6: " Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).