From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88089C001DE for ; Mon, 31 Jul 2023 14:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0u15wh6/elmSTP/qjFg5yXETZgukv5L+uUsHdGITN9Q=; b=R8W+Q4d9KQK1wE Sdmb7UQItfv/Sep+NIOL7xz0opnR1AzPDRvhbKe+rvoazb2N8cImm96zZUBxQVwpbnDMsZkERIa9X y+c62i+HyG0HOQ6gZG5WVK7ZeNNXGTHOJoD+3D2fV6z1+h6e9Tg9+keAQjCF4GHKvT9tKKhsN2kP6 iHkhYAWXiwtd9qYISKyACT/wLRgeTdijtNHhTNXMS6L554af6Z/FohAqOSH6IrnmG+YZ2t+gccDRO PW7+xm8A+2cfBAf80hU1jxkXsGEzTJNygKOkjRHMEZ2U78x+torALW9eF5XE6v6hSrm7pGSkB0Xfx H83r6BsKXe/HP/mYvjmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQU39-00G9Sx-2m; Mon, 31 Jul 2023 14:39:07 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQU37-00G9SP-0C; Mon, 31 Jul 2023 14:39:06 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F031610A3; Mon, 31 Jul 2023 14:39:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79B60C433C7; Mon, 31 Jul 2023 14:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690814342; bh=I+HTilLE0eCgqcOxm8A9AzbA88OpHR1hterp6c6XU+w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pg+zp2UxyorlYipjOt2QuL2ulmdPZOv6nqgX8rI7HeFvug9s4uUjTa7fk79yJpEJZ kHJIg6Z09MuBmxvZJMz0zBvsfY9SuES52uCVOp98BgNUkZPsAx2MMUEjZugT4Oggog NBGUpxONXSFmhKzNBPavt7eavVNB8kxNt3n0vvryKgwCsd4BwOQsHWUxNWajJc3oH8 sZ+ZaPbj4JyaWZAwz6LO1jDGvPA7EMmXVj40RP77w9SdUECS+f+Gc2hB2WZDcmX/8l GrsKzmxO061FUgIS6HjTQ7bAT5+QxQEU5qmOPbePzUCVf5uv7ldYatz7zF8mfbHnLK /z0h20ZI/tWjg== Received: (nullmailer pid 2931468 invoked by uid 1000); Mon, 31 Jul 2023 14:38:59 -0000 Date: Mon, 31 Jul 2023 08:38:59 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Judy Hsiao , Sylwester Nawrocki , Conor Dooley , Takashi Iwai , linux-mediatek@lists.infradead.org, Fabio Estevam , alsa-devel@alsa-project.org, NXP Linux Team , Rao Mandadapu , Trevor Wu , Jonathan Bakker , Jerome Brunet , linux-arm-kernel@lists.infradead.org, Matthias Brugger , Cheng-Yi Chiang , Pengutronix Kernel Team , devicetree@vger.kernel.org, Rohit kumar , AngeloGioacchino Del Regno , Shengjiu Wang , Shawn Guo , Jaroslav Kysela , Mark Brown , Krzysztof Kozlowski , Liam Girdwood , Sascha Hauer , linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/12] ASoC: dt-bindings: mediatek,mt8188-mt6359: use common sound card Message-ID: <20230731143859.GA2928327-robh@kernel.org> References: <20230731094303.185067-1-krzysztof.kozlowski@linaro.org> <20230731094303.185067-4-krzysztof.kozlowski@linaro.org> <169080070077.2404962.11506468692056687115.robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <169080070077.2404962.11506468692056687115.robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230731_073905_209993_BA8881A7 X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 31, 2023 at 04:51:46AM -0600, Rob Herring wrote: > > On Mon, 31 Jul 2023 11:42:54 +0200, Krzysztof Kozlowski wrote: > > The mediatek,mt8188-mt6359 Linux sound machine driver requires the > > "model" property, so binding was incomplete. Reference the common sound > > card properties to fix that which also allows to remove duplicated > > property definitions. Leave the relevant parts of "audio-routing" > > description. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../bindings/sound/mediatek,mt8188-mt6359.yaml | 17 +++++++---------- > > 1 file changed, 7 insertions(+), 10 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml: > Error in referenced schema matching $id: http://devicetree.org/schemas/sound/sound-card-common.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.example.dtb: sound: False schema does not allow {'compatible': ['mediatek,mt8188-mt6359-evb'], 'model': ['MT6359-EVB'], 'mediatek,platform': [[4294967295]], 'pinctrl-names': ['default'], 'pinctrl-0': [[4294967295]], 'audio-routing': ['Headphone', 'Headphone L', 'Headphone', 'Headphone R', 'AIN1', 'Headset Mic'], 'dai-link-0': {'link-name': ['ETDM3_OUT_BE'], 'dai-format': ['i2s'], 'mediatek,clk-provider': ['cpu'], 'codec': {'sound-dai': [[4294967295]]}}, '$nodename': ['sound']} > from schema $id: http://devicetree.org/schemas/sound/mediatek,mt8188-mt6359.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.example.dtb: sound: Unevaluated properties are not allowed ('model' was unexpected) > from schema $id: http://devicetree.org/schemas/sound/mediatek,mt8188-mt6359.yaml# Looks like patch 2 could not be applied causing this. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel