From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E146FC001DC for ; Mon, 31 Jul 2023 11:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QaVkiRsaqw6fPv64pS0f9D8J1GoY7/gHqd1FQvzJlGQ=; b=mao1ukQ88qKh5d a/C/I9JRCP7k1dWP5hU+iaWT/SuKn2Yd83m/RuXptX+azK6ZZJYjruvUO1HF4QvexFS401Vxb2ROu 4Lo/2U4Vx2Jty7CMzdqzS4dAaxCHhordJRgc03O1pnSRGI2xV48topcy03AmrYxpsw0hn6UhrIboy MOl+QecDJeruEFaD3pxkozDv4qyo5rSd6MiuZIkvy0JDR7ACWvBrGqdDLY2IcXBif/qccrx/ShRiu K05qbCEOabrFEnGchQ2gjpnaEsnKtMXDsWV0XAeJCMUHXrdy8hozTrYDKfmBV97uC/LJKy8IAbZSV JnkE30z67CeB8B5ptwfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQQiT-00FIDq-1n; Mon, 31 Jul 2023 11:05:33 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQQiQ-00FICo-34 for linux-arm-kernel@lists.infradead.org; Mon, 31 Jul 2023 11:05:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 48A2D61014; Mon, 31 Jul 2023 11:05:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24852C433C7; Mon, 31 Jul 2023 11:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690801529; bh=aDQytpIehxdC9Y92aOCsKJiiWVzUj/QKa0p5med/PCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r6NCuUd2dWAFRltw2+pGmuDVTotQpjH0ekKpzZTX6xFqUgNw1T9VfYT3y9t9W5+Zi a90PJEXjCJlyzYqhxvr/DW6eMaqAi8zS6wVgLCL/aR8FuEgbQLT1Uwoy4WRgpwA9Qx +/vFsSMs5e4xpn7tonapNyoZMS+bpeH9TBXzd6Xo= Date: Mon, 31 Jul 2023 13:05:26 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Luis Chamberlain , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ulf Hansson , Yangbo Lu , Joshua Kinard , Daniel Vetter , linux-arm-kernel@lists.infradead.org, open list , linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH 5/5] modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules Message-ID: <2023073135-destiny-washbowl-2689@gregkh> References: <20230731083806.453036-1-hch@lst.de> <20230731083806.453036-6-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230731083806.453036-6-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230731_040531_067050_0C04E0EA X-CRM114-Status: GOOD ( 14.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 31, 2023 at 10:38:06AM +0200, Christoph Hellwig wrote: > It has recently come to my attention that nvidia is circumventing the > protection added in 262e6ae7081d ("modules: inherit > TAINT_PROPRIETARY_MODULE") by importing exports from their propriertary > modules into an allegedly GPL licensed module and then rexporting them. > > Given that symbol_get was only ever inteded for tightly cooperating > modules using very internal symbols it is logical to restrict it to > being used on EXPORY_SYMBOL_GPL and prevent nvidia from costly DMCA "EXPORT" :) > circumvention of access controls law suites. > > All symbols except for four used through symbol_get were already exported > as EXPORT_SYMBOL_GPL, and the remaining four ones were switched over in > the preparation patches. > > Fixes: 262e6ae7081d ("modules: inherit TAINT_PROPRIETARY_MODULE") > Signed-off-by: Christoph Hellwig Thanks for fixing this hole up, it's much needed. Reviewed-by: Greg Kroah-Hartman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel