From: Conor Dooley <conor@kernel.org>
To: Zhu Wang <wangzhu9@huawei.com>
Cc: brgl@bgdev.pl, andi.shyti@kernel.org, conor.dooley@microchip.com,
daire.mcnamara@microchip.com,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH -next] i2c: remove redundant dev_err_probe()
Date: Tue, 1 Aug 2023 14:34:49 +0100 [thread overview]
Message-ID: <20230801-faceplate-craving-e913d24b0b5a@spud> (raw)
In-Reply-To: <20230801124551.138541-1-wangzhu9@huawei.com>
[-- Attachment #1.1: Type: text/plain, Size: 497 bytes --]
On Tue, Aug 01, 2023 at 08:45:51PM +0800, Zhu Wang wrote:
> When platform_get_irq() is called, the error message has been printed,
> so it need not to call dev_err_probe() to print error, and
> platform_get_irq() never returned zero.
Is that strictly true?
> Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
> ---
> drivers/i2c/busses/i2c-davinci.c | 2 +-
> drivers/i2c/busses/i2c-microchip-corei2c.c | 5 ++---
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-08-01 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 12:45 [PATCH -next] i2c: remove redundant dev_err_probe() Zhu Wang
2023-08-01 13:34 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801-faceplate-craving-e913d24b0b5a@spud \
--to=conor@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=wangzhu9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox