From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Vinod Koul <vkoul@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Jose Abreu <joabreu@synopsys.com>,
imx@lists.linux.dev, Simon Horman <simon.horman@corigine.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Fabio Estevam <festevam@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
Jerome Brunet <jbrunet@baylibre.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Wong Vee Khee <veekhee@apple.com>,
NXP Linux Team <linux-imx@nxp.com>,
Andrew Halaney <ahalaney@redhat.com>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Revanth Kumar Uppala <ruppala@nvidia.com>,
Jochen Henneberg <jh@henneberg-systemdesign.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed
Date: Tue, 1 Aug 2023 08:37:21 +0200 [thread overview]
Message-ID: <20230801-portside-prepaid-513f1f39f245-mkl@pengutronix.de> (raw)
In-Reply-To: <20230731161929.2341584-2-shenwei.wang@nxp.com>
[-- Attachment #1.1: Type: text/plain, Size: 895 bytes --]
On 31.07.2023 11:19:28, Shenwei Wang wrote:
> A mode parameter has been added to the callback function of fix_mac_speed
> to indicate the physical layer type.
>
> The mode can be one the following:
> MLO_AN_PHY - Conventional PHY
> MLO_AN_FIXED - Fixed-link mode
> MLO_AN_INBAND - In-band protocol
>
> Also use short version of 'uint' to replace the 'unsigned int' in the
> function definitions.
There are not many users of 'uint' in the kernel and it's not used in
the stmmac driver so far. From my point of view I would not introduce
it and stick to the standard 'unsigned int'.
Just my 2 cent,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-01 6:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 16:19 [PATCH v3 net 0/2] update stmmac fix_mac_speed Shenwei Wang
2023-07-31 16:19 ` [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed Shenwei Wang
2023-08-01 6:37 ` Marc Kleine-Budde [this message]
2023-08-01 18:43 ` [EXT] " Shenwei Wang
2023-08-01 19:58 ` Jakub Kicinski
2023-08-02 19:33 ` Shenwei Wang
2023-07-31 16:19 ` [PATCH v3 net 2/2] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link Shenwei Wang
2023-08-01 9:01 ` Marc Kleine-Budde
2023-08-01 12:47 ` Johannes Zink
2023-08-01 12:56 ` Russell King (Oracle)
2023-08-01 17:06 ` [EXT] " Shenwei Wang
2023-08-01 17:23 ` Andrew Halaney
2023-08-01 17:24 ` Russell King (Oracle)
2023-08-01 17:10 ` Shenwei Wang
2023-08-02 6:25 ` Johannes Zink
2023-08-02 14:27 ` Shenwei Wang
2023-08-02 14:40 ` Johannes Zink
2023-08-02 16:00 ` Shenwei Wang
2023-08-03 6:36 ` Johannes Zink
2023-08-03 13:08 ` Shenwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801-portside-prepaid-513f1f39f245-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhupesh.sharma@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jh@henneberg-systemdesign.com \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=ruppala@nvidia.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=simon.horman@corigine.com \
--cc=veekhee@apple.com \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).