From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C601C001E0 for ; Tue, 1 Aug 2023 08:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L0N0ABDSq0zA0j6kcOzZh/23dAlyG/QKQpjx9CUbfBY=; b=eR29q5GUzAjaWu rYs7fJ+/63AG0jjiFTKhCJeiaZXZpy+5xlXEB1E2Ccxzq8LdPmyKK5bsJ8RQwCk1jTVysnUHOlE9o BNiQ8lGC+LlmSaqox5S8FEDM9+9khdJ/m0+cRxj1Ht0sL+tE2GfnEYfuTi5roYAiO9lPSwsdUxk2F V+SqBruNhoyRoKsR7OsqRQ12vxsubEm6ihkCsZnYIbhk0A58q0sKcvHZiP7RkmxjytrKm4vzdAH1V 8wnGEvZqxvLq8OfAB/nbDMASNpbpJuB+hklfyLoDtqzIiQUQ13NMbCPOok/447I/pcG75ja0pa4CH e1kDVSLwAR3fLW5HbLbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQkJr-000baP-2T; Tue, 01 Aug 2023 08:01:27 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQkJn-000bYb-2g for linux-arm-kernel@lists.infradead.org; Tue, 01 Aug 2023 08:01:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 250BA614A8; Tue, 1 Aug 2023 08:01:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0807CC433C8; Tue, 1 Aug 2023 08:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690876882; bh=6kqSeh2s0QB7HJFRWEDE8TrFNli7QfT0Sf6nWD+OGBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ocSGhdOxgh299LUX3x6cTP6JfL027dGb7y/LAteyR33a/QMjbrP+HYy20vwe0tZI5 P7hfNVKofhN2UApJ5qftcGpXWbOroCmq0R7PkneiBi536ESAgwiTA6qUN8KihmSpaW 809GOzwyhc9Rjo8VHZM3OFIQ35yrghhdMR0fa8rE= Date: Tue, 1 Aug 2023 10:01:20 +0200 From: Greg KH To: Easwar Hariharan Cc: stable@vger.kernel.org, easwar.hariharan@microsoft.com, Robin Murphy , Nicolin Chen , Will Deacon , Catalin Marinas , Jonathan Corbet , Joerg Roedel , Sasha Levin , Yicong Yang , Tomas Krcka , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , "open list:DOCUMENTATION" , open list , "open list:IOMMU DRIVERS" , "open list:IOMMU DRIVERS" Subject: Re: [PATCH 6.4] iommu/arm-smmu-v3: Document MMU-700 erratum 2812531 Message-ID: <2023080102-rake-twisty-746d@gregkh> References: <20230724185130.1676140-1-eahariha@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230724185130.1676140-1-eahariha@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230801_010123_957554_971747E9 X-CRM114-Status: GOOD ( 27.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 24, 2023 at 06:51:28PM +0000, Easwar Hariharan wrote: > From: Robin Murphy > > commit 309a15cb16bb075da1c99d46fb457db6a1a2669e upstream > > To work around MMU-700 erratum 2812531 we need to ensure that certain > sequences of commands cannot be issued without an intervening sync. In > practice this falls out of our current command-batching machinery > anyway - each batch only contains a single type of invalidation command, > and ends with a sync. The only exception is when a batch is sufficiently > large to need issuing across multiple command queue slots, wherein the > earlier slots will not contain a sync and thus may in theory interleave > with another batch being issued in parallel to create an affected > sequence across the slot boundary. > > Since MMU-700 supports range invalidate commands and thus we will prefer > to use them (which also happens to avoid conditions for other errata), > I'm not entirely sure it's even possible for a single high-level > invalidate call to generate a batch of more than 63 commands, but for > the sake of robustness and documentation, wire up an option to enforce > that a sync is always inserted for every slot issued. > > The other aspect is that the relative order of DVM commands cannot be > controlled, so DVM cannot be used. Again that is already the status quo, > but since we have at least defined ARM_SMMU_FEAT_BTM, we can explicitly > disable it for documentation purposes even if it's not wired up anywhere > yet. > > Signed-off-by: Robin Murphy > Reviewed-by: Nicolin Chen > Link: https://lore.kernel.org/r/330221cdfd0003cd51b6c04e7ff3566741ad8374.1683731256.git.robin.murphy@arm.com > Signed-off-by: Will Deacon > Signed-off-by: Easwar Hariharan > --- > Documentation/arm64/silicon-errata.rst | 4 +++ > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 39 +++++++++++++++++++++ > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 1 + > 3 files changed, 44 insertions(+) > > diff --git a/Documentation/arm64/silicon-errata.rst b/Documentation/arm64/silicon-errata.rst > index cd46e2b20a81..b0346968765d 100644 > --- a/Documentation/arm64/silicon-errata.rst > +++ b/Documentation/arm64/silicon-errata.rst > @@ -143,6 +143,10 @@ stable kernels. > +----------------+-----------------+-----------------+-----------------------------+ > | ARM | MMU-500 | #841119,826419 | N/A | > +----------------+-----------------+-----------------+-----------------------------+ > +| ARM | MMU-600 | #1076982 | N/A | > ++----------------+-----------------+-----------------+-----------------------------+ > +| ARM | MMU-700 | #2812531 | N/A | > ++----------------+-----------------+-----------------+-----------------------------+ But you didn't backport the MMU-600 change here, so why does the diff here show you did? And what about commit 0bfbfc526c70 ("iommu/arm-smmu-v3: Document nesting-related errata") after this? Can you send a properly backported series for this and the needed fixes after this, for all relevant kernels you wish to have the errata applied to? This single backport isn't enough, sorry. I've dropped all the patches you submitted for stable backports now. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel