* [PATCH -next] mtd: nand: Use devm_platform_ioremap_resource_byname()
@ 2023-08-01 13:46 Li Zetao
2023-08-01 15:43 ` Miquel Raynal
2023-08-02 1:35 ` [PATCH -next v2] mtd: rawnand: brcmnand: " Li Zetao
0 siblings, 2 replies; 5+ messages in thread
From: Li Zetao @ 2023-08-01 13:46 UTC (permalink / raw)
To: computersforpeace, kamal.dasu, bcm-kernel-feedback-list,
miquel.raynal, richard, vigneshr, william.zhang, anand.gore,
kursad.oney, florian.fainelli, rafal, rjui, sbranden
Cc: lizetao1, linux-mtd, linux-arm-kernel
Convert platform_get_resource_byname() + devm_ioremap_resource() to a
single call to devm_platform_ioremap_resource_byname(), as this is
exactly what this function does.
Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c | 4 +---
drivers/mtd/nand/raw/brcmnand/iproc_nand.c | 7 ++-----
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c b/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c
index 71ddcc611f6e..9596629000f4 100644
--- a/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c
+++ b/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c
@@ -61,15 +61,13 @@ static int bcm63138_nand_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct bcm63138_nand_soc *priv;
struct brcmnand_soc *soc;
- struct resource *res;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
soc = &priv->soc;
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "nand-int-base");
- priv->base = devm_ioremap_resource(dev, res);
+ priv->base = devm_platform_ioremap_resource_byname(pdev, "nand-int-base");
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
diff --git a/drivers/mtd/nand/raw/brcmnand/iproc_nand.c b/drivers/mtd/nand/raw/brcmnand/iproc_nand.c
index d32950847a62..089c70fc6edf 100644
--- a/drivers/mtd/nand/raw/brcmnand/iproc_nand.c
+++ b/drivers/mtd/nand/raw/brcmnand/iproc_nand.c
@@ -103,7 +103,6 @@ static int iproc_nand_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct iproc_nand_soc *priv;
struct brcmnand_soc *soc;
- struct resource *res;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
@@ -112,13 +111,11 @@ static int iproc_nand_probe(struct platform_device *pdev)
spin_lock_init(&priv->idm_lock);
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "iproc-idm");
- priv->idm_base = devm_ioremap_resource(dev, res);
+ priv->idm_base = devm_platform_ioremap_resource_byname(pdev, "iproc-idm");
if (IS_ERR(priv->idm_base))
return PTR_ERR(priv->idm_base);
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "iproc-ext");
- priv->ext_base = devm_ioremap_resource(dev, res);
+ priv->ext_base = devm_platform_ioremap_resource_byname(pdev, "iproc-ext");
if (IS_ERR(priv->ext_base))
return PTR_ERR(priv->ext_base);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] mtd: nand: Use devm_platform_ioremap_resource_byname()
2023-08-01 13:46 [PATCH -next] mtd: nand: Use devm_platform_ioremap_resource_byname() Li Zetao
@ 2023-08-01 15:43 ` Miquel Raynal
2023-08-02 1:35 ` [PATCH -next v2] mtd: rawnand: brcmnand: " Li Zetao
1 sibling, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2023-08-01 15:43 UTC (permalink / raw)
To: Li Zetao
Cc: computersforpeace, kamal.dasu, bcm-kernel-feedback-list, richard,
vigneshr, william.zhang, anand.gore, kursad.oney,
florian.fainelli, rafal, rjui, sbranden, linux-mtd,
linux-arm-kernel
Hi Li,
lizetao1@huawei.com wrote on Tue, 1 Aug 2023 21:46:19 +0800:
> Convert platform_get_resource_byname() + devm_ioremap_resource() to a
> single call to devm_platform_ioremap_resource_byname(), as this is
> exactly what this function does.
Please use "mtd: rawnand: brcmnand:" for the prefix.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
> ---
> drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c | 4 +---
> drivers/mtd/nand/raw/brcmnand/iproc_nand.c | 7 ++-----
> 2 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c b/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c
> index 71ddcc611f6e..9596629000f4 100644
> --- a/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c
> @@ -61,15 +61,13 @@ static int bcm63138_nand_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct bcm63138_nand_soc *priv;
> struct brcmnand_soc *soc;
> - struct resource *res;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> if (!priv)
> return -ENOMEM;
> soc = &priv->soc;
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "nand-int-base");
> - priv->base = devm_ioremap_resource(dev, res);
> + priv->base = devm_platform_ioremap_resource_byname(pdev, "nand-int-base");
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> diff --git a/drivers/mtd/nand/raw/brcmnand/iproc_nand.c b/drivers/mtd/nand/raw/brcmnand/iproc_nand.c
> index d32950847a62..089c70fc6edf 100644
> --- a/drivers/mtd/nand/raw/brcmnand/iproc_nand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/iproc_nand.c
> @@ -103,7 +103,6 @@ static int iproc_nand_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct iproc_nand_soc *priv;
> struct brcmnand_soc *soc;
> - struct resource *res;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> if (!priv)
> @@ -112,13 +111,11 @@ static int iproc_nand_probe(struct platform_device *pdev)
>
> spin_lock_init(&priv->idm_lock);
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "iproc-idm");
> - priv->idm_base = devm_ioremap_resource(dev, res);
> + priv->idm_base = devm_platform_ioremap_resource_byname(pdev, "iproc-idm");
> if (IS_ERR(priv->idm_base))
> return PTR_ERR(priv->idm_base);
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "iproc-ext");
> - priv->ext_base = devm_ioremap_resource(dev, res);
> + priv->ext_base = devm_platform_ioremap_resource_byname(pdev, "iproc-ext");
> if (IS_ERR(priv->ext_base))
> return PTR_ERR(priv->ext_base);
>
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH -next v2] mtd: rawnand: brcmnand: Use devm_platform_ioremap_resource_byname()
2023-08-01 13:46 [PATCH -next] mtd: nand: Use devm_platform_ioremap_resource_byname() Li Zetao
2023-08-01 15:43 ` Miquel Raynal
@ 2023-08-02 1:35 ` Li Zetao
2023-08-02 17:03 ` Florian Fainelli
2023-08-04 7:03 ` Miquel Raynal
1 sibling, 2 replies; 5+ messages in thread
From: Li Zetao @ 2023-08-02 1:35 UTC (permalink / raw)
To: lizetao1
Cc: anand.gore, bcm-kernel-feedback-list, computersforpeace,
florian.fainelli, kamal.dasu, kursad.oney, linux-arm-kernel,
linux-mtd, miquel.raynal, rafal, richard, rjui, sbranden,
vigneshr, william.zhang
Convert platform_get_resource_byname() + devm_ioremap_resource() to a
single call to devm_platform_ioremap_resource_byname(), as this is
exactly what this function does.
Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
v1 -> v2: modify the subject prefix to "mtd: rawnand: brcmnand:"
v1: https://lore.kernel.org/all/20230801134619.416618-1-lizetao1@huawei.com/
drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c | 4 +---
drivers/mtd/nand/raw/brcmnand/iproc_nand.c | 7 ++-----
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c b/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c
index 71ddcc611f6e..9596629000f4 100644
--- a/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c
+++ b/drivers/mtd/nand/raw/brcmnand/bcm63138_nand.c
@@ -61,15 +61,13 @@ static int bcm63138_nand_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct bcm63138_nand_soc *priv;
struct brcmnand_soc *soc;
- struct resource *res;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
soc = &priv->soc;
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "nand-int-base");
- priv->base = devm_ioremap_resource(dev, res);
+ priv->base = devm_platform_ioremap_resource_byname(pdev, "nand-int-base");
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
diff --git a/drivers/mtd/nand/raw/brcmnand/iproc_nand.c b/drivers/mtd/nand/raw/brcmnand/iproc_nand.c
index d32950847a62..089c70fc6edf 100644
--- a/drivers/mtd/nand/raw/brcmnand/iproc_nand.c
+++ b/drivers/mtd/nand/raw/brcmnand/iproc_nand.c
@@ -103,7 +103,6 @@ static int iproc_nand_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct iproc_nand_soc *priv;
struct brcmnand_soc *soc;
- struct resource *res;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
@@ -112,13 +111,11 @@ static int iproc_nand_probe(struct platform_device *pdev)
spin_lock_init(&priv->idm_lock);
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "iproc-idm");
- priv->idm_base = devm_ioremap_resource(dev, res);
+ priv->idm_base = devm_platform_ioremap_resource_byname(pdev, "iproc-idm");
if (IS_ERR(priv->idm_base))
return PTR_ERR(priv->idm_base);
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "iproc-ext");
- priv->ext_base = devm_ioremap_resource(dev, res);
+ priv->ext_base = devm_platform_ioremap_resource_byname(pdev, "iproc-ext");
if (IS_ERR(priv->ext_base))
return PTR_ERR(priv->ext_base);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next v2] mtd: rawnand: brcmnand: Use devm_platform_ioremap_resource_byname()
2023-08-02 1:35 ` [PATCH -next v2] mtd: rawnand: brcmnand: " Li Zetao
@ 2023-08-02 17:03 ` Florian Fainelli
2023-08-04 7:03 ` Miquel Raynal
1 sibling, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2023-08-02 17:03 UTC (permalink / raw)
To: Li Zetao
Cc: anand.gore, bcm-kernel-feedback-list, computersforpeace,
kamal.dasu, kursad.oney, linux-arm-kernel, linux-mtd,
miquel.raynal, rafal, richard, rjui, sbranden, vigneshr,
william.zhang
[-- Attachment #1.1: Type: text/plain, Size: 336 bytes --]
On 8/1/23 18:35, Li Zetao wrote:
> Convert platform_get_resource_byname() + devm_ioremap_resource() to a
> single call to devm_platform_ioremap_resource_byname(), as this is
> exactly what this function does.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next v2] mtd: rawnand: brcmnand: Use devm_platform_ioremap_resource_byname()
2023-08-02 1:35 ` [PATCH -next v2] mtd: rawnand: brcmnand: " Li Zetao
2023-08-02 17:03 ` Florian Fainelli
@ 2023-08-04 7:03 ` Miquel Raynal
1 sibling, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2023-08-04 7:03 UTC (permalink / raw)
To: Li Zetao
Cc: Miquel Raynal, anand.gore, bcm-kernel-feedback-list,
computersforpeace, florian.fainelli, kamal.dasu, kursad.oney,
linux-arm-kernel, linux-mtd, rafal, richard, rjui, sbranden,
vigneshr, william.zhang
On Wed, 2023-08-02 at 01:35:00 UTC, Li Zetao wrote:
> Convert platform_get_resource_byname() + devm_ioremap_resource() to a
> single call to devm_platform_ioremap_resource_byname(), as this is
> exactly what this function does.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-04 7:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-01 13:46 [PATCH -next] mtd: nand: Use devm_platform_ioremap_resource_byname() Li Zetao
2023-08-01 15:43 ` Miquel Raynal
2023-08-02 1:35 ` [PATCH -next v2] mtd: rawnand: brcmnand: " Li Zetao
2023-08-02 17:03 ` Florian Fainelli
2023-08-04 7:03 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).