From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EBE7C04A6A for ; Wed, 2 Aug 2023 03:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C1Xs9fA3YGaI8A4izjC7oJDZreGh+qzO8D6X44acHKg=; b=07YaksAaIsrmzJ DEk/k8R9QwCagCfJgkEq9P7TRd+nP8wCtFChdP2bSHhNMqlE/BMa7iz+OOg1vKUIW/Q0kr4PqkCN2 s15q538rLazL7aDeyUVzW8Q8eEpPpCVdoDQiNj9dM+K8uIMLQG3414yTP16hPvO1cTlBfH3SCNq9e Rl6RthGEKrGMMBO7DlHx0J4TMO6Xho5RsrLeRQ82Jmso8GhlEbdJ5eVOTH+ltF4hGxMLYFZT1H8M6 AL4N3MTiaR6TDJD8PbT6aOPM4pKcSoydNffhdkmEHwq4MNQwdFzNOPk+dgZEFkry1NICqzX5O5FZD fsODNZSmZpVCwCUKrsOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qR2k9-003tNG-2y; Wed, 02 Aug 2023 03:41:49 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qR2k6-003tMY-0p for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 03:41:47 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3723fWjP085292; Tue, 1 Aug 2023 22:41:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1690947692; bh=9UgweaCuZWYVCgmgViLTwRNEVAIxTMWqGNWmFfAnE/Y=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=EZ6SUjl06iSLYt8s3QtmMp2slVad8c/3LVgPXBluINySlf+nxG6YchM17owH/BKkw oP4Pm51mNe/EEQk5h+SvnBuVAWkkyY2Y82guJDhFcuYbIW0BPy2uu0DPfKirJBvf5P dKMexQkb6u3YH8cKWmxJmazkJPtKR72JV8w1B04s= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3723fWkD127251 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 1 Aug 2023 22:41:32 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 1 Aug 2023 22:41:31 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 1 Aug 2023 22:41:31 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3723fViw095150; Tue, 1 Aug 2023 22:41:31 -0500 Date: Tue, 1 Aug 2023 22:41:31 -0500 From: Nishanth Menon To: Francesco Dolcini CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Judith Mendez , , , , Francesco Dolcini Subject: Re: [PATCH v1 1/2] arm64: dts: ti: k3-am62: Add MCU MCAN nodes Message-ID: <20230802034131.ja53ksr24rhcks3c@justifier> References: <20230724133612.37366-1-francesco@dolcini.it> <20230724133612.37366-2-francesco@dolcini.it> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230724133612.37366-2-francesco@dolcini.it> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230801_204146_481211_DB51D9A0 X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15:36-20230724, Francesco Dolcini wrote: > From: Judith Mendez > > On AM62x there are no hardware interrupts routed to A53 GIC > interrupt controller for MCU MCAN IPs, so MCU MCAN nodes were > omitted from MCU dtsi. > > Timer polling was introduced in commits [1][2] so now add MCU MCAN nodes > to the MCU dtsi for the Cortex A53. > > [1] b382380c0d2d ("can: m_can: Add hrtimer to generate software interrupt") > [2] bb410c03b999 ("dt-bindings: net: can: Remove interrupt properties for MCAN") Check patch complains: +[2] bb410c03b999 ("dt-bindings: net: can: Remove interrupt properties for MCAN") +ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit bb410c03b999 ("dt-bindings: net: can: Remove interrupt properties for MCAN")' Either use commit sha ("title") or just drop the para. > > Signed-off-by: Judith Mendez <jm@ti.com> > [fd: fixed labels to match datasheet numbering, revised commit message, > fixed reg/reg-names order] > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi > index 19fc38157d94..fed50666d95b 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi > @@ -147,4 +147,28 @@ mcu_rti0: watchdog@4880000 { > /* Tightly coupled to M4F */ > status = "reserved"; > }; > + > + mcu_mcan0: can@4e00000 { /bus@f0000/bus@4000000/can@4e00000: simple-bus unit address format error, expected "4e08000" can@4e08000 > + compatible = "bosch,m_can"; > + reg = <0x00 0x4e08000 0x00 0x200>, > + <0x00 0x4e00000 0x00 0x8000>; > + reg-names = "m_can", "message_ram"; > + power-domains = <&k3_pds 188 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&k3_clks 188 6>, <&k3_clks 188 1>; > + clock-names = "hclk", "cclk"; > + bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>; > + status = "disabled"; > + }; > + > + mcu_mcan1: can@4e10000 { same: can@4e18000 > + compatible = "bosch,m_can"; > + reg = <0x00 0x4e18000 0x00 0x200>, > + <0x00 0x4e10000 0x00 0x8000>; > + reg-names = "m_can", "message_ram"; > + power-domains = <&k3_pds 189 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&k3_clks 189 6>, <&k3_clks 189 1>; > + clock-names = "hclk", "cclk"; > + bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>; > + status = "disabled"; > + }; > }; > -- > 2.25.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel