[PATCH v1 0/4] arm64: dts: ti: Enable Audio on Verdin AM62

[PATCH v1 0/4] arm64: dts: ti: Enable Audio on Verdin AM62

[Francesco Dolcini]

From: Francesco Dolcini <francesco.dolcini@toradex.com>

Add AM62x AUDIO_REFCLKx to AM62x SoC dtsi, and after doing it, enable audio
support for Toradex Verdin AM62.

DT bindings updates, related to the audio codec used here, are already merged
in next [2][3].

For correct functionality this fix [1] is also required.

[1] https://lore.kernel.org/all/20230728222639.110409-1-francesco@dolcini.it/
[2] https://lore.kernel.org/all/20230719124752.248898-1-francesco@dolcini.it/
[3] https://lore.kernel.org/all/20230719121918.247397-1-francesco@dolcini.it/

Francesco Dolcini (3):
  arm64: dts: ti: verdin-am62: Set I2S_1 MCLK rate
  arm64: dts: ti: verdin-am62: dev: add sound card
  arm64: dts: ti: verdin-am62: dahlia: add sound card

Jai Luthra (1):
  arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx

 arch/arm64/boot/dts/ti/k3-am62-main.dtsi      | 18 +++++++
 .../boot/dts/ti/k3-am62-verdin-dahlia.dtsi    | 53 +++++++++++++++++++
 .../arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi | 45 ++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi    |  5 ++
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi     | 18 +++++++
 5 files changed, 139 insertions(+)

-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx

[Francesco Dolcini]

From: Jai Luthra <j-luthra@ti.com>

On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to
external peripherals when configured through CTRL_MMR, so add the
clock nodes.

Signed-off-by: Jai Luthra <j-luthra@ti.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi  | 18 ++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++
 2 files changed, 36 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index 33b6aadc9083..3a1b387bbf49 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -60,6 +60,24 @@ epwm_tbclk: clock@4130 {
 			reg = <0x4130 0x4>;
 			#clock-cells = <1>;
 		};
+
+		audio_refclk0: clock@82e0 {
+			compatible = "ti,am62-audio-refclk";
+			reg = <0x82e0 0x4>;
+			clocks = <&k3_clks 157 0>;
+			assigned-clocks = <&k3_clks 157 0>;
+			assigned-clock-parents = <&k3_clks 157 8>;
+			#clock-cells = <0>;
+		};
+
+		audio_refclk1: clock@82e4 {
+			compatible = "ti,am62-audio-refclk";
+			reg = <0x82e4 0x4>;
+			clocks = <&k3_clks 157 10>;
+			assigned-clocks = <&k3_clks 157 10>;
+			assigned-clock-parents = <&k3_clks 157 18>;
+			#clock-cells = <0>;
+		};
 	};
 
 	dmss: bus@48000000 {
diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index 8397cb80f559..30b163a9b248 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -60,6 +60,24 @@ epwm_tbclk: clock-controller@4130 {
 			reg = <0x4130 0x4>;
 			#clock-cells = <1>;
 		};
+
+		audio_refclk0: clock@82e0 {
+			compatible = "ti,am62-audio-refclk";
+			reg = <0x82e0 0x4>;
+			clocks = <&k3_clks 157 0>;
+			assigned-clocks = <&k3_clks 157 0>;
+			assigned-clock-parents = <&k3_clks 157 8>;
+			#clock-cells = <0>;
+		};
+
+		audio_refclk1: clock@82e4 {
+			compatible = "ti,am62-audio-refclk";
+			reg = <0x82e4 0x4>;
+			clocks = <&k3_clks 157 10>;
+			assigned-clocks = <&k3_clks 157 10>;
+			assigned-clock-parents = <&k3_clks 157 18>;
+			#clock-cells = <0>;
+		};
 	};
 
 	dmss: bus@48000000 {
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v1 2/4] arm64: dts: ti: verdin-am62: Set I2S_1 MCLK rate

[Francesco Dolcini]

From: Francesco Dolcini <francesco.dolcini@toradex.com>

Set AUDIO_EXT_REFCLK1, used as I2S_1_MCLK on Verdin AM62 family, to 25MHz
(this is the only valid option according to TI [1]).

[1] https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1188051/am625-audio_ext_refclk1-clock-output---dts-support/4476322#4476322

Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
index 57dd061911ab..b686a1caeec4 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
@@ -758,6 +758,11 @@ AM62X_MCU_IOPAD(0x0028, PIN_OUTPUT,       0) /* (C5) WKUP_UART0_TXD  */ /* SODIM
 	};
 };
 
+/* VERDIN I2S_1_MCLK */
+&audio_refclk1 {
+	assigned-clock-rates = <25000000>;
+};
+
 &cpsw3g {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_rgmii1>;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v1 3/4] arm64: dts: ti: verdin-am62: dev: add sound card

[Francesco Dolcini]

From: Francesco Dolcini <francesco.dolcini@toradex.com>

Add NAU8822 based analog sound card to Development carrier board.

Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 .../arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
index 846caee7dfa4..8f4ca7d3cad5 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
@@ -8,6 +8,42 @@
  * https://www.toradex.com/products/carrier-board/verdin-development-board-kit
  */
 
+/ {
+	sound {
+		compatible = "simple-audio-card";
+		simple-audio-card,bitclock-master = <&codec_dai>;
+		simple-audio-card,format = "i2s";
+		simple-audio-card,frame-master = <&codec_dai>;
+		simple-audio-card,name = "verdin-nau8822";
+		simple-audio-card,routing =
+			"Headphones", "LHP",
+			"Headphones", "RHP",
+			"Speaker", "LSPK",
+			"Speaker", "RSPK",
+			"Line Out", "AUXOUT1",
+			"Line Out", "AUXOUT2",
+			"LAUX", "Line In",
+			"RAUX", "Line In",
+			"LMICP", "Mic In",
+			"RMICP", "Mic In";
+		simple-audio-card,widgets =
+			"Headphones", "Headphones",
+			"Line Out", "Line Out",
+			"Speaker", "Speaker",
+			"Microphone", "Mic In",
+			"Line", "Line In";
+
+		codec_dai: simple-audio-card,codec {
+			clocks = <&audio_refclk1>;
+			sound-dai = <&nau8822_1a>;
+		};
+
+		simple-audio-card,cpu {
+			sound-dai = <&mcasp0>;
+		};
+	};
+};
+
 /* Verdin ETHs */
 &cpsw3g {
 	pinctrl-names = "default";
@@ -65,6 +101,15 @@ &main_gpio0 {
 &main_i2c1 {
 	status = "okay";
 
+	/* Audio Codec */
+	nau8822_1a: audio-codec@1a {
+		compatible = "nuvoton,nau8822";
+		reg = <0x1a>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_i2s1_mclk>;
+		#sound-dai-cells = <0>;
+	};
+
 	/* IO Expander */
 	gpio_expander_21: gpio@21 {
 		compatible = "nxp,pcal6416";
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v1 4/4] arm64: dts: ti: verdin-am62: dahlia: add sound card

[Francesco Dolcini]

From: Francesco Dolcini <francesco.dolcini@toradex.com>

Add WM8904 based analog sound card to Dahlia carrier board.

Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 .../boot/dts/ti/k3-am62-verdin-dahlia.dtsi    | 53 +++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
index 3abd8d1d6761..e59235d6a8e6 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
@@ -8,6 +8,43 @@
  * https://www.toradex.com/products/carrier-board/dahlia-carrier-board-kit
  */
 
+/ {
+	reg_1v8_sw: regulator-1v8-sw {
+		compatible = "regulator-fixed";
+		regulator-max-microvolt = <1800000>;
+		regulator-min-microvolt = <1800000>;
+		regulator-name = "On-carrier +V1.8_SW";
+	};
+
+	sound {
+		compatible = "simple-audio-card";
+		simple-audio-card,bitclock-master = <&codec_dai>;
+		simple-audio-card,format = "i2s";
+		simple-audio-card,frame-master = <&codec_dai>;
+		simple-audio-card,name = "verdin-wm8904";
+		simple-audio-card,routing =
+			"Headphone Jack", "HPOUTL",
+			"Headphone Jack", "HPOUTR",
+			"IN2L", "Line In Jack",
+			"IN2R", "Line In Jack",
+			"Headphone Jack", "MICBIAS",
+			"IN1L", "Headphone Jack";
+		simple-audio-card,widgets =
+			"Microphone", "Headphone Jack",
+			"Headphone", "Headphone Jack",
+			"Line", "Line In Jack";
+
+		codec_dai: simple-audio-card,codec {
+			clocks = <&audio_refclk1>;
+			sound-dai = <&wm8904_1a>;
+		};
+
+		simple-audio-card,cpu {
+			sound-dai = <&mcasp0>;
+		};
+	};
+};
+
 /* Verdin ETHs */
 &cpsw3g {
 	status = "okay";
@@ -46,6 +83,22 @@ &main_gpio0 {
 &main_i2c1 {
 	status = "okay";
 
+	/* Audio Codec */
+	wm8904_1a: audio-codec@1a {
+		compatible = "wlf,wm8904";
+		reg = <0x1a>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_i2s1_mclk>;
+		#sound-dai-cells = <0>;
+		clocks = <&audio_refclk1>;
+		clock-names = "mclk";
+		AVDD-supply = <&reg_1v8_sw>;
+		CPVDD-supply = <&reg_1v8_sw>;
+		DBVDD-supply = <&reg_1v8_sw>;
+		DCVDD-supply = <&reg_1v8_sw>;
+		MICVDD-supply = <&reg_1v8_sw>;
+	};
+
 	/* Current measurement into module VCC */
 	hwmon@40 {
 		compatible = "ti,ina219";
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 2/4] arm64: dts: ti: verdin-am62: Set I2S_1 MCLK rate

[Jai Luthra]

[-- Attachment #1.1: Type: text/plain, Size: 1332 bytes --]

Hi Francesco,

On Jul 31, 2023 at 16:21:33 +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Set AUDIO_EXT_REFCLK1, used as I2S_1_MCLK on Verdin AM62 family, to 25MHz
> (this is the only valid option according to TI [1]).
> 
> [1] https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1188051/am625-audio_ext_refclk1-clock-output---dts-support/4476322#4476322
> 
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Reviewed-by: Jai Luthra <j-luthra@ti.com>

> ---
>  arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> index 57dd061911ab..b686a1caeec4 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> @@ -758,6 +758,11 @@ AM62X_MCU_IOPAD(0x0028, PIN_OUTPUT,       0) /* (C5) WKUP_UART0_TXD  */ /* SODIM
>  	};
>  };
>  
> +/* VERDIN I2S_1_MCLK */
> +&audio_refclk1 {
> +	assigned-clock-rates = <25000000>;
> +};
> +
>  &cpsw3g {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_rgmii1>;
> -- 
> 2.25.1
> 
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 3/4] arm64: dts: ti: verdin-am62: dev: add sound card

[Jai Luthra]

[-- Attachment #1.1: Type: text/plain, Size: 2375 bytes --]

On Jul 31, 2023 at 16:21:34 +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Add NAU8822 based analog sound card to Development carrier board.
> 
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Reviewed-by: Jai Luthra <j-luthra@ti.com>

> ---
>  .../arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
> index 846caee7dfa4..8f4ca7d3cad5 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi
> @@ -8,6 +8,42 @@
>   * https://www.toradex.com/products/carrier-board/verdin-development-board-kit
>   */
>  
> +/ {
> +	sound {
> +		compatible = "simple-audio-card";
> +		simple-audio-card,bitclock-master = <&codec_dai>;
> +		simple-audio-card,format = "i2s";
> +		simple-audio-card,frame-master = <&codec_dai>;
> +		simple-audio-card,name = "verdin-nau8822";
> +		simple-audio-card,routing =
> +			"Headphones", "LHP",
> +			"Headphones", "RHP",
> +			"Speaker", "LSPK",
> +			"Speaker", "RSPK",
> +			"Line Out", "AUXOUT1",
> +			"Line Out", "AUXOUT2",
> +			"LAUX", "Line In",
> +			"RAUX", "Line In",
> +			"LMICP", "Mic In",
> +			"RMICP", "Mic In";
> +		simple-audio-card,widgets =
> +			"Headphones", "Headphones",
> +			"Line Out", "Line Out",
> +			"Speaker", "Speaker",
> +			"Microphone", "Mic In",
> +			"Line", "Line In";
> +
> +		codec_dai: simple-audio-card,codec {
> +			clocks = <&audio_refclk1>;
> +			sound-dai = <&nau8822_1a>;
> +		};
> +
> +		simple-audio-card,cpu {
> +			sound-dai = <&mcasp0>;
> +		};
> +	};
> +};
> +
>  /* Verdin ETHs */
>  &cpsw3g {
>  	pinctrl-names = "default";
> @@ -65,6 +101,15 @@ &main_gpio0 {
>  &main_i2c1 {
>  	status = "okay";
>  
> +	/* Audio Codec */
> +	nau8822_1a: audio-codec@1a {
> +		compatible = "nuvoton,nau8822";
> +		reg = <0x1a>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_i2s1_mclk>;
> +		#sound-dai-cells = <0>;
> +	};
> +
>  	/* IO Expander */
>  	gpio_expander_21: gpio@21 {
>  		compatible = "nxp,pcal6416";
> -- 
> 2.25.1
> 
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 4/4] arm64: dts: ti: verdin-am62: dahlia: add sound card

[Jai Luthra]

[-- Attachment #1.1: Type: text/plain, Size: 2707 bytes --]

On Jul 31, 2023 at 16:21:35 +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Add WM8904 based analog sound card to Dahlia carrier board.
> 
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Reviewed-by: Jai Luthra <j-luthra@ti.com>

> ---
>  .../boot/dts/ti/k3-am62-verdin-dahlia.dtsi    | 53 +++++++++++++++++++
>  1 file changed, 53 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
> index 3abd8d1d6761..e59235d6a8e6 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-dahlia.dtsi
> @@ -8,6 +8,43 @@
>   * https://www.toradex.com/products/carrier-board/dahlia-carrier-board-kit
>   */
>  
> +/ {
> +	reg_1v8_sw: regulator-1v8-sw {
> +		compatible = "regulator-fixed";
> +		regulator-max-microvolt = <1800000>;
> +		regulator-min-microvolt = <1800000>;
> +		regulator-name = "On-carrier +V1.8_SW";
> +	};
> +
> +	sound {
> +		compatible = "simple-audio-card";
> +		simple-audio-card,bitclock-master = <&codec_dai>;
> +		simple-audio-card,format = "i2s";
> +		simple-audio-card,frame-master = <&codec_dai>;
> +		simple-audio-card,name = "verdin-wm8904";
> +		simple-audio-card,routing =
> +			"Headphone Jack", "HPOUTL",
> +			"Headphone Jack", "HPOUTR",
> +			"IN2L", "Line In Jack",
> +			"IN2R", "Line In Jack",
> +			"Headphone Jack", "MICBIAS",
> +			"IN1L", "Headphone Jack";
> +		simple-audio-card,widgets =
> +			"Microphone", "Headphone Jack",
> +			"Headphone", "Headphone Jack",
> +			"Line", "Line In Jack";
> +
> +		codec_dai: simple-audio-card,codec {
> +			clocks = <&audio_refclk1>;
> +			sound-dai = <&wm8904_1a>;
> +		};
> +
> +		simple-audio-card,cpu {
> +			sound-dai = <&mcasp0>;
> +		};
> +	};
> +};
> +
>  /* Verdin ETHs */
>  &cpsw3g {
>  	status = "okay";
> @@ -46,6 +83,22 @@ &main_gpio0 {
>  &main_i2c1 {
>  	status = "okay";
>  
> +	/* Audio Codec */
> +	wm8904_1a: audio-codec@1a {
> +		compatible = "wlf,wm8904";
> +		reg = <0x1a>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_i2s1_mclk>;
> +		#sound-dai-cells = <0>;
> +		clocks = <&audio_refclk1>;
> +		clock-names = "mclk";
> +		AVDD-supply = <&reg_1v8_sw>;
> +		CPVDD-supply = <&reg_1v8_sw>;
> +		DBVDD-supply = <&reg_1v8_sw>;
> +		DCVDD-supply = <&reg_1v8_sw>;
> +		MICVDD-supply = <&reg_1v8_sw>;
> +	};
> +
>  	/* Current measurement into module VCC */
>  	hwmon@40 {
>  		compatible = "ti,ina219";
> -- 
> 2.25.1
> 
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx

[Jai Luthra]

[-- Attachment #1.1: Type: text/plain, Size: 2897 bytes --]

Hi Francesco,

Thank you for posting this patch.

On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote:
> From: Jai Luthra <j-luthra@ti.com>
> 
> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to
> external peripherals when configured through CTRL_MMR, so add the
> clock nodes.
> 
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi  | 18 ++++++++++++++++++
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++

Given currently none of the AM62A boards are using the refclks, can you 
drop those or just mark the nodes as disabled. Whoever is the first user 
can enable them.

With that change, LGTM.
Not sure if I can provide an R-by tag, given I'm the author.

>  2 files changed, 36 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 33b6aadc9083..3a1b387bbf49 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -60,6 +60,24 @@ epwm_tbclk: clock@4130 {
>  			reg = <0x4130 0x4>;
>  			#clock-cells = <1>;
>  		};
> +
> +		audio_refclk0: clock@82e0 {
> +			compatible = "ti,am62-audio-refclk";
> +			reg = <0x82e0 0x4>;
> +			clocks = <&k3_clks 157 0>;
> +			assigned-clocks = <&k3_clks 157 0>;
> +			assigned-clock-parents = <&k3_clks 157 8>;
> +			#clock-cells = <0>;
> +		};
> +
> +		audio_refclk1: clock@82e4 {
> +			compatible = "ti,am62-audio-refclk";
> +			reg = <0x82e4 0x4>;
> +			clocks = <&k3_clks 157 10>;
> +			assigned-clocks = <&k3_clks 157 10>;
> +			assigned-clock-parents = <&k3_clks 157 18>;
> +			#clock-cells = <0>;
> +		};
>  	};
>  
>  	dmss: bus@48000000 {
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> index 8397cb80f559..30b163a9b248 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> @@ -60,6 +60,24 @@ epwm_tbclk: clock-controller@4130 {
>  			reg = <0x4130 0x4>;
>  			#clock-cells = <1>;
>  		};
> +
> +		audio_refclk0: clock@82e0 {
> +			compatible = "ti,am62-audio-refclk";
> +			reg = <0x82e0 0x4>;
> +			clocks = <&k3_clks 157 0>;
> +			assigned-clocks = <&k3_clks 157 0>;
> +			assigned-clock-parents = <&k3_clks 157 8>;
> +			#clock-cells = <0>;
> +		};
> +
> +		audio_refclk1: clock@82e4 {
> +			compatible = "ti,am62-audio-refclk";
> +			reg = <0x82e4 0x4>;
> +			clocks = <&k3_clks 157 10>;
> +			assigned-clocks = <&k3_clks 157 10>;
> +			assigned-clock-parents = <&k3_clks 157 18>;
> +			#clock-cells = <0>;
> +		};
>  	};
>  
>  	dmss: bus@48000000 {
> -- 
> 2.25.1
> 
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx

[Francesco Dolcini]

Il 2 agosto 2023 13:23:50 CEST, Jai Luthra <j-luthra@ti.com> ha scritto:
>Hi Francesco,
>
>Thank you for posting this patch.
>
>On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote:
>> From: Jai Luthra <j-luthra@ti.com>
>> 
>> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to
>> external peripherals when configured through CTRL_MMR, so add the
>> clock nodes.
>> 
>> Signed-off-by: Jai Luthra <j-luthra@ti.com>
>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi  | 18 ++++++++++++++++++
>>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++
>
>Given currently none of the AM62A boards are using the refclks, can you 
>drop those or just mark the nodes as disabled. Whoever is the first user 
>can enable them.

I can drop the 2 clocks from AM62A, however, should we really do it? These clocks exist and they are just defined in the DTS, they are not going to be enabled if not used, "ti,am62-epwm-tbclk" is also not disabled for example.

Francesco


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx

[Nishanth Menon]

On 13:37-20230802, Francesco Dolcini wrote:
> 
> 
> Il 2 agosto 2023 13:23:50 CEST, Jai Luthra <j-luthra@ti.com> ha scritto:
> >Hi Francesco,
> >
> >Thank you for posting this patch.
> >
> >On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote:
> >> From: Jai Luthra <j-luthra@ti.com>
> >> 
> >> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to
> >> external peripherals when configured through CTRL_MMR, so add the
> >> clock nodes.
> >> 
> >> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> >> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> >> ---
> >>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi  | 18 ++++++++++++++++++
> >>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++
> >
> >Given currently none of the AM62A boards are using the refclks, can you 
> >drop those or just mark the nodes as disabled. Whoever is the first user 
> >can enable them.
> 
> I can drop the 2 clocks from AM62A, however, should we really do it? These clocks exist and they are just defined in the DTS, they are not going to be enabled if not used, "ti,am62-epwm-tbclk" is also not disabled for example.

Overall, the SoC clock as such has nothing to do with board specific, so
leave it default (enabled) in SoC.dts - just want to make sure that the
clk-parent selection doesn't get in the way of platforms and is a sane
default.

I find audio clock muxing a bit of a pain (only next to DSS clocking,
but that is another story).. so will depend on you folks for help.
Looking at https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am62ax/clocks.html#clocks-for-board0-device
and Clocking spec, setting this:
+			assigned-clocks = <&k3_clks 157 0>;
+			assigned-clock-parents = <&k3_clks 157 8>;
as default implies:
pll2_hsdiv8 output - which looks like the default mux value anyways.. I
am ok for it being explicit, but wondering if that works for boards that
do not use this default.

Could you guys confirm?

(sidenote): Fransesco - your new mail client has line wrap issues ;)
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx

[Francesco Dolcini]

On Wed, Aug 02, 2023 at 08:32:44AM -0500, Nishanth Menon wrote:
> On 13:37-20230802, Francesco Dolcini wrote:
> > Il 2 agosto 2023 13:23:50 CEST, Jai Luthra <j-luthra@ti.com> ha scritto:
> > >On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote:
> > >> From: Jai Luthra <j-luthra@ti.com>
> > >> 
> > >> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to
> > >> external peripherals when configured through CTRL_MMR, so add the
> > >> clock nodes.
> > >> 
> > >> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> > >> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > >> ---
> > >>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi  | 18 ++++++++++++++++++
> > >>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++
> > >
> > >Given currently none of the AM62A boards are using the refclks, can you 
> > >drop those or just mark the nodes as disabled. Whoever is the first user 
> > >can enable them.
> > 
> > I can drop the 2 clocks from AM62A, however, should we really do it?
> > These clocks exist and they are just defined in the DTS, they are
> > not going to be enabled if not used, "ti,am62-epwm-tbclk" is also
> > not disabled for example.
> 
> Overall, the SoC clock as such has nothing to do with board specific, so
> leave it default (enabled) in SoC.dts - just want to make sure that the
> clk-parent selection doesn't get in the way of platforms and is a sane
> default.

When I looked into that, months ago, this looked to me the correct and a
sane default. I had the same in our downstream way before the addition
from Jai Luthra to the SoC dtsi.

Not sure if Jai can add more on that regard.

> pll2_hsdiv8 output - which looks like the default mux value anyways..
> I am ok for it being explicit, but wondering if that works for boards
> that do not use this default.

IFF needed, it would be very easy to just override from the board dts,
using the labels that are already there (audio_refclk0, audio_refclk1).

> (sidenote): Fransesco - your new mail client has line wrap issues ;)
Yep, I had the crazy idea to reply from my mobile phone while having a
walk. It's already a success that I did not top post ;-)

Francesco


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx

[Nishanth Menon]

On 15:41-20230802, Francesco Dolcini wrote:
> On Wed, Aug 02, 2023 at 08:32:44AM -0500, Nishanth Menon wrote:
> > On 13:37-20230802, Francesco Dolcini wrote:
> > > Il 2 agosto 2023 13:23:50 CEST, Jai Luthra <j-luthra@ti.com> ha scritto:
> > > >On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote:
> > > >> From: Jai Luthra <j-luthra@ti.com>
> > > >> 
> > > >> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to
> > > >> external peripherals when configured through CTRL_MMR, so add the
> > > >> clock nodes.
> > > >> 
> > > >> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> > > >> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > >> ---
> > > >>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi  | 18 ++++++++++++++++++
> > > >>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++
> > > >
> > > >Given currently none of the AM62A boards are using the refclks, can you 
> > > >drop those or just mark the nodes as disabled. Whoever is the first user 
> > > >can enable them.
> > > 
> > > I can drop the 2 clocks from AM62A, however, should we really do it?
> > > These clocks exist and they are just defined in the DTS, they are
> > > not going to be enabled if not used, "ti,am62-epwm-tbclk" is also
> > > not disabled for example.
> > 
> > Overall, the SoC clock as such has nothing to do with board specific, so
> > leave it default (enabled) in SoC.dts - just want to make sure that the
> > clk-parent selection doesn't get in the way of platforms and is a sane
> > default.
> 
> When I looked into that, months ago, this looked to me the correct and a
> sane default. I had the same in our downstream way before the addition
> from Jai Luthra to the SoC dtsi.
> 
> Not sure if Jai can add more on that regard.
> 
> > pll2_hsdiv8 output - which looks like the default mux value anyways..
> > I am ok for it being explicit, but wondering if that works for boards
> > that do not use this default.
> 
> IFF needed, it would be very easy to just override from the board dts,
> using the labels that are already there (audio_refclk0, audio_refclk1).

Jai: This sounds sane to me, if you are OK as well, I'd appreciate a reviewed-by

> 
> > (sidenote): Fransesco - your new mail client has line wrap issues ;)
> Yep, I had the crazy idea to reply from my mobile phone while having a
> walk. It's already a success that I did not top post ;-)

hehe ;)

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx

[Jai Luthra]

[-- Attachment #1.1: Type: text/plain, Size: 3058 bytes --]

Hi Nishanth, Francesco,

On Aug 02, 2023 at 09:00:20 -0500, Nishanth Menon wrote:
> On 15:41-20230802, Francesco Dolcini wrote:
> > On Wed, Aug 02, 2023 at 08:32:44AM -0500, Nishanth Menon wrote:
> > > On 13:37-20230802, Francesco Dolcini wrote:
> > > > Il 2 agosto 2023 13:23:50 CEST, Jai Luthra <j-luthra@ti.com> ha scritto:
> > > > >On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote:
> > > > >> From: Jai Luthra <j-luthra@ti.com>
> > > > >> 
> > > > >> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to
> > > > >> external peripherals when configured through CTRL_MMR, so add the
> > > > >> clock nodes.
> > > > >> 
> > > > >> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> > > > >> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > > >> ---
> > > > >>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi  | 18 ++++++++++++++++++
> > > > >>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++
> > > > >
> > > > >Given currently none of the AM62A boards are using the refclks, can you 
> > > > >drop those or just mark the nodes as disabled. Whoever is the first user 
> > > > >can enable them.
> > > > 
> > > > I can drop the 2 clocks from AM62A, however, should we really do it?
> > > > These clocks exist and they are just defined in the DTS, they are
> > > > not going to be enabled if not used, "ti,am62-epwm-tbclk" is also
> > > > not disabled for example.
> > > 
> > > Overall, the SoC clock as such has nothing to do with board specific, so
> > > leave it default (enabled) in SoC.dts - just want to make sure that the
> > > clk-parent selection doesn't get in the way of platforms and is a sane
> > > default.
> > 
> > When I looked into that, months ago, this looked to me the correct and a
> > sane default. I had the same in our downstream way before the addition
> > from Jai Luthra to the SoC dtsi.
> > 
> > Not sure if Jai can add more on that regard.
> > 
> > > pll2_hsdiv8 output - which looks like the default mux value anyways..
> > > I am ok for it being explicit, but wondering if that works for boards
> > > that do not use this default.
> > 
> > IFF needed, it would be very easy to just override from the board dts,
> > using the labels that are already there (audio_refclk0, audio_refclk1).
> 
> Jai: This sounds sane to me, if you are OK as well, I'd appreciate a reviewed-by
> 

Makes sense, most external peripherals would prefer that default PLL as 
parent - for other usecases what Francesco said can work.

Reviewed-by: Jai Luthra <j-luthra@ti.com>

> > 
> > > (sidenote): Fransesco - your new mail client has line wrap issues ;)
> > Yep, I had the crazy idea to reply from my mobile phone while having a
> > walk. It's already a success that I did not top post ;-)
> 
> hehe ;)
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel