From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 203F0C04A6A for ; Wed, 2 Aug 2023 13:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=RaBzUqlh1cURIyWE/0rBWbGMo8/gYln9bp+Qg2bysqs=; b=wZnfd2/RTTU1/v czcyQRmH99bZ07MQsICmbmuQ284Evr9U2zYScZUaiwAOntjTGj/hyqT3/CpJQJPAHuMElCo93GP6t eu8ugOpnj6+WmorGQ8EprIEdTMgeA8EBZa3FoBBiP5CZ06BXdtltUChTZ51k1Rl6Ude2fu7hSzRE+ VzwFGwEbfkGjRogClomOAo33z+n/+gP7OW+66bgd0FT48bYpnS+65zkUmYUMKJY+NMoXtcZ3mxxpM 6qHtxTT+s2etA8AVjArVSEwrVL/d47eU2KOuIuC6Y6cnlTBSSqfm/GPH0IGcYTZF8wRDDJtTzS6EB IePBd3s+jCrANee0bWrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRC0Z-004zLs-32; Wed, 02 Aug 2023 13:35:23 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRC0W-004zKi-1Y for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 13:35:21 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4fe1489ced6so11359646e87.0 for ; Wed, 02 Aug 2023 06:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690983318; x=1691588118; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cIdVDpJXzS+NvG6cPE69v+Vo8D8lHdK5ntY+IO2Phoo=; b=D2kDCBtAttEWumqYhWLnqvzu6wleezJOq2vuwf5ntVyQ2rTwT6EjhipQarm7eSaZM0 c1p/UpO91vnGCCn0bVnT2mogT1Dl0G55aWrYyug7/TMfrZa6rXcHSGBgIpxgtgX0N8zw UzzjBeDVkF95OdNCm7kbjHxJyxForQRSK20cO1Uh8XysUwBmVSrXe92W1R7b6k97Za1C 1CXlFiyofIeMw1Xu8uL38AzhkKL1DPVDlapdESRsHP0Oo+gsxx/J/fU5bkKfl2w37Kk5 R/Ij0OLkqBVnu9lbCq9ix8ykKxNtTirJVLgLpPmx1M0hJNdUwbI/JJ4w2udZ9a2XfuGp VNXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690983318; x=1691588118; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cIdVDpJXzS+NvG6cPE69v+Vo8D8lHdK5ntY+IO2Phoo=; b=hb+U/0QNGPMc4U+V7rueP22e1cyKs9KuQUCVTaXUbPuLe5gSbk/P2QgexkJ6Wa+myP 1Q03PVgcYKXrRNFMR1BMRN8nkUx8n1Sygogvfyz4cIE7t7A+F+aqKT+ztQfyu+BwQQFN jvJJaGLUNuRG6pGCntb2XTs33oXRwToPa81lcd2dJf58ddM6bD+gpOEh/LT3MKCU9mw0 NGnoGvE+eC1uSE2JE6XAr8iZpc0wmuhAZz2Xjye9hbRj0iyzO88Qxp4+ye5e5FqySXV9 Q5HbntwUODK4qm85Trl+xpZsKnnYFxeT2zgWzQqZDD1k2lHE2AeXlFJVQSC1kHQdPU8y 4P5g== X-Gm-Message-State: ABy/qLbnnUlHkTPGTvRPTf/y6/lo/DSrs1AQ501zIdr3foz4QvY3PS1Y EsTxUw05bV0Kw0ZfsC8w7CU= X-Google-Smtp-Source: APBJJlEHTtK/CnKxbSzEwYziNluvzwpl4TyauHGwMYXt4Y6XTzcawP+k/3a8BYfEbHGb3QZCY1jRUg== X-Received: by 2002:a19:501a:0:b0:4fe:2f8a:457e with SMTP id e26-20020a19501a000000b004fe2f8a457emr4109315lfb.43.1690983317800; Wed, 02 Aug 2023 06:35:17 -0700 (PDT) Received: from localhost.localdomain ([78.97.234.98]) by smtp.gmail.com with ESMTPSA id d15-20020aa7d68f000000b00522594a614fsm8547719edr.13.2023.08.02.06.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 06:35:17 -0700 (PDT) From: Andrei Coardos To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-iio@vger.kernel.org Cc: alexandre.torgue@foss.st.com, mcoquelin.stm32@gmail.com, lars@metafoo.de, jic23@kernel.org, Andrei Coardos , Alexandru Ardelean Subject: [PATCH v2] iio: trigger: stm32-lptimer-trigger: remove unneeded platform_set_drvdata() Date: Wed, 2 Aug 2023 16:35:09 +0300 Message-Id: <20230802133509.29381-1-aboutphysycs@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230802_063520_521379_1C58F242 X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Reviewed-by: Alexandru Ardelean Signed-off-by: Andrei Coardos --- Changelog V1->V2: * https://lore.kernel.org/linux-iio/CAH3L5QpuoDYU6qvWH7_z5Yx0cW2qPMbCA8AFEYAPsiEkSzCiwQ@mail.gmail.com/T/#t * Adjusted the returning values of the function drivers/iio/trigger/stm32-lptimer-trigger.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/iio/trigger/stm32-lptimer-trigger.c b/drivers/iio/trigger/stm32-lptimer-trigger.c index df2416e33375..ab1cc6a05f26 100644 --- a/drivers/iio/trigger/stm32-lptimer-trigger.c +++ b/drivers/iio/trigger/stm32-lptimer-trigger.c @@ -88,11 +88,7 @@ static int stm32_lptim_trigger_probe(struct platform_device *pdev) priv->dev = &pdev->dev; priv->trg = stm32_lptim_triggers[index]; - ret = stm32_lptim_setup_trig(priv); - if (ret) - return ret; - - return 0; + return stm32_lptim_setup_trig(priv); } static const struct of_device_id stm32_lptim_trig_of_match[] = { -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel