From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF18CC001DF for ; Wed, 2 Aug 2023 14:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j25Loll2b/NHjE6tE3bFGlo0WaJhj486fs98KJDysL4=; b=LzxVLPPmW9MLkb V/7JYEVa5rjeP87dZew6v9/1LS4NbYe32sxChHdLaxRWcqLxtbKHxbVdCOdrTWvpengRJ4VxDv7rv 7TgLiUcIbPDsNIL6h3kxwGMXN5fzTsrkE1L/sM6cm3PEEsGsNTVruUq8+nY1vzyMDAIJiw+DFM1/7 7XE26CTx7QbjDpopP7S9m0bk7h8xy/0/tRWPTRJeddRZMIvC4MJEzivExbVu31xqvxFM6LUu3DciT bA5/sUG++h8F0jQdwaaORQPtcQKMFsboyKRakEu4W1pB21ZJJGhCeGmqzxPu9vy0TS5U1UgMS7I3R xOSNNv1HQpaay2Z8+cPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRCOv-0052jU-2g; Wed, 02 Aug 2023 14:00:33 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRCOs-0052iR-1r for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 14:00:32 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 372E0KxD084046; Wed, 2 Aug 2023 09:00:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1690984820; bh=QzqUq95aQ6oOsHQEGnGJgGG3G9lbd6Qhpv7J5KatXFw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=AchlSEZZiQeb+b18wnz2ff3sMHKWIggDanc0l3IzevUUB0QAatH+EUXxVP2mPVl6T Fr+Ph9NqTNRgXn1kg7RZIRS/YnTPGE/GuhFgk1KIhVdbOsUO9gMmJHGXHGopawJv2M 8A+g3y4NLqOk80ZKCOqQ8EboKkX3hnIhbVGvvZbU= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 372E0Kjv109363 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 2 Aug 2023 09:00:20 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 2 Aug 2023 09:00:20 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 2 Aug 2023 09:00:20 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 372E0Kmh118210; Wed, 2 Aug 2023 09:00:20 -0500 Date: Wed, 2 Aug 2023 09:00:20 -0500 From: Nishanth Menon To: Francesco Dolcini CC: Jai Luthra , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Francesco Dolcini Subject: Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx Message-ID: <20230802140020.k233zqpjar5ag4iv@outbreak> References: <20230731142135.108477-1-francesco@dolcini.it> <20230731142135.108477-2-francesco@dolcini.it> <23C6E13C-3F10-490B-A18E-C67B91CBAF35@dolcini.it> <20230802133244.b66pg3mztotgqotm@steerable> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230802_070030_692401_509072D5 X-CRM114-Status: GOOD ( 31.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15:41-20230802, Francesco Dolcini wrote: > On Wed, Aug 02, 2023 at 08:32:44AM -0500, Nishanth Menon wrote: > > On 13:37-20230802, Francesco Dolcini wrote: > > > Il 2 agosto 2023 13:23:50 CEST, Jai Luthra ha scritto: > > > >On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote: > > > >> From: Jai Luthra > > > >> > > > >> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to > > > >> external peripherals when configured through CTRL_MMR, so add the > > > >> clock nodes. > > > >> > > > >> Signed-off-by: Jai Luthra > > > >> Signed-off-by: Francesco Dolcini > > > >> --- > > > >> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 18 ++++++++++++++++++ > > > >> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++ > > > > > > > >Given currently none of the AM62A boards are using the refclks, can you > > > >drop those or just mark the nodes as disabled. Whoever is the first user > > > >can enable them. > > > > > > I can drop the 2 clocks from AM62A, however, should we really do it? > > > These clocks exist and they are just defined in the DTS, they are > > > not going to be enabled if not used, "ti,am62-epwm-tbclk" is also > > > not disabled for example. > > > > Overall, the SoC clock as such has nothing to do with board specific, so > > leave it default (enabled) in SoC.dts - just want to make sure that the > > clk-parent selection doesn't get in the way of platforms and is a sane > > default. > > When I looked into that, months ago, this looked to me the correct and a > sane default. I had the same in our downstream way before the addition > from Jai Luthra to the SoC dtsi. > > Not sure if Jai can add more on that regard. > > > pll2_hsdiv8 output - which looks like the default mux value anyways.. > > I am ok for it being explicit, but wondering if that works for boards > > that do not use this default. > > IFF needed, it would be very easy to just override from the board dts, > using the labels that are already there (audio_refclk0, audio_refclk1). Jai: This sounds sane to me, if you are OK as well, I'd appreciate a reviewed-by > > > (sidenote): Fransesco - your new mail client has line wrap issues ;) > Yep, I had the crazy idea to reply from my mobile phone while having a > walk. It's already a success that I did not top post ;-) hehe ;) -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel