From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31BB4C001E0 for ; Wed, 2 Aug 2023 16:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: Mime-Version:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=brOHBGG6ls4SZiDhgeoUHH+tJctgbOFLDxPYr6RU0gI=; b=rw/ 83vRluFNQnlkWGXPtCFuXLl0PTW1yb4pDSFoZwGyVzi7XtE5BrhNEUYZAA8U1JtrNhBFUM/qj4I82 rhKDBhGDd5ALlYQtyuT50XXgq5sL7Nc4AoBU8UDIHFt85k8+yHo71tOtFxcd6vetdZA01Ul8Ka3ar qcdjPeakozNvh+GifuzMBWyUJijHu8HjWubCMlCHhjpuUqieKBlUgAWHiWIabvkhl5rNM51yXujY8 oq4/lLRvxZaFgwRQ86bWVlH7EBdaxQHdruU492m1M96ozruutJOVmKp4Yu76u1YPKzg2bKtAthF05 gdrzCLaPW61zc8zENecZ3wKI7RAQUPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qREn8-005MJ7-33; Wed, 02 Aug 2023 16:33:42 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qREn5-005MGx-0l for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 16:33:40 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5840614b107so84480467b3.1 for ; Wed, 02 Aug 2023 09:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690994015; x=1691598815; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=6zG3aq7HgfULOpkFpLUP7eMNeijJeNMHjEYaAiVC6hQ=; b=VuCZEi145qhlUcAKcTZDji6pWfBPamaj2odFWMmJhROdRY5IEUvKCu4CVGkJMpZ+wB V9rniI3v59jvL/q2jFKgHiUMRB5PHUW/8r5sNbVrzqqN6WBvWMHeUFf4wHStBJnJF8Z4 NtcuRdUF1vQDTb5QNnOwOX0jT91LCLaTTlqbKMffe2CysvvgIGkjlsmU2dTPrbH0FK7h ZG0NE6YPGwn/jUk4ypNSrQ8XXVjLKFeETmeg3ajoxxmAcdZp219qB/BqnuwoGcl8oyPU d1q7akoDxCf3+oTZDEPi0YE2KhlPpZsKzNeSKy6CdvhCz5jfIF7XM3I+wYHI5NyzUi2R iloQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690994015; x=1691598815; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6zG3aq7HgfULOpkFpLUP7eMNeijJeNMHjEYaAiVC6hQ=; b=H6kVoxK1U7T7WZCNbUawrQ2iLey8KQKzrs0QmfNUl4I555MmOA4UlBve9Z0G8kWdEh gZvmi/90cwXcFlicZcamvUeYTA4hgLUzxSpL9pWDbeGxZ8sAK9Cmr80y7Jkx9UfrcBRS RxkrKgcsf3zQ9gAc/AYrnH5MTCmeSaXZvdpstGlCIr5vT14ovGExNyRAhIPXjAu2QSay 3OBQp3GlsjsWP1F5276l6z1qkIt51JWsYfaqNgwGbNhTptUt5VxCPBJsSuOMaiOOH8WG I0f4V1V1l74mkBPw1tpDWYSD4Cbae4F1piS5sdG/zoj1+xeBThBLjvl+bCTLgglU+JFb fg9Q== X-Gm-Message-State: ABy/qLYmAbJgRC1WWlsJtaXka8lp1ek5iWH3Y945PtjOJpu3w1HoElYT bxnaiWJLgVpVVl7S2CgyrjfC/RY5ZkZs X-Google-Smtp-Source: APBJJlGO1qCeBmmjOPcirlf8Jm42kHHvIm0fpZyq1d6XLYjTuQYoD9pmW78dseekgWdVk/XG6XLb4eg4QhV4 X-Received: from mshavit.ntc.corp.google.com ([2401:fa00:95:20c:39d1:8774:b733:6210]) (user=mshavit job=sendgmr) by 2002:a25:db82:0:b0:d0e:d67d:6617 with SMTP id g124-20020a25db82000000b00d0ed67d6617mr120144ybf.4.1690994015388; Wed, 02 Aug 2023 09:33:35 -0700 (PDT) Date: Thu, 3 Aug 2023 00:32:28 +0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.585.gd2178a4bd4-goog Message-ID: <20230802163328.2623773-1-mshavit@google.com> Subject: [PATCH v4 0/8] Refactor the SMMU's CD table ownership From: Michael Shavit To: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: will@kernel.org, robin.murphy@arm.com, nicolinc@nvidia.com, jgg@nvidia.com, jean-philippe@linaro.org, Michael Shavit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230802_093339_271450_FF8DD9B2 X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi all, This series refactors stage 1 domains so that they describe a single CD entry. These entries are now inserted into a CD table that is owned by the arm_smmu_master instead of the domain. This is conceptually cleaner and unblocks other features, such as attaching domains with PASID (for unmanaged/dma domains). This patch series was originally part of a larger patch series that implemented the set_dev_pasid callback for non-SVA domains but is now split into a distinct series. This patch series is also available on gerrit with Jean's SMMU test engine patches cherry-picked on top for testing: https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/24742/5 Thanks, Michael Shavit Changes in v4: - Added comment about the cd_table's dependency on the iommu core's group mutex. - Narrowed the range of code for which the domain's init_mutex is held on attach since it now only protects the arm_smmu_domain_finalise call. - Link to v3: https://lore.kernel.org/all/20230801183845.4026101-1-mshavit@google.com/ Changes in v3: - Add a helper to write a CD to all masters that a domain is attached to. - Fixed an issue where an arm_smmu_write_ctx_desc error return wasn't correctly handled by its caller. - Flip the cd_table.installed bit back off when table is detached - re-order the commit later in the series since flipping the installed bit to off isn't obvious when the cd_table is still shared by multiple masters. - Link to v2: https://lore.kernel.org/all/20230731104833.800114-1-mshavit@google.com/ Changes in v2: - Allocate CD table when it's first needed instead of on probe. - Minor changes - Added commit to rename remaining usages of cdcfg to cd_table - Link to v1: https://lore.kernel.org/all/20230727182647.4106140-1-mshavit@google.com/#r Changes in v1: - Replace s1_cfg with arm_smmu_ctx_desc_cfg representing the CD table - Assume that the CD table is owned by the SMMU master for most operations. This is forward-compatible with the nested patch series as these operations wouldn't be called when the installed CD table comes from nested domains. - Split off as a distinct patch series from https://lore.kernel.org/all/20230621063825.268890-1-mshavit@google.com/ Michael Shavit (8): iommu/arm-smmu-v3: Move ctx_desc out of s1_cfg iommu/arm-smmu-v3: Replace s1_cfg with cdtab_cfg iommu/arm-smmu-v3: Encapsulate ctx_desc_cfg init in alloc_cd_tables iommu/arm-smmu-v3: move stall_enabled to the cd table iommu/arm-smmu-v3: Refactor write_ctx_desc iommu/arm-smmu-v3: Move CD table to arm_smmu_master iommu/arm-smmu-v3: Skip cd sync if CD table isn't active iommu/arm-smmu-v3: Rename cdcfg to cd_table .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 33 ++- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 234 ++++++++---------- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 22 +- 3 files changed, 147 insertions(+), 142 deletions(-) base-commit: 57012c57536f8814dec92e74197ee96c3498d24e -- 2.41.0.585.gd2178a4bd4-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel