From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41C76C04A94 for ; Wed, 2 Aug 2023 19:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=+JC50Hgp9hbSEncdYMDNFOirS5PnHUyHKdJOHvIpmMw=; b=Gr8ueNdspuv2k4 WrdI9fPvbCQFtjKpPr+apdV+snyMbHa1Lv4Zm0I6hgG/ndSJ6CGdgTI6yQXG4bq/4FK8HOHY8PU7H VZx7FNvknz2UA3eb4SrEtBPeRX/B1xt1Qfn3DsKeQBgaCfA+JuiPauQ0XP6N0ePbIZWCgbuZ5cS7Q KPtsR9CsaWyCYJKSVS+ePzXUZQZ7VZ9/gvv5vmxVMx30zwE+emwh8rKcANwEA4STa8gjand5NRy79 m5uR4m06WUJ2qsW/GD9hPihfLYMO8tEizJLjyzHLgqtX/GkFJu27ctXWZlqy2fpgZrQVLA9lVuaV8 ZdlZpLtzVF9qU1CS/dvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRHAi-005hXX-2B; Wed, 02 Aug 2023 19:06:12 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRHAg-005hWy-05 for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 19:06:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 78AFA61943; Wed, 2 Aug 2023 19:06:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69053C433C8; Wed, 2 Aug 2023 19:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691003168; bh=R0/Y/OgJC88hx/QGYFFgUJRv81sXFf1ZczNdRm7daqw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=KOOusFW+uebA8FXjwEmlh+Nd3frDaJQtci1gV7iasXPYsXDDAoDmgrq73Y2MzzyVg vAphdNYEWuXni7ENa4e4VakRc95edEuNwXIJ7Q6w6IJhGiC7jZBy/2Oqeihcd2yz2e fZWuP452I2OLpG9vs6+cc3jyyoaK4Z6e/4HW4VOLCqbnrRfXA5vXDsfqoYKj+Fn4PK 8VzSmjHw+eCEYUVg4Uhc2DMul1EdBeLYifQHi0+XzkibNwG/57TsTwwA9HErhcmrsC kd/uES1wXLtD8UGH1JMrFTJA98m7cjGpWpHZhtCYEW8EtUNJe7AZ66OKP9/AAyO765 1maO9DwLPofEA== Date: Wed, 2 Aug 2023 14:06:06 -0500 From: Bjorn Helgaas To: Frank Li Cc: mani@kernel.org, bhelgaas@google.com, devicetree@vger.kernel.org, gustavo.pimentel@synopsys.com, imx@lists.linux.dev, kw@linux.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org, minghuan.lian@nxp.com, mingkai.hu@nxp.com, robh+dt@kernel.org, roy.zang@nxp.com, shawnguo@kernel.org, zhiqiang.hou@nxp.com Subject: Re: [PATCH v7 1/2] PCI: dwc: Implement general suspend/resume functionality for L2/L3 transitions Message-ID: <20230802190606.GA64564@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230802_120610_108648_0225EF35 X-CRM114-Status: GOOD ( 17.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 02, 2023 at 02:44:52PM -0400, Frank Li wrote: > On Wed, Aug 02, 2023 at 11:31:38AM -0500, Bjorn Helgaas wrote: > > On Wed, Aug 02, 2023 at 11:57:47AM -0400, Frank Li wrote: > > > Introduce helper function dw_pcie_get_ltssm to retrieve SMLH_LTSS_STATE. > > > Add callback .pme_turn_off and .exit_from_l2 for platform specific PME > > > handling. > > > + * PCI Express Base Specification Rev 4.0 Section 5.3.3.2.1 PME > > > + * Synchronization Recommends 1ms to 10ms timeout to check L2 ready. > > > + */ > > > + ret = read_poll_timeout(dw_pcie_get_ltssm, val, val == DW_PCIE_LTSSM_L2_IDLE, > > > + 1000, 10000, false, pci); > > It would really be great to have a #define for this since the bare > > numbers are not very meaningful and they're not specific to DWC so a > > #define would let us find similar situations in other drivers. > > how about define as > > #define PCI_PME_TO_L2_TIMEOUT 10000 > > ret = read_poll_timeout(dw_pcie_get_ltssm, val, val == DW_PCIE_LTSSM_L2_IDLE, > PCI_PME_TO_L2_TIMEOUT/10, PCI_PME_TO_L2_TIMEOUT, false, pci); > > where is good place PCI_PME_TO_L2_TIMEOUT in? > > pcie-designware.h or pci.h? I think drivers/pci/pci.h since it's only useful inside drivers/pci, and it's not specific to dwc. Maybe "PCIE_" (not "PCI_") since this is a PCIe-specific thing. You could put it next to PCIE_LINK_RETRAIN_TIMEOUT_MS and add a "_US" suffix so we know what the units are. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel