From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 712C6EB64DD for ; Thu, 3 Aug 2023 14:49:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5bE8qkk2OvdR9FjTntbFlaRtyBBSeq6eboGPp9VMyeI=; b=Osw4tbIRh8QJIL vfn/LyCpNNpxeTBTKi+eAUpobe0gP7u93r+6TtmdD9kmC0eNnBYiWGrrbeXyd2biwusYuJXspaSnk poXE5GlIAGZy3xMSAt2KKsWHwLlFmFfmGlIRFpQfgds4HoGtj95moCiSQ+wq9F8ujmnEmVDUuwxZq lq6u3ofPzmxTostT7x5gpWQkaYAvP3thkviUrOXB9zy7duzHtE+sdbO+UaIMgyokMM0dCxDSiK+fi kY4g9KNFxImZei5I5+Ss/5gsX0A5C5sr+gpu3NOfslqKlLDkGnyAK/bbYZkYxU5kBtDLiIqFQdWmF hfJy42z4uJwiMkFEGS4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRZdt-009qah-1O; Thu, 03 Aug 2023 14:49:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRZdq-009qYI-2U for linux-arm-kernel@lists.infradead.org; Thu, 03 Aug 2023 14:49:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1EA9B113E; Thu, 3 Aug 2023 07:50:10 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D01A83F5A1; Thu, 3 Aug 2023 07:49:23 -0700 (PDT) Date: Thu, 3 Aug 2023 15:49:21 +0100 From: Andre Przywara To: Krzysztof Kozlowski Cc: Martin Botka , Konrad Dybcio , AngeloGioacchino Del Regno , Marijn Suijten , Jami Kettunen , Paul Bouchara , Martin Botka , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andrew Lunn , Icenowy Zheng , Ludwig Kormann , Heiko Stuebner , Shawn Guo , Bjorn Andersson , Chris Morgan , Jagan Teki , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 6/6] arm64: dts: allwinner: h616: Add BigTreeTech Pi support Message-ID: <20230803154921.0d42fc66@donnerap.manchester.arm.com> In-Reply-To: <17dec3fb-1bce-77ff-9917-7f565049954d@linaro.org> References: <20230802220309.163804-1-martin@biqu3d.com> <17dec3fb-1bce-77ff-9917-7f565049954d@linaro.org> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230803_074930_905749_AF7EB507 X-CRM114-Status: GOOD ( 33.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 3 Aug 2023 16:30:06 +0200 Krzysztof Kozlowski wrote: > On 03/08/2023 00:02, Martin Botka wrote: > > The BigTreeTech Pi is an H616 based board based on CB1. > > Just in Rpi format board. > > > > It features the same internals as BTT CB1 but adds: > > - Fan port > > - IR receiver > > - 24V DC power supply via terminal plugs > > - USB to CAN module connector (The actual USB to CAN happens on the external module) > > > > List of currently working things is the same as BTT CB1. > > > > Signed-off-by: Martin Botka > > --- > > .../allwinner/sun50i-h616-bigtreetech-pi.dts | 44 +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > > new file mode 100644 > > index 000000000000..05f39b3606ba > > --- /dev/null > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > > @@ -0,0 +1,44 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > > +/* > > + * Copyright (C) 2023 Martin Botka . > > + */ > > + > > +/dts-v1/; > > + > > +#include "sun50i-h616-bigtreetech-cb1.dtsi" > > If this is using CB1 DTSI, does it mean it uses CB1 SoM? If so, I think > this should be reflected in the compatibles. > > It's a bit confusing because in previous patch you call it "CB1 board" > but then with name "Manta"... So what is CB1? That's indeed a bit confusing, but from what I got from the BTT webpage: "CB1" is the SoM. M8P (and its M4P/M5P siblings) are carrier boards with extra hardware for 3D printer support, taking the CB1 SoM. The "Bigtreetech BTT Pi" is embedding the same hardware as the SoM, but without actually using the SoM, directly on a PCB, so similar to what we have with the Pine64 SoPine and the Pine64 LTS board. It doesn't come with the extra goodies of the more 3D printer related boards. I *think* the "BIGTREETECH PI4B Adapter" is a normal dev board using the actual SoM, but with an otherwise identical(?) functionality software wise - so it can run with the same DTB. I wonder if we should have a separate .dts for this, though, since I believe it's not really identical in every aspect - starting with the USB ports, for instance. But for this board and patch here I think it's fine to include the cb1.dtsi, but not using the CB1 name in the compatibles list. Cheers, Andre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel