Re: [PATCH v1 6/6] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

Krzysztof Kozlowski
2023-08-03T14:31:30Z

On 03/08/2023 00:02, Martin Botka wrote:
> The BigTreeTech Pi is an H616 based board based on CB1.
> Just in Rpi format board.
>
> It features the same internals as BTT CB1 but adds:
> - Fan port
> - IR receiver
> - 24V DC power supply via terminal plugs
> - USB to CAN module connector (The actual USB to CAN happens on the external module)
>
> List of currently working things is the same as BTT CB1.
>
> Signed-off-by: Martin Botka <martin@biqu3d.com>
> ---
> .../allwinner/sun50i-h616-bigtreetech-pi.dts | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> new file mode 100644
> index 000000000000..05f39b3606ba
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> +/*
> + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-h616-bigtreetech-cb1.dtsi"

If this is using CB1 DTSI, does it mean it uses CB1 SoM? If so, I think
this should be reflected in the compatibles.

It's a bit confusing because in previous patch you call it "CB1 board"
but then with name "Manta"... So what is CB1?

Best regards,
Krzysztof