Re: [PATCH v1 5/6] arm64: dts: allwinner: h616: Add BigTreeTech CB1 SoM & boards support

Krzysztof Kozlowski
2023-08-03T14:29:11Z

On 03/08/2023 00:02, Martin Botka wrote:
> From: Martin Botka <martin.botka@somainline.org>
>
> CB1 is Compute Module style board that plugs into Rpi board style adapter or
> Manta 3D printer boards (M4P/M8P).
>
> The SoM features:
> - H616 SoC
> - 1GiB of RAM
> - AXP313A PMIC
> - RTL8189FTV WiFi

...

> +&mmc0 {
> + vmmc-supply = <&reg_dldo1>;
> + broken-cd;
> + bus-width = <4>;
> + status = "okay";
> +};
> +
> +&mmc1 {
> + vmmc-supply = <&reg_vcc33_wifi>;
> + vqmmc-supply = <&reg_vcc_wifi_io>;
> + mmc-pwrseq = <&wifi_pwrseq>;
> + bus-width = <4>;
> + non-removable;
> + mmc-ddr-1_8v;
> + status = "okay";
> +
> + rtl8189ftv: sdio_wifi@1 {

No underxcores in node names. Generic node names, so probably "wifi".

> + reg = <1>;

Missing compatible?

Best regards,
Krzysztof