From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Julien Stephan <jstephan@baylibre.com>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Phi-bang Nguyen <pnguyen@baylibre.com>,
Florian Sylvestre <fsylvestre@baylibre.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Andy Hsieh <andy.hsieh@mediatek.com>,
Conor Dooley <conor+dt@kernel.org>,
daoyuan huang <daoyuan.huang@mediatek.com>,
devicetree@vger.kernel.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-media@vger.kernel.org, Louis Kuo <louis.kuo@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Moudy Ho <moudy.ho@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH v2 4/4] media: platform: mediatek: isp_30: add mediatek ISP3.0 camsv
Date: Fri, 4 Aug 2023 01:30:34 +0300 [thread overview]
Message-ID: <20230803223034.GH9722@pendragon.ideasonboard.com> (raw)
In-Reply-To: <iq7jffjeaejdfb26a4ysjgjzuopov4ji2ecgzmv4563tdveaep@hh2gzgzkbdzj>
On Thu, Aug 03, 2023 at 11:53:35AM +0200, Julien Stephan wrote:
> On Mon, Jul 03, 2023 at 02:21:17PM +0200, AngeloGioacchino Del Regno wrote:
> ..snip..
> > > +
> > > + mtk_cam_init_cfg(&cam->subdev, NULL);
> >
> > mtk_cam_init_cfg() returns an integer, and this is probably because you expect
> > it to get logic to fail: in that case, check the result of that call here,
> > otherwise, make that function void.
> >
>
> Hi Angelo,
>
> mtk_cam_init_cfg returns an int because it should match v4l2_subdev_pad_ops->init_cfg prototype..
>
> mtk_cam_init does not fail, always return 0, so I though it would be ok
> to discard the return value here. What do you think?
Fine with me.
> > > +
>
> ..snip..
>
> > > + unsigned int bpp;
> >
> > Can we get any format that uses a billion bits per pixel? :-P
> >
> > u8 bpp;
>
> I am preparing the driver for futur upgrades.. in a billion years ;)
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-03 22:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 10:01 [PATCH v2 0/4] Add Mediatek ISP3.0 Julien Stephan
2023-06-30 10:01 ` [PATCH v2 1/4] dt-bindings: media: add mediatek ISP3.0 sensor interface Julien Stephan
2023-06-30 11:23 ` Rob Herring
2023-06-30 14:32 ` Rob Herring
2023-06-30 10:01 ` [PATCH v2 2/4] media: platform: mediatek: isp_30: " Julien Stephan
2023-07-01 23:13 ` Chun-Kuang Hu
2023-07-01 23:35 ` Chun-Kuang Hu
2023-07-02 9:20 ` Chun-Kuang Hu
2023-07-03 12:18 ` Laurent Pinchart
2023-07-03 12:30 ` AngeloGioacchino Del Regno
2023-07-03 11:02 ` AngeloGioacchino Del Regno
2023-08-04 14:50 ` Julien Stephan
2023-08-04 15:05 ` Laurent Pinchart
2023-06-30 10:01 ` [PATCH v2 3/4] dt-bindings: media: add mediatek ISP3.0 camsv Julien Stephan
2023-06-30 11:23 ` Rob Herring
2023-06-30 14:33 ` Rob Herring
2023-06-30 10:01 ` [PATCH v2 4/4] media: platform: mediatek: isp_30: " Julien Stephan
2023-07-02 9:50 ` Chun-Kuang Hu
2023-07-03 12:21 ` AngeloGioacchino Del Regno
2023-08-03 9:53 ` Julien Stephan
2023-08-03 22:30 ` Laurent Pinchart [this message]
2023-08-04 7:34 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803223034.GH9722@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=agordeev@linux.ibm.com \
--cc=andy.hsieh@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=daoyuan.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fsylvestre@baylibre.com \
--cc=gor@linux.ibm.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jstephan@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=ping-hsun.wu@mediatek.com \
--cc=pnguyen@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).