From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28B59C001DB for ; Fri, 4 Aug 2023 15:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CwZtvKk+iiNZpdWjH0aNkAqBVbnob4C8u7ru1LOWu68=; b=XKI/VtcrjIJjGpTM3yYItpGodW vGVp5QLg3cpTbLnwOlrykuPZii0sG0FxoKHIuPc2xs58sWHAQ3byRcAwU7rINXVpg3Y9jVMPm/lz9 Cq1mYuIDpCYmemaDkM8/ZQN0U8mCAtTbQLJeGfYuo27i9BhtU02Lb+4GLavRteaRSeQYgoMRkonZg 7ZjTIk7xMzIPLQFiAQv2qR0wDb929LzuUUQWsFMZLPiFkh7ZsxZHjVTjz5bWenfg3MDgxleJXVsUL oJK/Ti8qaOI4ZJdZBVeU7qclZzqE9gjYLV/HefO1t+o3B23F1F45ciLnzrECnDwEyv1GA5UGYKeX7 +mklmE4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRwaZ-00CgP6-2K; Fri, 04 Aug 2023 15:19:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRwaX-00CgOQ-06; Fri, 04 Aug 2023 15:19:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 380CF62056; Fri, 4 Aug 2023 15:19:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C5DCC433C7; Fri, 4 Aug 2023 15:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691162375; bh=hHDz38CB+HkMmklWio9ZQ4ndafz59B33DbehJXavBS0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=teXBdQCpJJ3OGjY6KbGN8tilDfEVQue00QTazqmjd5fBUChKMXwOGVLq6daR4FDbf qXh6CboMr6leIH/oWN8yvGpcscwwrmjslQI7QWzulffY5+kupSZmmzvZ2nADFHqYpn hwtMmUs4Kis5KLg9HTEElgLwEVXJLeLiD5tCsk80v3kCvaBGsw2mel+YFrODxvvtV/ Ts8Qms6P4ibqHP3HIOFH2wVY41OCAztspxeUmXNBIbic3ZQMgoib/QdWzIRwLJ1DDB 64aCZw/DlYyOHtdIzi/HMivb12UiKmuYrX7cNySDYMdLixoNqonCdaUopDLIoJ2XuD FKVAXtlKSpXKA== Date: Fri, 4 Aug 2023 16:19:27 +0100 From: Conor Dooley To: Andy Shevchenko Cc: Sunil V L , linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , Daniel Lezcano , Thomas Gleixner , Anup Patel , Marc Zyngier , Bjorn Helgaas , Robert Moore , Haibo Xu , Andrew Jones , Conor Dooley , Atish Kumar Patra Subject: Re: [RFC PATCH v1 09/21] RISC-V: cacheflush: Initialize CBO variables on ACPI systems Message-ID: <20230804-dreamy-unharmed-a502d02af35a@spud> References: <20230803175916.3174453-1-sunilvl@ventanamicro.com> <20230803175916.3174453-10-sunilvl@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230804_081937_154764_32BB504B X-CRM114-Status: GOOD ( 19.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0505717617964287909==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0505717617964287909== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GXjvkfPtI3JRgl/C" Content-Disposition: inline --GXjvkfPtI3JRgl/C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 04, 2023 at 05:59:51PM +0300, Andy Shevchenko wrote: > On Fri, Aug 04, 2023 at 02:50:34PM +0530, Sunil V L wrote: > > On Fri, Aug 04, 2023 at 08:56:29AM +0300, Andy Shevchenko wrote: > > > On Thu, Aug 03, 2023 at 11:29:04PM +0530, Sunil V L wrote: > > > > Using new interface to get the CBO block size information in > > > > RHCT, initialize the variables on ACPI platforms. >=20 > ... >=20 > > > > +#include > > >=20 > > > What do you need this for? > > >=20 > > > > #include > > >=20 > > When CONFIG_ACPI is disabled, this include is required to get > > acpi_get_cbo_block_size(). >=20 > How is it useful without ACPI being enabled? It is not, as evidenced by the `return -EINVAL;`. > If it's indeed > (in which I do not believe), better to make sure you have it > avaiable independently on CONFIG_ACPI. Otherwise, just put > #ifdef CONFIG_ACPI around the call. Let's not litter the code with ifdeffery please where it can be easily avoided. --GXjvkfPtI3JRgl/C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZM0W/wAKCRB4tDGHoIJi 0kuVAQDw7o9CBBPZvOZRnV4GOgYrlNOO9/0bJ6PGEvVlWlJR2wD+Im0XikBKI2i3 E2WQtTAIBya29pYaEsPNynJY6+2BqAc= =E2dR -----END PGP SIGNATURE----- --GXjvkfPtI3JRgl/C-- --===============0505717617964287909== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0505717617964287909==--