* [PATCH -next 0/6] net: Remove unnecessary ternary operators
@ 2023-08-04 3:53 Ruan Jinjie
2023-08-04 3:53 ` [PATCH -next 1/6] net: thunderx: " Ruan Jinjie
` (6 more replies)
0 siblings, 7 replies; 13+ messages in thread
From: Ruan Jinjie @ 2023-08-04 3:53 UTC (permalink / raw)
To: sgoutham, davem, edumazet, kuba, pabeni, jesse.brandeburg,
anthony.l.nguyen, tariqt, s.shtylyov, aspriel, franky.lin,
hante.meuleman, kvalo, richardcochran, yoshihiro.shimoda.uh,
ruanjinjie, u.kleine-koenig, mkl, lee, set_pte_at,
linux-arm-kernel, netdev, intel-wired-lan, linux-rdma,
linux-renesas-soc, linux-wireless, brcm80211-dev-list.pdl,
SHA-cyfmac-dev-list
There are a little ternary operators, the true or false judgement
of which is unnecessary in C language semantics.
Ruan Jinjie (6):
net: thunderx: Remove unnecessary ternary operators
ethernet/intel: Remove unnecessary ternary operators
net/mlx4: Remove an unnecessary ternary operator
net: ethernet: renesas: rswitch: Remove an unnecessary ternary
operator
net: fjes: Remove an unnecessary ternary operator
brcm80211: Remove an unnecessary ternary operator
drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +-
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +-
drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +-
drivers/net/ethernet/intel/igc/igc_phy.c | 2 +-
drivers/net/ethernet/mellanox/mlx4/port.c | 2 +-
drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +-
drivers/net/fjes/fjes_main.c | 2 +-
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +--
8 files changed, 8 insertions(+), 9 deletions(-)
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH -next 1/6] net: thunderx: Remove unnecessary ternary operators 2023-08-04 3:53 [PATCH -next 0/6] net: Remove unnecessary ternary operators Ruan Jinjie @ 2023-08-04 3:53 ` Ruan Jinjie [not found] ` <15759f98483947999393a25b857bc4fe@realtek.com> 2023-08-04 3:53 ` [PATCH -next 2/6] ethernet/intel: " Ruan Jinjie ` (5 subsequent siblings) 6 siblings, 1 reply; 13+ messages in thread From: Ruan Jinjie @ 2023-08-04 3:53 UTC (permalink / raw) To: sgoutham, davem, edumazet, kuba, pabeni, jesse.brandeburg, anthony.l.nguyen, tariqt, s.shtylyov, aspriel, franky.lin, hante.meuleman, kvalo, richardcochran, yoshihiro.shimoda.uh, ruanjinjie, u.kleine-koenig, mkl, lee, set_pte_at, linux-arm-kernel, netdev, intel-wired-lan, linux-rdma, linux-renesas-soc, linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list Ther are a little ternary operators, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c index 0ec65ec634df..b7cf4ba89b7c 100644 --- a/drivers/net/ethernet/cavium/thunder/nic_main.c +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c @@ -174,7 +174,7 @@ static void nic_mbx_send_ready(struct nicpf *nic, int vf) if (mac) ether_addr_copy((u8 *)&mbx.nic_cfg.mac_addr, mac); } - mbx.nic_cfg.sqs_mode = (vf >= nic->num_vf_en) ? true : false; + mbx.nic_cfg.sqs_mode = vf >= nic->num_vf_en; mbx.nic_cfg.node_id = nic->node; mbx.nic_cfg.loopback_supported = vf < nic->num_vf_en; diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c index a317feb8decb..9e467cecc33a 100644 --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c @@ -957,7 +957,7 @@ static void bgx_poll_for_sgmii_link(struct lmac *lmac) goto next_poll; } - lmac->link_up = ((pcs_link & PCS_MRX_STATUS_LINK) != 0) ? true : false; + lmac->link_up = (pcs_link & PCS_MRX_STATUS_LINK) != 0; an_result = bgx_reg_read(lmac->bgx, lmac->lmacid, BGX_GMP_PCS_ANX_AN_RESULTS); -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <15759f98483947999393a25b857bc4fe@realtek.com>]
* Re: [PATCH -next 1/6] net: thunderx: Remove unnecessary ternary operators [not found] ` <15759f98483947999393a25b857bc4fe@realtek.com> @ 2023-08-07 4:59 ` Ruan Jinjie 2023-08-07 17:34 ` Jacob Keller 0 siblings, 1 reply; 13+ messages in thread From: Ruan Jinjie @ 2023-08-07 4:59 UTC (permalink / raw) To: Ping-Ke Shih, sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, tariqt@nvidia.com, s.shtylyov@omp.ru, aspriel@gmail.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, kvalo@kernel.org, richardcochran@gmail.com, yoshihiro.shimoda.uh@renesas.com, u.kleine-koenig@pengutronix.de, mkl@pengutronix.de, lee@kernel.org, set_pte_at@outlook.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com On 2023/8/7 9:39, Ping-Ke Shih wrote: > > >> -----Original Message----- >> From: Ruan Jinjie <ruanjinjie@huawei.com> >> Sent: Friday, August 4, 2023 11:54 AM >> To: sgoutham@marvell.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >> jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; tariqt@nvidia.com; s.shtylyov@omp.ru; >> aspriel@gmail.com; franky.lin@broadcom.com; hante.meuleman@broadcom.com; kvalo@kernel.org; >> richardcochran@gmail.com; yoshihiro.shimoda.uh@renesas.com; ruanjinjie@huawei.com; >> u.kleine-koenig@pengutronix.de; mkl@pengutronix.de; lee@kernel.org; set_pte_at@outlook.com; >> linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; >> linux-rdma@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-wireless@vger.kernel.org; >> brcm80211-dev-list.pdl@broadcom.com; SHA-cyfmac-dev-list@infineon.com >> Subject: [PATCH -next 1/6] net: thunderx: Remove unnecessary ternary operators >> >> Ther are a little ternary operators, the true or false judgement >> of which is unnecessary in C language semantics. >> >> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> >> --- >> drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +- >> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c >> b/drivers/net/ethernet/cavium/thunder/nic_main.c >> index 0ec65ec634df..b7cf4ba89b7c 100644 >> --- a/drivers/net/ethernet/cavium/thunder/nic_main.c >> +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c >> @@ -174,7 +174,7 @@ static void nic_mbx_send_ready(struct nicpf *nic, int vf) >> if (mac) >> ether_addr_copy((u8 *)&mbx.nic_cfg.mac_addr, mac); >> } >> - mbx.nic_cfg.sqs_mode = (vf >= nic->num_vf_en) ? true : false; >> + mbx.nic_cfg.sqs_mode = vf >= nic->num_vf_en; >> mbx.nic_cfg.node_id = nic->node; >> >> mbx.nic_cfg.loopback_supported = vf < nic->num_vf_en; >> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> index a317feb8decb..9e467cecc33a 100644 >> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> @@ -957,7 +957,7 @@ static void bgx_poll_for_sgmii_link(struct lmac *lmac) >> goto next_poll; >> } >> >> - lmac->link_up = ((pcs_link & PCS_MRX_STATUS_LINK) != 0) ? true : false; >> + lmac->link_up = (pcs_link & PCS_MRX_STATUS_LINK) != 0; > > lmac->link_up = !!(pcs_link & PCS_MRX_STATUS_LINK); Thank you! I'll improve it sooner. > >> an_result = bgx_reg_read(lmac->bgx, lmac->lmacid, >> BGX_GMP_PCS_ANX_AN_RESULTS); >> >> -- >> 2.34.1 >> >> >> ------Please consider the environment before printing this e-mail. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH -next 1/6] net: thunderx: Remove unnecessary ternary operators 2023-08-07 4:59 ` Ruan Jinjie @ 2023-08-07 17:34 ` Jacob Keller 0 siblings, 0 replies; 13+ messages in thread From: Jacob Keller @ 2023-08-07 17:34 UTC (permalink / raw) To: Ruan Jinjie, Ping-Ke Shih, sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, tariqt@nvidia.com, s.shtylyov@omp.ru, aspriel@gmail.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, kvalo@kernel.org, richardcochran@gmail.com, yoshihiro.shimoda.uh@renesas.com, u.kleine-koenig@pengutronix.de, mkl@pengutronix.de, lee@kernel.org, set_pte_at@outlook.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com On 8/6/2023 9:59 PM, Ruan Jinjie wrote: > > > On 2023/8/7 9:39, Ping-Ke Shih wrote: >> >> >>> -----Original Message----- >>> From: Ruan Jinjie <ruanjinjie@huawei.com> >>> Sent: Friday, August 4, 2023 11:54 AM >>> To: sgoutham@marvell.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >>> jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; tariqt@nvidia.com; s.shtylyov@omp.ru; >>> aspriel@gmail.com; franky.lin@broadcom.com; hante.meuleman@broadcom.com; kvalo@kernel.org; >>> richardcochran@gmail.com; yoshihiro.shimoda.uh@renesas.com; ruanjinjie@huawei.com; >>> u.kleine-koenig@pengutronix.de; mkl@pengutronix.de; lee@kernel.org; set_pte_at@outlook.com; >>> linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; >>> linux-rdma@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-wireless@vger.kernel.org; >>> brcm80211-dev-list.pdl@broadcom.com; SHA-cyfmac-dev-list@infineon.com >>> Subject: [PATCH -next 1/6] net: thunderx: Remove unnecessary ternary operators >>> >>> Ther are a little ternary operators, the true or false judgement >>> of which is unnecessary in C language semantics. >>> >>> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> >>> --- >>> drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +- >>> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c >>> b/drivers/net/ethernet/cavium/thunder/nic_main.c >>> index 0ec65ec634df..b7cf4ba89b7c 100644 >>> --- a/drivers/net/ethernet/cavium/thunder/nic_main.c >>> +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c >>> @@ -174,7 +174,7 @@ static void nic_mbx_send_ready(struct nicpf *nic, int vf) >>> if (mac) >>> ether_addr_copy((u8 *)&mbx.nic_cfg.mac_addr, mac); >>> } >>> - mbx.nic_cfg.sqs_mode = (vf >= nic->num_vf_en) ? true : false; >>> + mbx.nic_cfg.sqs_mode = vf >= nic->num_vf_en; >>> mbx.nic_cfg.node_id = nic->node; >>> >>> mbx.nic_cfg.loopback_supported = vf < nic->num_vf_en; >>> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >>> b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >>> index a317feb8decb..9e467cecc33a 100644 >>> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >>> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >>> @@ -957,7 +957,7 @@ static void bgx_poll_for_sgmii_link(struct lmac *lmac) >>> goto next_poll; >>> } >>> >>> - lmac->link_up = ((pcs_link & PCS_MRX_STATUS_LINK) != 0) ? true : false; >>> + lmac->link_up = (pcs_link & PCS_MRX_STATUS_LINK) != 0; >> >> lmac->link_up = !!(pcs_link & PCS_MRX_STATUS_LINK); > > Thank you! I'll improve it sooner. > I personally find "!= 0" a bit more readable than '!!' but I suppose thats personal taste and !! is pretty common in the kernel. Thanks, Jake _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH -next 2/6] ethernet/intel: Remove unnecessary ternary operators 2023-08-04 3:53 [PATCH -next 0/6] net: Remove unnecessary ternary operators Ruan Jinjie 2023-08-04 3:53 ` [PATCH -next 1/6] net: thunderx: " Ruan Jinjie @ 2023-08-04 3:53 ` Ruan Jinjie 2023-08-07 17:35 ` Jacob Keller 2023-08-04 3:53 ` [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator Ruan Jinjie ` (4 subsequent siblings) 6 siblings, 1 reply; 13+ messages in thread From: Ruan Jinjie @ 2023-08-04 3:53 UTC (permalink / raw) To: sgoutham, davem, edumazet, kuba, pabeni, jesse.brandeburg, anthony.l.nguyen, tariqt, s.shtylyov, aspriel, franky.lin, hante.meuleman, kvalo, richardcochran, yoshihiro.shimoda.uh, ruanjinjie, u.kleine-koenig, mkl, lee, set_pte_at, linux-arm-kernel, netdev, intel-wired-lan, linux-rdma, linux-renesas-soc, linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list Ther are a little ternary operators, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +- drivers/net/ethernet/intel/igc/igc_phy.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c index a018000f7db9..c123c9dd6a49 100644 --- a/drivers/net/ethernet/intel/igb/e1000_phy.c +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c @@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations, udelay(usec_interval); } - *success = (i < iterations) ? true : false; + *success = i < iterations; return ret_val; } diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c index 53b77c969c85..a553e9d719e7 100644 --- a/drivers/net/ethernet/intel/igc/igc_phy.c +++ b/drivers/net/ethernet/intel/igc/igc_phy.c @@ -93,7 +93,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations, udelay(usec_interval); } - *success = (i < iterations) ? true : false; + *success = i < iterations; return ret_val; } -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH -next 2/6] ethernet/intel: Remove unnecessary ternary operators 2023-08-04 3:53 ` [PATCH -next 2/6] ethernet/intel: " Ruan Jinjie @ 2023-08-07 17:35 ` Jacob Keller 0 siblings, 0 replies; 13+ messages in thread From: Jacob Keller @ 2023-08-07 17:35 UTC (permalink / raw) To: Ruan Jinjie, sgoutham, davem, edumazet, kuba, pabeni, jesse.brandeburg, anthony.l.nguyen, tariqt, s.shtylyov, aspriel, franky.lin, hante.meuleman, kvalo, richardcochran, yoshihiro.shimoda.uh, u.kleine-koenig, mkl, lee, set_pte_at, linux-arm-kernel, netdev, intel-wired-lan, linux-rdma, linux-renesas-soc, linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list On 8/3/2023 8:53 PM, Ruan Jinjie wrote: > Ther are a little ternary operators, the true or false judgement > of which is unnecessary in C language semantics. > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> > --- > drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +- > drivers/net/ethernet/intel/igc/igc_phy.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c > index a018000f7db9..c123c9dd6a49 100644 > --- a/drivers/net/ethernet/intel/igb/e1000_phy.c > +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c > @@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations, > udelay(usec_interval); > } > > - *success = (i < iterations) ? true : false; > + *success = i < iterations; > > return ret_val; > } > diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c > index 53b77c969c85..a553e9d719e7 100644 > --- a/drivers/net/ethernet/intel/igc/igc_phy.c > +++ b/drivers/net/ethernet/intel/igc/igc_phy.c > @@ -93,7 +93,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations, > udelay(usec_interval); > } > > - *success = (i < iterations) ? true : false; > + *success = i < iterations; > > return ret_val; > } Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator 2023-08-04 3:53 [PATCH -next 0/6] net: Remove unnecessary ternary operators Ruan Jinjie 2023-08-04 3:53 ` [PATCH -next 1/6] net: thunderx: " Ruan Jinjie 2023-08-04 3:53 ` [PATCH -next 2/6] ethernet/intel: " Ruan Jinjie @ 2023-08-04 3:53 ` Ruan Jinjie [not found] ` <fd3e9bb40d12421caaddda7279aece7a@realtek.com> 2023-08-04 3:53 ` [PATCH -next 4/6] net: ethernet: renesas: rswitch: " Ruan Jinjie ` (3 subsequent siblings) 6 siblings, 1 reply; 13+ messages in thread From: Ruan Jinjie @ 2023-08-04 3:53 UTC (permalink / raw) To: sgoutham, davem, edumazet, kuba, pabeni, jesse.brandeburg, anthony.l.nguyen, tariqt, s.shtylyov, aspriel, franky.lin, hante.meuleman, kvalo, richardcochran, yoshihiro.shimoda.uh, ruanjinjie, u.kleine-koenig, mkl, lee, set_pte_at, linux-arm-kernel, netdev, intel-wired-lan, linux-rdma, linux-renesas-soc, linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list There is a ternary operator, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/net/ethernet/mellanox/mlx4/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c index 256a06b3c096..1c289488d050 100644 --- a/drivers/net/ethernet/mellanox/mlx4/port.c +++ b/drivers/net/ethernet/mellanox/mlx4/port.c @@ -176,7 +176,7 @@ static bool mlx4_need_mf_bond(struct mlx4_dev *dev) mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH) ++num_eth_ports; - return (num_eth_ports == 2) ? true : false; + return num_eth_ports == 2; } int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac) -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <fd3e9bb40d12421caaddda7279aece7a@realtek.com>]
* Re: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator [not found] ` <fd3e9bb40d12421caaddda7279aece7a@realtek.com> @ 2023-08-07 5:00 ` Ruan Jinjie 0 siblings, 0 replies; 13+ messages in thread From: Ruan Jinjie @ 2023-08-07 5:00 UTC (permalink / raw) To: Ping-Ke Shih, sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, tariqt@nvidia.com, s.shtylyov@omp.ru, aspriel@gmail.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, kvalo@kernel.org, richardcochran@gmail.com, yoshihiro.shimoda.uh@renesas.com, u.kleine-koenig@pengutronix.de, mkl@pengutronix.de, lee@kernel.org, set_pte_at@outlook.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com On 2023/8/7 9:41, Ping-Ke Shih wrote: > > >> -----Original Message----- >> From: Ruan Jinjie <ruanjinjie@huawei.com> >> Sent: Friday, August 4, 2023 11:54 AM >> To: sgoutham@marvell.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >> jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; tariqt@nvidia.com; s.shtylyov@omp.ru; >> aspriel@gmail.com; franky.lin@broadcom.com; hante.meuleman@broadcom.com; kvalo@kernel.org; >> richardcochran@gmail.com; yoshihiro.shimoda.uh@renesas.com; ruanjinjie@huawei.com; >> u.kleine-koenig@pengutronix.de; mkl@pengutronix.de; lee@kernel.org; set_pte_at@outlook.com; >> linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; >> linux-rdma@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-wireless@vger.kernel.org; >> brcm80211-dev-list.pdl@broadcom.com; SHA-cyfmac-dev-list@infineon.com >> Subject: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator >> >> There is a ternary operator, the true or false judgement >> of which is unnecessary in C language semantics. >> >> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> >> --- >> drivers/net/ethernet/mellanox/mlx4/port.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c >> index 256a06b3c096..1c289488d050 100644 >> --- a/drivers/net/ethernet/mellanox/mlx4/port.c >> +++ b/drivers/net/ethernet/mellanox/mlx4/port.c >> @@ -176,7 +176,7 @@ static bool mlx4_need_mf_bond(struct mlx4_dev *dev) >> mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH) >> ++num_eth_ports; >> >> - return (num_eth_ports == 2) ? true : false; >> + return num_eth_ports == 2; > > It should be one space between '=' and '2'. Thank you! I'll improve it sooner. > >> } >> >> int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac) >> -- >> 2.34.1 >> >> >> ------Please consider the environment before printing this e-mail. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH -next 4/6] net: ethernet: renesas: rswitch: Remove an unnecessary ternary operator 2023-08-04 3:53 [PATCH -next 0/6] net: Remove unnecessary ternary operators Ruan Jinjie ` (2 preceding siblings ...) 2023-08-04 3:53 ` [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator Ruan Jinjie @ 2023-08-04 3:53 ` Ruan Jinjie 2023-08-04 3:53 ` [PATCH -next 5/6] net: fjes: " Ruan Jinjie ` (2 subsequent siblings) 6 siblings, 0 replies; 13+ messages in thread From: Ruan Jinjie @ 2023-08-04 3:53 UTC (permalink / raw) To: sgoutham, davem, edumazet, kuba, pabeni, jesse.brandeburg, anthony.l.nguyen, tariqt, s.shtylyov, aspriel, franky.lin, hante.meuleman, kvalo, richardcochran, yoshihiro.shimoda.uh, ruanjinjie, u.kleine-koenig, mkl, lee, set_pte_at, linux-arm-kernel, netdev, intel-wired-lan, linux-rdma, linux-renesas-soc, linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list There is a ternary operator, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c index c007e33c47e1..37f7359678e5 100644 --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c @@ -29,7 +29,7 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = { static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) { struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp); - bool neg_adj = scaled_ppm < 0 ? true : false; + bool neg_adj = scaled_ppm < 0; s64 addend = ptp_priv->default_addend; s64 diff; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH -next 5/6] net: fjes: Remove an unnecessary ternary operator 2023-08-04 3:53 [PATCH -next 0/6] net: Remove unnecessary ternary operators Ruan Jinjie ` (3 preceding siblings ...) 2023-08-04 3:53 ` [PATCH -next 4/6] net: ethernet: renesas: rswitch: " Ruan Jinjie @ 2023-08-04 3:53 ` Ruan Jinjie 2023-08-04 3:53 ` [PATCH -next 6/6] brcm80211: " Ruan Jinjie 2023-08-04 20:17 ` [PATCH -next 0/6] net: Remove unnecessary ternary operators Jakub Kicinski 6 siblings, 0 replies; 13+ messages in thread From: Ruan Jinjie @ 2023-08-04 3:53 UTC (permalink / raw) To: sgoutham, davem, edumazet, kuba, pabeni, jesse.brandeburg, anthony.l.nguyen, tariqt, s.shtylyov, aspriel, franky.lin, hante.meuleman, kvalo, richardcochran, yoshihiro.shimoda.uh, ruanjinjie, u.kleine-koenig, mkl, lee, set_pte_at, linux-arm-kernel, netdev, intel-wired-lan, linux-rdma, linux-renesas-soc, linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list There is a ternary operator, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/net/fjes/fjes_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 2513be6d4e11..a0d915d1dbed 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -612,7 +612,7 @@ fjes_xmit_frame(struct sk_buff *skb, struct net_device *netdev) eth = (struct ethhdr *)skb->data; my_epid = hw->my_epid; - vlan = (vlan_get_tag(skb, &vlan_id) == 0) ? true : false; + vlan = vlan_get_tag(skb, &vlan_id) == 0; data = skb->data; len = skb->len; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH -next 6/6] brcm80211: Remove an unnecessary ternary operator 2023-08-04 3:53 [PATCH -next 0/6] net: Remove unnecessary ternary operators Ruan Jinjie ` (4 preceding siblings ...) 2023-08-04 3:53 ` [PATCH -next 5/6] net: fjes: " Ruan Jinjie @ 2023-08-04 3:53 ` Ruan Jinjie [not found] ` <f72991b36d6a449ea5cf476d438bcd1d@realtek.com> 2023-08-04 20:17 ` [PATCH -next 0/6] net: Remove unnecessary ternary operators Jakub Kicinski 6 siblings, 1 reply; 13+ messages in thread From: Ruan Jinjie @ 2023-08-04 3:53 UTC (permalink / raw) To: sgoutham, davem, edumazet, kuba, pabeni, jesse.brandeburg, anthony.l.nguyen, tariqt, s.shtylyov, aspriel, franky.lin, hante.meuleman, kvalo, richardcochran, yoshihiro.shimoda.uh, ruanjinjie, u.kleine-koenig, mkl, lee, set_pte_at, linux-arm-kernel, netdev, intel-wired-lan, linux-rdma, linux-renesas-soc, linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list There is a ternary operator, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c index 8580a2754789..8328b22829c5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c @@ -27351,8 +27351,7 @@ static int wlc_phy_cal_rxiq_nphy_rev3(struct brcms_phy *pi, for (rx_core = 0; rx_core < pi->pubpi.phy_corenum; rx_core++) { - skip_rxiqcal = - ((rxcore_state & (1 << rx_core)) == 0) ? true : false; + skip_rxiqcal = (rxcore_state & (1 << rx_core)) == 0; wlc_phy_rxcal_physetup_nphy(pi, rx_core); -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <f72991b36d6a449ea5cf476d438bcd1d@realtek.com>]
* Re: [PATCH -next 6/6] brcm80211: Remove an unnecessary ternary operator [not found] ` <f72991b36d6a449ea5cf476d438bcd1d@realtek.com> @ 2023-08-07 5:00 ` Ruan Jinjie 0 siblings, 0 replies; 13+ messages in thread From: Ruan Jinjie @ 2023-08-07 5:00 UTC (permalink / raw) To: Ping-Ke Shih, sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, tariqt@nvidia.com, s.shtylyov@omp.ru, aspriel@gmail.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, kvalo@kernel.org, richardcochran@gmail.com, yoshihiro.shimoda.uh@renesas.com, u.kleine-koenig@pengutronix.de, mkl@pengutronix.de, lee@kernel.org, set_pte_at@outlook.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com On 2023/8/7 9:42, Ping-Ke Shih wrote: > > >> -----Original Message----- >> From: Ruan Jinjie <ruanjinjie@huawei.com> >> Sent: Friday, August 4, 2023 11:54 AM >> To: sgoutham@marvell.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >> jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; tariqt@nvidia.com; s.shtylyov@omp.ru; >> aspriel@gmail.com; franky.lin@broadcom.com; hante.meuleman@broadcom.com; kvalo@kernel.org; >> richardcochran@gmail.com; yoshihiro.shimoda.uh@renesas.com; ruanjinjie@huawei.com; >> u.kleine-koenig@pengutronix.de; mkl@pengutronix.de; lee@kernel.org; set_pte_at@outlook.com; >> linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; >> linux-rdma@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-wireless@vger.kernel.org; >> brcm80211-dev-list.pdl@broadcom.com; SHA-cyfmac-dev-list@infineon.com >> Subject: [PATCH -next 6/6] brcm80211: Remove an unnecessary ternary operator >> >> There is a ternary operator, the true or false judgement of which >> is unnecessary in C language semantics. >> >> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> index 8580a2754789..8328b22829c5 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c >> @@ -27351,8 +27351,7 @@ static int wlc_phy_cal_rxiq_nphy_rev3(struct brcms_phy *pi, >> >> for (rx_core = 0; rx_core < pi->pubpi.phy_corenum; rx_core++) { >> >> - skip_rxiqcal = >> - ((rxcore_state & (1 << rx_core)) == 0) ? true : false; >> + skip_rxiqcal = (rxcore_state & (1 << rx_core)) == 0; > > skip_rxiqcal = !(rxcore_state & (1 << rx_core)); Thank you! I'll improve it sooner. > >> >> wlc_phy_rxcal_physetup_nphy(pi, rx_core); >> >> -- >> 2.34.1 >> >> >> ------Please consider the environment before printing this e-mail. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH -next 0/6] net: Remove unnecessary ternary operators 2023-08-04 3:53 [PATCH -next 0/6] net: Remove unnecessary ternary operators Ruan Jinjie ` (5 preceding siblings ...) 2023-08-04 3:53 ` [PATCH -next 6/6] brcm80211: " Ruan Jinjie @ 2023-08-04 20:17 ` Jakub Kicinski 6 siblings, 0 replies; 13+ messages in thread From: Jakub Kicinski @ 2023-08-04 20:17 UTC (permalink / raw) To: Ruan Jinjie Cc: sgoutham, davem, edumazet, pabeni, jesse.brandeburg, anthony.l.nguyen, tariqt, s.shtylyov, aspriel, franky.lin, hante.meuleman, kvalo, richardcochran, yoshihiro.shimoda.uh, u.kleine-koenig, mkl, lee, set_pte_at, linux-arm-kernel, netdev, intel-wired-lan, linux-rdma, linux-renesas-soc, linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list On Fri, 4 Aug 2023 11:53:40 +0800 Ruan Jinjie wrote: > There are a little ternary operators, the true or false judgement > of which is unnecessary in C language semantics. Who cares. Please stop sending these trivial cleanups to networking core and drivers. -- pw-bot: reject _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-08-07 17:36 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-04 3:53 [PATCH -next 0/6] net: Remove unnecessary ternary operators Ruan Jinjie
2023-08-04 3:53 ` [PATCH -next 1/6] net: thunderx: " Ruan Jinjie
[not found] ` <15759f98483947999393a25b857bc4fe@realtek.com>
2023-08-07 4:59 ` Ruan Jinjie
2023-08-07 17:34 ` Jacob Keller
2023-08-04 3:53 ` [PATCH -next 2/6] ethernet/intel: " Ruan Jinjie
2023-08-07 17:35 ` Jacob Keller
2023-08-04 3:53 ` [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator Ruan Jinjie
[not found] ` <fd3e9bb40d12421caaddda7279aece7a@realtek.com>
2023-08-07 5:00 ` Ruan Jinjie
2023-08-04 3:53 ` [PATCH -next 4/6] net: ethernet: renesas: rswitch: " Ruan Jinjie
2023-08-04 3:53 ` [PATCH -next 5/6] net: fjes: " Ruan Jinjie
2023-08-04 3:53 ` [PATCH -next 6/6] brcm80211: " Ruan Jinjie
[not found] ` <f72991b36d6a449ea5cf476d438bcd1d@realtek.com>
2023-08-07 5:00 ` Ruan Jinjie
2023-08-04 20:17 ` [PATCH -next 0/6] net: Remove unnecessary ternary operators Jakub Kicinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).