From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37B9BC001DE for ; Fri, 4 Aug 2023 17:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A824kKO70z+QB0DUwJa4sD418iJU4wOEbyVDUEVhOaQ=; b=IxIeh6KN/1Mn68 V41nhP7BALsmWVcyGWIR72vE9ZoD4lN3kZjZyQiHkWuTOYaXP0ilr2SzokDI117rcWYJo/J76TdSr MhN9hrSsK2fQXUP7AGP6yx13ZCglgMfJL+6h2DQuDXgjeirXotIHvk0tU/lRN6yauILtRJ3x0KtUT qs7o7Q+JFvEGpdmGTytv3YUHUWIxV4XhY5vZ7wYviqR1l1YY3JaBtgjHG7rOaKh3Wj9+J6kPIGZbo rS8sr+APM/Z8lIREuRvGHhdzWbtjEdKJlKpwcOgp/TmqeWJxvMivpj7HPii0x07q4VRIDdqHSw1JT fLFL64uQ9AZ2xhI5VsLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRz4x-00Cwbu-0A; Fri, 04 Aug 2023 17:59:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRz4u-00Cwb9-0U for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 17:59:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 98C3A620BC; Fri, 4 Aug 2023 17:59:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58A00C433CA; Fri, 4 Aug 2023 17:59:04 +0000 (UTC) Date: Fri, 4 Aug 2023 13:59:02 -0400 From: Steven Rostedt To: Marco Elver Cc: Andrew Morton , Kees Cook , Guenter Roeck , Peter Zijlstra , Mark Rutland , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Nathan Chancellor , Nick Desaulniers , Tom Rix , Miguel Ojeda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Dmitry Vyukov , Alexander Potapenko , kasan-dev@googlegroups.com, linux-toolchains@vger.kernel.org Subject: Re: [PATCH v2 2/3] list_debug: Introduce inline wrappers for debug checks Message-ID: <20230804135902.7925ebb6@gandalf.local.home> In-Reply-To: <20230804135757.400eab72@gandalf.local.home> References: <20230804090621.400-1-elver@google.com> <20230804090621.400-2-elver@google.com> <20230804120308.253c5521@gandalf.local.home> <20230804135757.400eab72@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230804_105908_254960_4E3B451C X-CRM114-Status: GOOD ( 15.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 4 Aug 2023 13:57:57 -0400 Steven Rostedt wrote: > On Fri, 4 Aug 2023 19:49:48 +0200 > Marco Elver wrote: > > > > I've been guilty of this madness myself, but I have learned the errors of > > > my ways, and have been avoiding doing so in any new code I write. > > > > That's fair. We can call them __list_*_valid() (inline), and > > __list_*_valid_or_report() ? > > __list_*_valid_check() ? > I have to admit, I think the main reason kernel developers default to using these useless underscores is because kernel developers are notoriously lousy at naming. ;-) -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel