From: Andi Shyti <andi.shyti@kernel.org>
To: Liao Chang <liaochang1@huawei.com>
Cc: florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, rjui@broadcom.com,
sbranden@broadcom.com, yangyicong@hisilicon.com,
aisheng.dong@nxp.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com,
asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org,
ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 9/9] i2c: synquacer: Use dev_err_probe in probe function
Date: Sat, 5 Aug 2023 00:18:24 +0200 [thread overview]
Message-ID: <20230804221824.6ajx25lmymf3hcfd@intel.intel> (raw)
In-Reply-To: <20230802095737.3957587-10-liaochang1@huawei.com>
On Wed, Aug 02, 2023 at 05:57:37PM +0800, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.
>
> Signed-off-by: Liao Chang <liaochang1@huawei.com>
> ---
> drivers/i2c/busses/i2c-synquacer.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-synquacer.c b/drivers/i2c/busses/i2c-synquacer.c
> index 4cc196ca8f6d..8ada613598eb 100644
> --- a/drivers/i2c/busses/i2c-synquacer.c
> +++ b/drivers/i2c/busses/i2c-synquacer.c
> @@ -557,11 +557,8 @@ static int synquacer_i2c_probe(struct platform_device *pdev)
> dev_dbg(&pdev->dev, "clock source %p\n", i2c->pclk);
>
> ret = clk_prepare_enable(i2c->pclk);
> - if (ret) {
> - dev_err(&pdev->dev, "failed to enable clock (%d)\n",
> - ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "failed to enable clock\n");
> i2c->pclkrate = clk_get_rate(i2c->pclk);
> }
>
you forgot
dev_err(&pdev->dev, "PCLK missing or out of range (%d)\n",
i2c->pclkrate);
return -EINVAL;
Thanks,
Andi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-04 22:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 9:57 [PATCH v2 0/9] Use dev_err_probe in i2c probe function Liao Chang
2023-08-02 9:57 ` [PATCH 1/9] i2c: bcm2835: Use dev_err_probe in " Liao Chang
2023-08-08 8:55 ` Markus Elfring
2023-08-02 9:57 ` [PATCH 2/9] i2c: mlxbf: " Liao Chang
2023-08-04 22:11 ` Andi Shyti
2023-08-02 9:57 ` [PATCH 3/9] i2c: xlp9xx: " Liao Chang
2023-08-02 9:57 ` [PATCH 4/9] i2c: hisi: " Liao Chang
2023-08-02 9:57 ` [PATCH 5/9] i2c: qcom-cci: " Liao Chang
2023-08-02 9:57 ` [PATCH 6/9] i2c: pxa: " Liao Chang
2023-08-02 9:57 ` [PATCH 7/9] i2c: dln2: " Liao Chang
2023-08-02 9:57 ` [PATCH 8/9] i2c: imx-lpi2c: " Liao Chang
2023-08-04 22:16 ` Andi Shyti
2023-08-07 2:13 ` Liao, Chang
2023-08-07 8:17 ` Andi Shyti
2023-08-07 10:44 ` Liao, Chang
2023-08-07 11:55 ` Andi Shyti
2023-08-08 1:27 ` Liao, Chang
2023-08-02 9:57 ` [PATCH 9/9] i2c: synquacer: " Liao Chang
2023-08-04 22:18 ` Andi Shyti [this message]
2023-08-04 22:19 ` [PATCH v2 0/9] Use dev_err_probe in i2c " Andi Shyti
2023-08-07 2:13 ` Liao, Chang
-- strict thread matches above, loose matches on Subject: below --
2023-07-28 1:31 [PATCH " Liao Chang
2023-07-28 1:31 ` [PATCH 9/9] i2c: synquacer: Use dev_err_probe in " Liao Chang
2023-08-01 21:44 ` Andi Shyti
2023-08-02 7:03 ` Liao, Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804221824.6ajx25lmymf3hcfd@intel.intel \
--to=andi.shyti@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=ardb@kernel.org \
--cc=asmaa@nvidia.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=gcherian@marvell.com \
--cc=kblaiech@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=liaochang1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=loic.poulain@linaro.org \
--cc=rfoss@kernel.org \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).