From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 991A8C00528 for ; Fri, 4 Aug 2023 22:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QLp2WK7Pmvj0hlVcrRlFm5Z+r4yzj/ya7B0l/7y9JFw=; b=4++kjEbnMHdeYQ lEHDwopXIdgGl/pQKobRDOmfgPug6MNFoOyPM5WCKJC/sfNDvLztw50eZD9g2hBEw5VzdTgnXK4ep 780OuwbiI359xM2FJPDehjlLrXBWliipQk3XRL2xA37rJClkoN6Qz2oVUpFTh5Hq09Xxr2GBy9GWL qf4h57ovU31FnIdX7JvMuDyeDBA6R9I++LoFXE6EWdYcW45L1bts1C4dif+VzdJQVSOxhuO0HFgOY 7t7bx9D0PgHQufCzJJ8aLYsFLdsdZ3xLG3HEvC3LWdxoj6eaYx0y6m8NHtwVVHwXN+039r9z32JEJ MEnsE8IWxT208WfZvesw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qS39O-00DLnQ-1W; Fri, 04 Aug 2023 22:20:02 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qS39L-00DLmT-2e; Fri, 04 Aug 2023 22:20:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1264B62137; Fri, 4 Aug 2023 22:19:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AE8DC433C9; Fri, 4 Aug 2023 22:19:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691187596; bh=z5y0QGbwW3t6c+KvgHhK01t3+a50rXiFmEyHxyMH768=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f7TlsmmYvq4OwzvmJyHvFwcp4maUE68qA5QsUJmzMSmB61oNt7PibOWgEa2SYK98Z distQc0VD89RDJd/7LLa0lBmYHWSK3n/oF3tDORAmJHMjb9Z/AbRpoudUJCORXroy3 yy8jHE/43Y2lVjzdegelN+3w7VlAxgC3edcWfWhCzISPfAbDsC1cNRJbxSailL5sAh BxnlXs695ataZ6wrecHYStFjL5aA79iBmzfUxEqT1ap2DqKoObzIkV7LKgvbFBNRmd ioL0i4rHrc72nQw/gNzv8843HP1tLDYSDiBIyw8FNX12ArW8wG4PA771mkEwS6sWRo WMqDicmeTiRIg== Date: Sat, 5 Aug 2023 00:19:53 +0200 From: Andi Shyti To: Liao Chang Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 0/9] Use dev_err_probe in i2c probe function Message-ID: <20230804221953.abmpboxdzy2upswe@intel.intel> References: <20230802095737.3957587-1-liaochang1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230802095737.3957587-1-liaochang1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230804_151959_905408_9CDB5E83 X-CRM114-Status: GOOD ( 10.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Liao, On Wed, Aug 02, 2023 at 05:57:28PM +0800, Liao Chang wrote: > Use the dev_err_probe function instead of dev_err in the probe function > so that the printed messge includes the return value and also handles > -EPROBE_DEFER nicely. first of all thanks for this cleanup which is very much appreciated! I need to ask you to add the version to all the patches, not just patch 0/9. It's trivial if you do "git format-patch -v 2...". Thanks, Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel