From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E9AEC0015E for ; Sat, 5 Aug 2023 17:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DMh1qqs/OATVkCzxXuQAAudtMOi5O2UvHqgIDlpUiuw=; b=YE9fGaF3JrFKC/ 5rpZATBOSOyx+N9PhXmCDbILi7CkOeVSRcmwD1lybhn4kCnhfpylB2tTOY8S09pp2Bjw86PjMa+Cb WY2T5txnrv9Z+fgbA1EcmgyILR/cbohsR/fGAhbRygIA1ikn4ZpLF5WW3NmMrrjEddp2+YNzO2A56 dNrlzTHv/r3TY8Ry9fbHeJ2At5jnOIGSYf1UL+V8dnxoDRkLl9SH9ZyFsO8LpJYYokHKJ4uAKOyBN cJSaR4tsqkcqoGbfyMKATKWmwoGp/phMD9QzYEOHtetgGUhKgnwSwZhEXEodRRoH2PPbomExaMLgZ g3/eQW46pG0StYeFLA2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSKs4-00ENY7-1N; Sat, 05 Aug 2023 17:15:20 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSKs0-00ENXe-3D for linux-arm-kernel@lists.infradead.org; Sat, 05 Aug 2023 17:15:19 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 375HF934093337; Sat, 5 Aug 2023 12:15:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691255709; bh=EScFImeXpCeHeumWjkkLDl7mHRhAqEj9tr3yBKEd7rU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=aO1MTkog61RI7+kD/UottjJj18ouSB4vYlRLyNSGloB9uUBGJ7y+EBNQJ6D1xFVyZ IHjUHEweJDbgkeFWGomF/0F+INqE/KCImbskcXTR8KuT2QwsdjSOKqZUyUVcTCCbIs 0c+qpbcQEAYJcJLtYgBDDX8GplxmQjSVnfw0vk6Q= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 375HF95u095136 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 5 Aug 2023 12:15:09 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Sat, 5 Aug 2023 12:15:09 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Sat, 5 Aug 2023 12:15:08 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 375HF86h035194; Sat, 5 Aug 2023 12:15:08 -0500 Date: Sat, 5 Aug 2023 12:15:08 -0500 From: Nishanth Menon To: Dhruva Gole CC: Tony Lindgren , Linus Walleij , , , , , Vignesh Raghavendra Subject: Re: [PATCH] pinctrl: single: Add compatible for ti,am625-padconf Message-ID: <20230805171508.schg4xquoa24klk5@october> References: <20230805045554.786092-1-d-gole@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230805045554.786092-1-d-gole@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230805_101517_142173_AD8F53BB X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10:25-20230805, Dhruva Gole wrote: > From: Tony Lindgren > > Add compatible for ti,am625-padconf to enable the use of wake-up events. > > Signed-off-by: Tony Lindgren > Signed-off-by: Dhruva Gole > --- > > Base: > ***** > tag: next-20230731 + below "depends on" patches > > Depends on: > *********** > [0] Update pinctrl-single to use yaml > [1] dt-binding: pinctrl-single: add am625 compatible > > Links: > ****** > [0] https://lore.kernel.org/linux-omap/20230731061908.GG5194@atomide.com/T/ > [1] https://lore.kernel.org/all/20230804050737.635186-1-d-gole@ti.com/ > > Cc: Nishanth Menon > Cc: Vignesh Raghavendra > > Link to this patch: > ****************** > https://lore.kernel.org/all/20230805045554.786092-1-d-gole@ti.com > > drivers/pinctrl/pinctrl-single.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c > index f056923ecc98..3a2a9910f2ec 100644 > --- a/drivers/pinctrl/pinctrl-single.c > +++ b/drivers/pinctrl/pinctrl-single.c > @@ -1954,6 +1954,12 @@ static const struct pcs_soc_data pinctrl_single_am437x = { > .irq_status_mask = (1 << 30), /* OMAP_WAKEUP_EVENT */ > }; > > +static const struct pcs_soc_data pinctrl_single_am625 = { > + .flags = PCS_QUIRK_SHARED_IRQ | PCS_CONTEXT_LOSS_OFF, > + .irq_enable_mask = (1 << 29), /* WKUP_EN */ > + .irq_status_mask = (1 << 30), /* WKUP_EVT */ > +}; > + Why cant we set this in the k3-pinctrl.h and set it once? The event will not be generated until wakeup daisy chain is triggered anyways. Have you looked at all the padconf registers across devices to ensure the WKUP_EN/EVT bits are present? daisy chain feature is used elsewhere as well. > static const struct pcs_soc_data pinctrl_single = { > }; > > @@ -1962,6 +1968,7 @@ static const struct pcs_soc_data pinconf_single = { > }; > > static const struct of_device_id pcs_of_match[] = { > + { .compatible = "ti,am625-padconf", .data = &pinctrl_single_am625 }, > { .compatible = "ti,omap3-padconf", .data = &pinctrl_single_omap_wkup }, > { .compatible = "ti,omap4-padconf", .data = &pinctrl_single_omap_wkup }, > { .compatible = "ti,omap5-padconf", .data = &pinctrl_single_omap_wkup }, > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel