From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 695E8C001DE for ; Sat, 5 Aug 2023 19:34:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TP4bhoDnyzt3255dtPUb0BhnPipGThGeReT1vuSOL7M=; b=Y4YEcxszt3vuCZ DXcNKoYm1Gyj0CcQsnUlq8lqMce3/emNKHMD+1sTPJ8ghXCa265fEy+LDTIM82OJhDh7OHqvWKHc3 u3Ncb63dCD5ktasPDIqbLL7pXx83LnHYb43yg/0axTpWrAIk7KnAFPrsG4VDtNGCiHLhf8P/sqTd2 r06WEONfK5j43bWzpkZGGHUq0mpWCNQKseNQkU3U+lz4pn50T3PtbAQyfsnlTnVnxGylfOH/zMpI6 xHTSRkKzZmS/47UbxbIJEVjAfaFE0vzBDENtKBQZZUpUHUUYuunO7qA4VTFPJ+l8e0F6oE3Yk5M1h JOCKiid8RPfYwxDEyD4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSN2T-00EUvq-1j; Sat, 05 Aug 2023 19:34:13 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSN2P-00EUvQ-1P for linux-arm-kernel@lists.infradead.org; Sat, 05 Aug 2023 19:34:11 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 375JXuWE053982; Sat, 5 Aug 2023 14:33:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691264036; bh=ywGf2VNoOdqAsNkHO77gnWJr1RqaF8o7AFI63z26nj8=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=YtrE2N3QmtSL2poYFvurWUJonYkeIETqbk6dYSzfB9zr4kOAA8UqV+sD4mrgn40ko ZRvUJRwGb7+nwTu1+NOBFSbMU8CVxe5WAkZG1BCqeaCselDJNAfRb+b9V3Pnrlgm67 vtuU4HVsoHIyEYP0s2NBBkljrE/oN0LtSRpvZrJk= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 375JXuYU012469 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 5 Aug 2023 14:33:56 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Sat, 5 Aug 2023 14:33:55 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Sat, 5 Aug 2023 14:33:55 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 375JXtUa003708; Sat, 5 Aug 2023 14:33:55 -0500 Date: Sat, 5 Aug 2023 14:33:55 -0500 From: Nishanth Menon To: Devarsh Thakkar , CC: , , , , , , , , , , , Subject: Re: [PATCH] arm64: dts: ti: k3-am62x-sk-common: Reserve 128MiB of global CMA Message-ID: <20230805193355.o657pwbq2w3tciui@vehicular> References: <20230803111455.811339-1-devarsht@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230803111455.811339-1-devarsht@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230805_123409_643593_A689A5D6 X-CRM114-Status: GOOD ( 21.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:44-20230803, Devarsh Thakkar wrote: > Reserve 128MiB of global CMA which is also marked as re-usable > so that OS can also use the same if peripheral drivers are not using the > same. > > AM62x supports multimedia components such as GPU, dual Display and Camera. > Assuming the worst-case scenario where all 3 are run in parallel below > is the calculation : > > 1) OV5640 camera sensor supports 1920x1080 resolution > -> 1920 width x 1080 height x 2 bytesperpixel x 8 buffers > (default in yavta) : 32MiB > > 2) 1920x1200 Microtips LVDS panel supported > -> 1920 width x 1080 height x 4 bytesperpixel x 2 buffers : > 16 MiB > > 3) 1920x1080 HDMI display supported > -> 1920 width x 1080 height x 4 bytesperpixel x 2 buffers : > 15.82 MiB which is ~16 MiB > > 4) IMG GPU shares with display allocated buffers while rendering > but in case some dedicated operation viz color conversion, > keeping same window of ~16 MiB for GPU too. > > Total is 80 MiB and adding 32 MiB for other peripherals and extra > 16 MiB to keep as buffer for fragmentation thus rounding total to 128 > MiB. > > Signed-off-by: Devarsh Thakkar > Acked-by: Darren Etheridge > Signed-off-by: Vignesh Raghavendra > --- I don't think this is right approach. There are other techniques than having to do this (Andrew: please comment) and require drivers to behave properly. I am esp concerned since there are platforms based on am62x and just 256MB DDR. > arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi > index 34c8ffc553ec..9dd6e23ca9ca 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi > @@ -47,6 +47,14 @@ ramoops@9ca00000 { > pmsg-size = <0x8000>; > }; > > + /* global cma region */ > + linux,cma { > + compatible = "shared-dma-pool"; > + reusable; > + size = <0x00 0x8000000>; > + linux,cma-default; > + }; > + > secure_tfa_ddr: tfa@9e780000 { > reg = <0x00 0x9e780000 0x00 0x80000>; > alignment = <0x1000>; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel