From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F018C001DB for ; Sat, 5 Aug 2023 21:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bRXIHYhVtY5Ygr0v00ueCw/zVnJvQNph4iL6jv4ioxs=; b=uATYuLSWc2b0q3 J4Sy+DgOTW8KRhZ19WevBO+fpzHZ/vS+y8qVTYlRodQdrHbSR++I/gVrXQ5KK/ngjFB0Vu9M+afXZ vAGE/9fl1afVSp73fXNJ9o6HaAJIf14VRhlnKqfnh+DALT18/Eii49exA5jDiVCYv1wdfqJhlW1va Vdhi0RHf6Tkzf6jVBXibXrq9x47zTuNXohlWGFsr2t99DKz3KDAVEfDm3vcC5ccOYeS5wbXn7b8pB 62yvYBqlYiunqHALNG5Rf9IR+35vFpcqdCVbps69LSyftI6hjLSko32Q5IqVWIhW6ftWdF3fSCDjk HjncRDPOTvwvfpgzzU+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSOym-00EaqO-0E; Sat, 05 Aug 2023 21:38:32 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSOyj-00Eaq1-1s for linux-arm-kernel@lists.infradead.org; Sat, 05 Aug 2023 21:38:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2811A60EAB; Sat, 5 Aug 2023 21:38:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EADFC433C8; Sat, 5 Aug 2023 21:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691271507; bh=S420Jp3noijPO33VAPxKsjX9jKoQBlgGUHnNfSpqMTo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RsSSWjPLh02PC/C3W5pntdrkUWEFyfpnspeDV2c5Su5REmVuEyfbbhMRMXQIFTGO2 i1VBoKbrXlCVjxJwPleQs4xQ+OcCN/4OZHThxrcqc0Upu1Sao8Ie6RoanBIu0tRYI6 wCu5KK7Ynow7VWUlvAvcdEJTaNcFuXDLsORQ3Cc4OS4sN9WiWxnx01Jxz6+KOz/tgR uNqxfnpridRqtI6/U2VbZRyz+ElUm5OCyeyOalZSJZEsznSmG1bTLj32kMPi6FooFh fNXHyw2QIr4I1K+Zj1ce1wrAGpbTmmb1o5d5q9aij2OnwYI3/OgkEFsmbOghl6I3kL DxDnRixaumX7A== Date: Sat, 5 Aug 2023 23:38:24 +0200 From: Andi Shyti To: Anton Eliasson Cc: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com Subject: Re: [PATCH] tty: serial: samsung: Set missing PM ops for hibernation support Message-ID: <20230805213824.ol7sr3b52rwrsfs6@intel.intel> References: <20230803-samsung_tty_pm_ops-v1-1-1ea7be72194d@axis.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230803-samsung_tty_pm_ops-v1-1-1ea7be72194d@axis.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230805_143829_663152_C981B963 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anton, On Thu, Aug 03, 2023 at 01:26:42PM +0200, Anton Eliasson wrote: > At least freeze, restore and thaw need to be set in order for the driver > to support system hibernation. The existing suspend/resume functions can > be reused since those functions don't touch the device's power state or > wakeup capability. Use the helper macros SET_SYSTEM_SLEEP_PM_OPS and > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for symmetry with similar drivers. and why do we need hibernation in this device? Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel