From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3572C0015E for ; Sat, 5 Aug 2023 22:14:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZpvUG9zkEc7msknIkFu2sp9Z2LNuN6vlNdoNTV1dqio=; b=lWOndsL8pfwcau AIOlAGRZmPIzuy705xK16kZVXgWmEPTPjwXvwqOXRtAor3lcS4cZTWmp4eqVMmbNejXx2kf6iO5jt vtM3iEvUCKr2RIoHOmF4us61ZDlWaQn6LFoLxaOXXh9/MnKjHhcbvXvVoaSqHsjDdQeZnwSe4bsR3 rIHNjB8HcD6flESS2n8iXPezTJ/V+rHbUvgDBaGmLNP5FPjPp3zOqH5jULayQbyd8R7PzWs6Gar8N b2ztBDtEgRXZ/OL8gr5KbyPhPVb45Tc93ONAza4AjIWVloWTAAtq0DZRscFyPtymBOoy4hoHkU/S0 SVbhmNaZfDY6KvAlfYBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSPWs-00Ebsn-01; Sat, 05 Aug 2023 22:13:46 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSPWp-00Ebs3-24 for linux-arm-kernel@lists.infradead.org; Sat, 05 Aug 2023 22:13:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 44E4D60A4B; Sat, 5 Aug 2023 22:13:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5402CC433C9; Sat, 5 Aug 2023 22:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691273621; bh=Fv6xOJZuHno+soULBoFjqvGf1qqQIZ28lqSa/yaepNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cWO3s+9aPMtvvprSTvt2Q7uwb7A5V1/T1GBpjD4FemWJBT5S7hXTio62lrmiTV3UQ tNbd9kM3syKurONPvGL9ft6QrpvEKjS6Ng/vtK9lcA/HLcMRBkaqg6xFl8O57ObDt5 rU/igyl8r4co4aTgmbbuDSDTNI07hhMcX/2bT+9Cjkd62yUD66ZUBTSYn7iLAUDDd7 gPGkUkTBrHezef/Ps0qsxMsFngrCOsgRX8gmkBHymJwMkVDHmllwv7kAazHKo3jG02 4gcImQkVDVvS1x3/j50ueDfm79HeS8Lzh6NTPKk7q0zdnf6qGoIFPgKnMgME9MMtlm n8QIaElvZTxtw== Date: Sun, 6 Aug 2023 00:13:39 +0200 From: Andi Shyti To: Yue Haibing Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] i2c: s3c2410: Remove unused extern declarations Message-ID: <20230805221339.7vl3jcutustlvhgc@intel.intel> References: <20230728132318.25072-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230728132318.25072-1-yuehaibing@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230805_151343_748048_5860D453 X-CRM114-Status: UNSURE ( 9.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Yue, On Fri, Jul 28, 2023 at 09:23:18PM +0800, Yue Haibing wrote: > commit 0d297df03890 ("ARM: s3c: simplify platform code") left behind > s3c_i2c(*)_set_platdata(). > commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code") > leave s5p_i2c_hdmiphy_set_platdata() declaration. > And commit bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h") > leave s3c_i2c(*)_cfg_gpio() alone. I don't understand anything from the commit message here. How about: " After some cleanups[*] certain s3c_i2c(*)_cfg_gpio() prototypes have become unused. Remove them. [*] 0d297df03890 ("ARM: s3c: simplify platform code") d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code") bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h") " > Signed-off-by: Yue Haibing Reviewed-by: Andi Shyti which branch should this go? Samsung or i2c? Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel