* Re: [PATCH 2/2] arm64: dts: imx8mm-phyboard-polis-rdk: Remove 'fsl,spi-num-chipselects'
[not found] ` <20230726125025.295120-2-festevam@gmail.com>
@ 2023-07-27 5:26 ` Yannic Moog
2023-07-27 10:23 ` Fabio Estevam
2023-07-27 11:10 ` Yannic Moog
1 sibling, 1 reply; 4+ messages in thread
From: Yannic Moog @ 2023-07-27 5:26 UTC (permalink / raw)
To: festevam@gmail.com, shawnguo@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, festevam@denx.de,
Cem Tenruh, linux-imx@nxp.com
Hello Fabio,
On Wed, 2023-07-26 at 09:50 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The 'fsl,spi-num-chipselects' property is not a valid one, so remove
> it.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-
> rdk.dts b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> index 66a0bdaff8eb..92e62fe31929 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> @@ -143,7 +143,6 @@ can0: can@0 {
> /* TPM */
> &ecspi2 {
> cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> - fsl,spi-num-chipselects = <1>;
Is it possible or customary that you also add the property "num-cs =
<1>" as replacement or is this (generally) something where I should send
a patch to add the new node?
Yannic
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ecspi2>;
> #address-cells = <1>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] arm64: dts: imx8mm-phyboard-polis-rdk: Remove 'fsl,spi-num-chipselects'
2023-07-27 5:26 ` [PATCH 2/2] arm64: dts: imx8mm-phyboard-polis-rdk: Remove 'fsl,spi-num-chipselects' Yannic Moog
@ 2023-07-27 10:23 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-07-27 10:23 UTC (permalink / raw)
To: Yannic Moog; +Cc: festevam, shawnguo, linux-arm-kernel, Cem Tenruh, linux-imx
Hi Yannic,
On 27/07/2023 02:26, Yannic Moog wrote:
> Is it possible or customary that you also add the property "num-cs =
> <1>" as replacement or is this (generally) something where I should
> send
> a patch to add the new node?
The cs-gpios property already contains the SPI chipselect list, so the
information
about the number of the chipselect lines is taken from there.
No need to pass num-cs.
Regards,
Fabio Estevam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8mm-phyboard-polis-rdk: Remove 'fsl,spi-num-chipselects'
[not found] ` <20230726125025.295120-2-festevam@gmail.com>
2023-07-27 5:26 ` [PATCH 2/2] arm64: dts: imx8mm-phyboard-polis-rdk: Remove 'fsl,spi-num-chipselects' Yannic Moog
@ 2023-07-27 11:10 ` Yannic Moog
1 sibling, 0 replies; 4+ messages in thread
From: Yannic Moog @ 2023-07-27 11:10 UTC (permalink / raw)
To: festevam@gmail.com, shawnguo@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, festevam@denx.de,
Cem Tenruh, linux-imx@nxp.com
On Wed, 2023-07-26 at 09:50 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The 'fsl,spi-num-chipselects' property is not a valid one, so remove
> it.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Yannic Moog <y.moog@phytec.de>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-
> rdk.dts b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> index 66a0bdaff8eb..92e62fe31929 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> @@ -143,7 +143,6 @@ can0: can@0 {
> /* TPM */
> &ecspi2 {
> cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> - fsl,spi-num-chipselects = <1>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ecspi2>;
> #address-cells = <1>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8dxl-evk: Remove 'fsl,spi-num-chipselects'
[not found] <20230726125025.295120-1-festevam@gmail.com>
[not found] ` <20230726125025.295120-2-festevam@gmail.com>
@ 2023-08-06 3:45 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2023-08-06 3:45 UTC (permalink / raw)
To: Fabio Estevam
Cc: linux-imx, linux-arm-kernel, y.moog, c.tenruh, Fabio Estevam
On Wed, Jul 26, 2023 at 09:50:24AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The 'fsl,spi-num-chipselects' property is not a valid one, so remove it.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied both, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-06 3:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230726125025.295120-1-festevam@gmail.com>
[not found] ` <20230726125025.295120-2-festevam@gmail.com>
2023-07-27 5:26 ` [PATCH 2/2] arm64: dts: imx8mm-phyboard-polis-rdk: Remove 'fsl,spi-num-chipselects' Yannic Moog
2023-07-27 10:23 ` Fabio Estevam
2023-07-27 11:10 ` Yannic Moog
2023-08-06 3:45 ` [PATCH 1/2] arm64: dts: imx8dxl-evk: " Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).