From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 091E9C0015E for ; Mon, 7 Aug 2023 02:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o7LdSq8P7f+yw9jemzyLsx00JgZBJw2bFhVlJhh7jkc=; b=ArcO8uA67+Ujb0 97K1xTu9osXT1bct3QOlymnLVtJ7MQdt/1TWKeGsFOoN3YHOi4EBmwZUUSl7OX+m2dCPVqzCpQ23M zCuSrxrAbyQY19/vmNr7c7uaLicHKA+hiuG0Ipl5qttAUFlDh9jtEDHdWBirH9HSEDCE5nzLjmkx4 G/VphzaqrMw/f9Z9UCVe3R81NlyJSRwQ5Hn1Rly93YbdQcR4w3p1Gb87rff5hFCLhuiALGn1ocdme x0p+oe89ox0Lq7Oi4BabPDU0RymG8pSDcy/FHwauzWCHvlhELlp5I3YeC/MUdQsotEUX5QfTPYsMo llDhWIvGQO+8eXqNA+yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSq4P-00G1Lw-19; Mon, 07 Aug 2023 02:34:09 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSq4M-00G1LZ-0I for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 02:34:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 863AB61147; Mon, 7 Aug 2023 02:34:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D334C433C8; Mon, 7 Aug 2023 02:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691375645; bh=VAgi2CztxDruPAYpUNX48zokdXixjyqxS/hrrk1Od78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cdcNIft7JOYsKV5VnSN916AvoJhkYFj7nDyzq3HVG5nEgzKDzqbqcm+xvtJPzgMxp /y1inm0W4e05t7rAYweMY14xzOU+lNU/vm6WJoZEDWyxEZErLZvAKDSAR8S3hMA0Pm 7/br/X8WgoZXue1WmCpJbx8pSeE+OlU93P+9LBIRtgRwB/TMkyE68Xg7uVyshDqrxg d6O2QqTgu0Gv7AbO1+M3e172SZP8JVoDglX8UaVGBa9of87hig91uPvgQ/8m5a+J8i GY4W89urt+gLNuTdG17eJ9iOG5hkYObwa0rs6pFf9rwK+VRMI+GQXUzLM6xrrkYu/8 oZJwRLKF6sgPw== Date: Mon, 7 Aug 2023 10:33:54 +0800 From: Shawn Guo To: "Peng Fan (OSS)" Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V5 3/9] firmware: imx: scu: drop return value check Message-ID: <20230807023354.GL151430@dragon> References: <20230731090449.2845997-1-peng.fan@oss.nxp.com> <20230731090449.2845997-4-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230731090449.2845997-4-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230806_193406_174639_418553F4 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 31, 2023 at 05:04:43PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > For IMX_SC_MISC_FUNC_UNIQUE_ID, the scfw has a return value, > and the imx-scu always return 0. So drop the return value check. imx_scu_call_rpc() could fail for a few reason. Are we not want to check those possible failures? Shawn > > BTW, also initialize msg to 0. > > Signed-off-by: Peng Fan > --- > drivers/firmware/imx/imx-scu-soc.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/firmware/imx/imx-scu-soc.c b/drivers/firmware/imx/imx-scu-soc.c > index 2f32353de2c9..ef9103987e76 100644 > --- a/drivers/firmware/imx/imx-scu-soc.c > +++ b/drivers/firmware/imx/imx-scu-soc.c > @@ -33,20 +33,15 @@ struct imx_sc_msg_misc_get_soc_uid { > > static int imx_scu_soc_uid(u64 *soc_uid) > { > - struct imx_sc_msg_misc_get_soc_uid msg; > + struct imx_sc_msg_misc_get_soc_uid msg = { 0 }; > struct imx_sc_rpc_msg *hdr = &msg.hdr; > - int ret; > > hdr->ver = IMX_SC_RPC_VERSION; > hdr->svc = IMX_SC_RPC_SVC_MISC; > hdr->func = IMX_SC_MISC_FUNC_UNIQUE_ID; > hdr->size = 1; > > - ret = imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true); > - if (ret) { > - pr_err("%s: get soc uid failed, ret %d\n", __func__, ret); > - return ret; > - } > + imx_scu_call_rpc(imx_sc_soc_ipc_handle, &msg, true); > > *soc_uid = msg.uid_high; > *soc_uid <<= 32; > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel