From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9722C001DE for ; Mon, 7 Aug 2023 02:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uX/9KtY8s8NC/A9dVaho7xtQmHzBo71EdFO0AN18Jbw=; b=VdKbpGkc5OXqhN RHSWoXdcBjbyvIEfwl75O0KGnwaMN8n2cTz8g5pcKG/gB6WNFLSRAHQvdYY0VPpixFVT2zM0vLDok 1jGiC+l4ZruqhcwYk8a4RP/NTHvzTYcJEXRgtjZsWuXN3TNvrtq9PNp28nHeMkBztsyKFATdVjg3p Q0FausGuT41chzMZVyguWg3GQ7grWqsDjAclCsrXwSMPFHv11GfjKyfQDdCxTAePQsd8VkYrC7yvo 1k9Bs92fSlPrWer1CsJrITTm+YaAt1flHSxWhAYyKBn+1hIjPr303/aM6mjgKAolJMmRmtmiM/vcF shryuxtZor0/4q6YehwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSqLp-00G2Az-0A; Mon, 07 Aug 2023 02:52:09 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSqLl-00G2AR-2j for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 02:52:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DADFE61324; Mon, 7 Aug 2023 02:52:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 345ECC433C7; Mon, 7 Aug 2023 02:51:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691376724; bh=gJk6vVUXiDkmun1RcHH2FC9OYEdQQqWcGTvzESd3jtk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qiqVSHhvLFxrJT5OH8ndniw3nRBvfBjs/YcaJ6ndswkbACC/4rTH3sIDzQiS11m5m x3cEMjZUqhxk42ZR024u2P4pSQ5HlszAbBWbJZYqXLl7iv3s9zDSzwc5Dduv8who+G EEPpMRZL2/aLE1V0T80GUXLAVf3NZ7j4zjMvJQhf9qEMg9BU/PcBaF2Efv6jaJ9daJ fBxyK/qzIUIIX/z2X86WDvlI2uXn2RHhtcN3kMhfmO7CNYpglnP4dSmlGy3FzRdN6u WEkcNONDJePjlHHE6yDaQybnOkG7qI1pT/KQqPaHe7BtXv1QdVVVLWpQKUATfMj1hc CQoom4Gnh0mhQ== Date: Mon, 7 Aug 2023 10:51:53 +0800 From: Shawn Guo To: "Peng Fan (OSS)" Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V5 4/9] firmware: imx: scu: use soc name for soc_id Message-ID: <20230807025153.GM151430@dragon> References: <20230731090449.2845997-1-peng.fan@oss.nxp.com> <20230731090449.2845997-5-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230731090449.2845997-5-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230806_195205_925629_858603C5 X-CRM114-Status: GOOD ( 17.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 31, 2023 at 05:04:44PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Same as soc-imx8m and soc-imx driver, use soc name for soc_id > > Signed-off-by: Peng Fan > --- > drivers/firmware/imx/imx-scu-soc.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/imx/imx-scu-soc.c b/drivers/firmware/imx/imx-scu-soc.c > index ef9103987e76..cb8377670a7d 100644 > --- a/drivers/firmware/imx/imx-scu-soc.c > +++ b/drivers/firmware/imx/imx-scu-soc.c > @@ -107,10 +107,12 @@ int imx_scu_soc_init(struct device *dev) > return -EINVAL; > > /* format soc_id value passed from SCU firmware */ > - val = id & 0x1f; > - soc_dev_attr->soc_id = devm_kasprintf(dev, GFP_KERNEL, "0x%x", val); > - if (!soc_dev_attr->soc_id) > - return -ENOMEM; > + if (of_machine_is_compatible("fsl,imx8qm")) > + soc_dev_attr->soc_id = "i.MX8QM"; > + else if (of_machine_is_compatible("fsl,imx8qxp")) > + soc_dev_attr->soc_id = "i.MX8QXP"; > + else if (of_machine_is_compatible("fsl,imx8dxl")) > + soc_dev_attr->soc_id = "i.MX8DXL"; Is it possible to deduce SoC name from the id retrieved from SCU firmware? IMO, device tree should be the last resort when there is no other sources for the such information. Shawn > > /* format revision value passed from SCU firmware */ > val = (id >> 5) & 0xf; > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel