From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3D39C0015E for ; Mon, 7 Aug 2023 02:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YoHW2IGoJAKJBwaqGvAWdK2Sh2bPxxxeI7Z1C25rjfM=; b=TYRcYT34iBWgz3 EeRYtczAVoK41PlWeYIOs5t3xcdwoy028aWFglVAfzLNdTBA5As3MpLkDFO2PMI8Kd+CZOm5Vt+8m Yz2uLtjd7ZRaIM3J1gIYgdeatTa0CFJXADasQQIwMbf2JsWK+XVx1l2pvvmf84/S5RUXcRdkfopn4 CXglQbynUyOvAWsckSpkcFWuJkMQw+hWiX7SMq+crk2XLJ0Ux/cIqhEdrEK6N4KHLp/AsnGLHBl+A 9plkJfPWg351IHiVcZ2ibA74mcrdAKDvkPtrGlG5hPmDqBPWRgD8u/fD686cErLDfsLv/9vHOQ5gv +zrJ0XrD9DKOrbv8WZQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSqO2-00G2KV-1A; Mon, 07 Aug 2023 02:54:26 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSqNz-00G2K8-25 for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 02:54:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 25EDD612CC; Mon, 7 Aug 2023 02:54:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C03A3C433C9; Mon, 7 Aug 2023 02:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691376862; bh=Co7bitjHl1G8SouxGx8spiP4TZY1ULqvzabs+FN5F3Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e/n+9sIwpi2uzfttCikXPZ+6fItqzzRTe8qj+/meEQfLhKpAGMxycNYZpDegfILyk Syb28HP4VoAtoSsatbYzlKoWzhUyGAz3bDTwGLhct8vOp2vsEGRrIoxT7MO6tzwjCW XdA2x9Xnk5a/XdCTDeMxOIc9iyM8+M7PkcmflR7b7sC0brG6IV8lWI6LWq43KTyQ9v 8542j3II3SJXBqJLFFQMdP1AEO/UzyoKPt/9TdsJr37aOIRkIDetdriXPvDzfOThum FRLZf0TWliCBWmV0t1835eOpEgvFzsC8Z4sdCty9QKGlWzJS6AJuBGLhq7u3wDKpf6 ut9964G1TsWNg== Date: Mon, 7 Aug 2023 10:54:12 +0800 From: Shawn Guo To: "Peng Fan (OSS)" Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, alexander.stein@ew.tq-group.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V5 5/9] firmware: imx: scu: use EOPNOTSUPP Message-ID: <20230807025412.GN151430@dragon> References: <20230731090449.2845997-1-peng.fan@oss.nxp.com> <20230731090449.2845997-6-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230731090449.2845997-6-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230806_195423_722607_9889FB12 X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 31, 2023 at 05:04:45PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > EOPNOTSUPP is preferred than ENOTSUPP. Could you elaborate why? Shawn > > Signed-off-by: Peng Fan > --- > include/linux/firmware/imx/sci.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/firmware/imx/sci.h b/include/linux/firmware/imx/sci.h > index 5cc63fe7e84d..7fa0f3b329b5 100644 > --- a/include/linux/firmware/imx/sci.h > +++ b/include/linux/firmware/imx/sci.h > @@ -25,27 +25,27 @@ int imx_scu_soc_init(struct device *dev); > #else > static inline int imx_scu_soc_init(struct device *dev) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > static inline int imx_scu_enable_general_irq_channel(struct device *dev) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > static inline int imx_scu_irq_register_notifier(struct notifier_block *nb) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > static inline int imx_scu_irq_unregister_notifier(struct notifier_block *nb) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > > static inline int imx_scu_irq_group_enable(u8 group, u32 mask, u8 enable) > { > - return -ENOTSUPP; > + return -EOPNOTSUPP; > } > #endif > #endif /* _SC_SCI_H */ > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel