From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA39EEB64DD for ; Mon, 7 Aug 2023 08:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aGr0gbEl35mW+Sd8Vl2ejuixUJuyS5WOt41eyTes2Yo=; b=qdgd0dMrT0dcFy 59454M00uJKJu87NZayJIVXnvrxF3v4VqmtLO7cEwpRZcOAoY575Fe/X7vgfM+Di109RZTnpKDTG+ +V4QJ9z1Wm/dCDnw7l6qGyehpE7wge78eD713Xbz0pFl+vsGtntjKjxedkF/3it/rP4bMvxJZCPly vx5t0u2LLS2AmyL6T7lLEDG7mhZv2Bl2x3jU7PkXZO/6qafIA5LLoZqwoYl3grMJbxAJsEsiGuuf5 N63bzMeC4CmPZOBtLTZrnDu8fK2dz5lcVjdQF+ZlkbTHl7atfZiZYQq1T1srrXrZ8qHy4dBxsLegt qqexDwBMeB+V7IQpSIQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSvQk-00GQSG-2g; Mon, 07 Aug 2023 08:17:34 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSvQh-00GQRb-0p; Mon, 07 Aug 2023 08:17:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D0906615F9; Mon, 7 Aug 2023 08:17:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97B62C433C8; Mon, 7 Aug 2023 08:17:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691396249; bh=32RJaUXj2/HJRQtblPM6k2oeKfZF39yPw0P0aMzAYXE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iT5OKUMwlCJ4CCjZqGu84tZcrCdI/0E808Lxxgrw5JmYEp3N5dZRI1nqqwBnyFyWQ TOgjeM8hHWrwokdGgVUZcPRtK9Y9jocBsPDBhTv3QFM26EX2lJ78J/U3U3sTHl4wA+ GHX+LWaD9Lwo4XenoR7Eolj8FQ2uZO/uhhgTxaovlFaiVIgVEEQHIUaMeYXiA3phQL DokdH43PaZCNchHzZmn0pygxh4VlxgM6C4UxUz+CtFBqiJnAf7YZmZjnr4HbCA1Wbl dW3U4tsy/paYQ7zMHngtqLgxo8YpJxxqgDml5guJTOqmjaaSVIEZLgu1NwCtSiaUeo jWCw8ccjAitJg== Date: Mon, 7 Aug 2023 10:17:25 +0200 From: Andi Shyti To: "Liao, Chang" Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 8/9] i2c: imx-lpi2c: Use dev_err_probe in probe function Message-ID: <20230807081725.fmjvdp3gxjs2ijee@intel.intel> References: <20230802095737.3957587-1-liaochang1@huawei.com> <20230802095737.3957587-9-liaochang1@huawei.com> <20230804221644.cqmoin6u22mxvouk@intel.intel> <758b882e-31a5-1f73-7fd2-945a8a2e9558@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <758b882e-31a5-1f73-7fd2-945a8a2e9558@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_011731_405283_6FF4D3BD X-CRM114-Status: GOOD ( 28.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMDcsIDIwMjMgYXQgMTA6MTM6MzBBTSArMDgwMCwgTGlhbywgQ2hhbmcgd3Jv dGU6Cj4gSGksIEFuZGkKPiAKPiDlnKggMjAyMy84LzUgNjoxNiwgQW5kaSBTaHl0aSDlhpnpgZM6 Cj4gPiBPbiBXZWQsIEF1ZyAwMiwgMjAyMyBhdCAwNTo1NzozNlBNICswODAwLCBMaWFvIENoYW5n IHdyb3RlOgo+ID4+IFVzZSB0aGUgZGV2X2Vycl9wcm9iZSBmdW5jdGlvbiBpbnN0ZWFkIG9mIGRl dl9lcnIgaW4gdGhlIHByb2JlIGZ1bmN0aW9uCj4gPj4gc28gdGhhdCB0aGUgcHJpbnRlZCBtZXNz Z2UgaW5jbHVkZXMgdGhlIHJldHVybiB2YWx1ZSBhbmQgYWxzbyBoYW5kbGVzCj4gPj4gLUVQUk9C RV9ERUZFUiBuaWNlbHkuCj4gPj4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBMaWFvIENoYW5nIDxsaWFv Y2hhbmcxQGh1YXdlaS5jb20+Cj4gPj4gLS0tCj4gPj4gIGRyaXZlcnMvaTJjL2J1c3Nlcy9pMmMt aW14LWxwaTJjLmMgfCAxMiArKysrLS0tLS0tLS0KPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5z ZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2kyYy9idXNzZXMvaTJjLWlteC1scGkyYy5jIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1pbXgt bHBpMmMuYwo+ID4+IGluZGV4IGMzMjg3Yzg4N2M2Zi4uYmZhNzg4YjM3NzViIDEwMDY0NAo+ID4+ IC0tLSBhL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtaW14LWxwaTJjLmMKPiA+PiArKysgYi9kcml2 ZXJzL2kyYy9idXNzZXMvaTJjLWlteC1scGkyYy5jCj4gPj4gQEAgLTU2OSwxMCArNTY5LDggQEAg c3RhdGljIGludCBscGkyY19pbXhfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikK PiA+PiAgCQlzaXplb2YobHBpMmNfaW14LT5hZGFwdGVyLm5hbWUpKTsKPiA+PiAgCj4gPj4gIAly ZXQgPSBkZXZtX2Nsa19idWxrX2dldF9hbGwoJnBkZXYtPmRldiwgJmxwaTJjX2lteC0+Y2xrcyk7 Cj4gPj4gLQlpZiAocmV0IDwgMCkgewo+ID4+IC0JCWRldl9lcnIoJnBkZXYtPmRldiwgImNhbid0 IGdldCBJMkMgcGVyaXBoZXJhbCBjbG9jaywgcmV0PSVkXG4iLCByZXQpOwo+ID4+IC0JCXJldHVy biByZXQ7Cj4gPj4gLQl9Cj4gPj4gKwlpZiAocmV0IDwgMCkKPiA+PiArCQlyZXR1cm4gZGV2X2Vy cl9wcm9iZSgmcGRldi0+ZGV2LCByZXQsICJjYW4ndCBnZXQgSTJDIHBlcmlwaGVyYWwgY2xvY2tc biIpOwo+ID4gCj4gPiB5b3UgY3V0IG9uIHRoaXMgYmVjYXVzZSB0aGUgbGluZSB3YXMgZ29pbmcg b3ZlciAxMDAgY2hhcmFjdGVycz8gOikKPiA+IAo+ID4gSW4gdGhlb3J5IHlvdSBzaG91bGRuJ3Qg Y2hhbmdlIHRoZSBwcmludCBtZXNzYWdlIHdoZW4gZG9pbmcgc3VjaAo+ID4gY2hhbmdlcyBhbmQg eW91IGNhbiBzdGlsbCBzcGxpdCBpdCBhczoKPiA+IAo+ID4gCQlyZXR1cm4gZGV2X2Vycl9wcm9i ZSgmcGRldi0+ZGV2LCByZXQsCj4gPiAJCQkJICAgICAiY2FuJ3QgZ2V0IEkyQyBwZXJpcGhlcmFs IGNsb2NrLCByZXQ9JWRcbiIsCj4gPiAJCQkJICAgICByZXQpOwo+ID4gCj4gPiBhbmQgeW91J3Jl IGV2ZW4gd2l0aGluIHRoZSA4MCBjaGFyYWN0ZXJzLgo+IAo+IFNpbmNlIGRldl9lcnJfcHJvYmUg YWx3YXlzIHByaW50IHRoZSBzZWNvbmQgcGFyYW1ldGVyIHRoYXQgaGFwcGVucyB0byBiZSB0aGUg cmV0dXJuIHZhbHVlLAo+IEkgcmVtb3ZlIHRoZSAicmV0PSVkIiBmcm9tIHRoZSBvcmlnaW5hbCBt ZXNzYWdlIHRvIGF2b2lkIGEgcmVkdW5kYW50IGVycm9yIG1lc3NhZ2UuCj4gCj4gU28gaXMgaXQg YmV0dGVyIHRvIGtlZXAgdGhlIG9yaWdpbmFsIG1lc3NhZ2UgdW5jaGFuZ2VkLCBldmVuIHRob3Vn aCBkZXZfZXJyX3Byb2JlIGFsc28gcHJpbnRzCj4gdGhlIHJldHVybiBlcnJvciB2YWx1ZT8gT3Ig aXMgaXQgYmV0dGVyIHRvIG1ha2UgdGhpcyBjaGFuZ2Ugc28gdGhhdCBhbGwgZXJyb3IgbWVzc2Fn ZXMgcHJpbnRlZAo+IGluIHRoZSBwcm9iZSBmdW5jdGlvbiBpbmNsdWRlIHRoZSByZXR1cm4gdmFs dWUgaW4gYSBjb25zaXN0ZW50IHN0eWxlPwoKeWVzLCB5b3UgYXJlIHJpZ2h0ISBUaGVuIHBsZWFz ZSBpZ25vcmUgdGhpcyBjb21tZW50LCBidXQuLi4KCj4gPiAgIAlyZXQgPSBkZXZtX3JlcXVlc3Rf aXJxKCZwZGV2LT5kZXYsIGlycSwgbHBpMmNfaW14X2lzciwgMCwKPiA+ICAgCQlwZGV2LT5uYW1l LCBscGkyY19pbXgpOwo+ID4gLSAJaWYgKHJldCkgewo+ID4gLSAJCWRldl9lcnIoJnBkZXYtPmRl diwgImNhbid0IGNsYWltIGlycSAlZFxuIiwgaXJxKTsKPiA+IC0gCQlyZXR1cm4gcmV0Owo+ID4g LSAJfQo+ID4gKyAJaWYgKHJldCkKPiA+ICsgCQlyZXR1cm4gZGV2X2Vycl9wcm9iZSgmcGRldi0+ ZGV2LCByZXQsICJjYW4ndCBjbGFpbSBpcnEgJWRcbiIsIGlycSk7CgpwbGVhc2UgbWFrZSBpdCBj b2hlcmVudCB0byB0aGlzIHNlY29uZCBwYXJ0LCBhcyB3ZWxsLCB3aGVyZSB0aGUKZXJyb3IgbnVt YmVyIGlzIHByaW50ZWQuCgpUaGFuayB5b3UsCkFuZGkKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK