From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A495C001DB for ; Mon, 7 Aug 2023 08:56:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0co7D/uQJYk/BADCxqonWLZDZSewd3EPEP4IOF6nkuQ=; b=jddbjwuI05fcF+ WIa44GuzcpnfLKCa9cd9q+Zxp0OSA/cDv/Mj7qW3ug29mDXtHQAWC7w1ConBmAKw0FDPHyOTz126+ vftKWF5HoaK2T6x5dD55YajMOgrmkqWHrnUi5wBH1HCCL0HKPSw99BFpZlaHbDE5FgnQjDplacFur ACjvsFOPjYjF/0EuN3eudmUMP+ombguhazBkbieEKqpieOKZoN5ne/vXEUMKAhuEs4Cb6lFvjUShs EoH3yMDSezS2ozZWeF4RDqY8aCFSIwIE3ELUZBSoiP6EY/AnfWT3R0MEuopT10DjIi4UBll6WZ8sU HxKBMXCGbcuAWbwmAWsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSw1n-00GVbE-27; Mon, 07 Aug 2023 08:55:51 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSw1k-00GVaV-1g for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 08:55:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93CB761692; Mon, 7 Aug 2023 08:55:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F572C433C9; Mon, 7 Aug 2023 08:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691398547; bh=aNHge0yiOY/VAZNLBKBPp6ymBzs24Uuzx4hIU+sZ4Bw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dv+bBEYxfrdjDt9exFHQnOm6yz2T0hfWEHmoB1ikclVu9UGCPJYDihDTBaJahEkWI TeBoB5SYhh0IftBkmwAeos3ClYRh6utWZq47Ff6uM8Jp94/MB/DRtdhrbCaEyrpuvr q491IdUyRkqrYES0o/eP6ms+oz260Ji9EUZMx6ylmXyneOCwE8vUCMdFfn8grI8XKV DBkuE9pFnMNoq9aBgwSffrej09PrYPtF+EPKP+xloM2uHCdGRdxtQgUmIGoBqQbts3 J+ZgzHNmdYDVpRah/Fc9Z0YyRlKRcZUpHmDkXsjUkg3iGlyBFk6yJKZf+shx4eZHQR +BQmY7Jqi1elA== Date: Mon, 7 Aug 2023 10:55:43 +0200 From: Andi Shyti To: Krzysztof Kozlowski Cc: Svyatoslav Ryhel , Iskren Chernev , Marek Szyprowski , Matheus Castello , Sebastian Reichel , Rob Herring , Conor Dooley , Russell King , Alim Akhtar , Arnd Bergmann , Jernej Skrabec , Claudiu Beznea , Stefan Hansson , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 4/4] ARM: configs: s5pv210_defconfig: enable IIO required by MAX17040 Message-ID: <20230807085543.3tfzpsa2joolay3r@intel.intel> References: <20230731073613.10394-1-clamor95@gmail.com> <20230731073613.10394-5-clamor95@gmail.com> <20230805224211.qquexvseq24hxcju@intel.intel> <16047849-1001-4d6f-4995-0fdfc065cded@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <16047849-1001-4d6f-4995-0fdfc065cded@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_015548_594963_A69DCA73 X-CRM114-Status: GOOD ( 21.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sun, Aug 06, 2023 at 10:29:04AM +0200, Krzysztof Kozlowski wrote: > On 06/08/2023 00:42, Andi Shyti wrote: > > Hi Svyatoslav, > > > > On Mon, Jul 31, 2023 at 10:36:13AM +0300, Svyatoslav Ryhel wrote: > >> After adding support for passing temperature data from thermal sensor > >> to MAX17040 it got dependency on CONFIG_IIO. From all defconfigs > >> using MAX17040 only s5pv210_defconfig did not have IIO already enabled > >> so let's enable it to avoid regression. > >> > >> Signed-off-by: Svyatoslav Ryhel > >> --- > >> arch/arm/configs/s5pv210_defconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/configs/s5pv210_defconfig b/arch/arm/configs/s5pv210_defconfig > >> index 4c1e480b5bbd..24070ee3d43e 100644 > >> --- a/arch/arm/configs/s5pv210_defconfig > >> +++ b/arch/arm/configs/s5pv210_defconfig > >> @@ -97,6 +97,7 @@ CONFIG_MMC_SDHCI_S3C_DMA=y > >> CONFIG_RTC_CLASS=y > >> CONFIG_RTC_DRV_MAX8998=m > >> CONFIG_DMADEVICES=y > >> +CONFIG_IIO=y > >> CONFIG_PWM=y > >> CONFIG_PWM_SAMSUNG=y > >> CONFIG_PHY_SAMSUNG_USB2=m > > > > Should this patch be squashed to the previous patch? I think you > > break bisectability for this board if you enable iio only here. > > The defconfig change matters less - distros don't use them - so this > points to the fact that patchset affected the users. All existing users > of max17040 drivers, who do not enable IIO, will have their setups broken. That's why I'm suggesting to squash this patch with the previous. Anyway, up to you... except of this note everything looks fine in the series. Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel