From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 768C5EB64DD for ; Mon, 7 Aug 2023 11:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a77ew5+ba1dIZIcoa0Pnrm5gqveWiQFLheHzy8tVVsE=; b=N1AGIIYItV19yK oNW+l4X83tydrXqVj/cmspeU/iwgwY7SsjoFsLZurW0dIcqZftX7RKBvABVfopgr47BTXo8E+8Rry duXHM4WSSgF6Fn2icMzRY8jzV2sRjidQB7yMVX9jDP0F7TmIB8M13yEiIqpFkaHh0aAN4H/XHRoEE KJGLvukCzui58HzS3HP987WzQ61jrs8sJlkjshnnl7DrGzojUa9nZnMXluJLaiucKLyQL3k2ZmrZO 78ShH29zVidrCG5vUMPTXRrt0I+pATQ28uq1+TTG5GrQgO5i/nngM6sqxAg5Kq/ZVGF3CDYxWB3dS Ik1+hKPXaCpK9h/gyUww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSypM-00H8aF-0R; Mon, 07 Aug 2023 11:55:12 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSypJ-00H8Zj-0z; Mon, 07 Aug 2023 11:55:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 96FBC61876; Mon, 7 Aug 2023 11:55:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29F76C433C8; Mon, 7 Aug 2023 11:55:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691409307; bh=R/epzjP4MVztL6PEKysek/qZr/5qEjO+L1hh2sVtNkg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FYkZSXK438kVYpG/FfDQDXVWZYMWtJMrr9KwB6PJW4J+YmLIa2fk0wCMulUqhO9zp ix0aut8KRwYPunKf7198c6rEXJCR+pf///fpbovSM7xfEohg1MislFmv1G87kzlf2X mxbYMX8LKi5rQ4FR/+m0oWM5gNVYMxS5U4hjUmwAP6cWp2Vxn7gsfO+Rm2udz/YQRf 8sQ2mCC5Qjfj1DITaA9qBxImpEPtCGiTUeCoD0nFe20okcNVMTYkhcnb6qBqEkR8hf nXdzGOsib5BG2JkNGhMhh1ZvNcKDZIbXZM/3pqoqJwlgk7EIs+nQRt9uIbUEtEnHVz mruoq1GaQNhtw== Date: Mon, 7 Aug 2023 13:55:03 +0200 From: Andi Shyti To: "Liao, Chang" Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 8/9] i2c: imx-lpi2c: Use dev_err_probe in probe function Message-ID: <20230807115503.u7qrtmt23vzosehr@intel.intel> References: <20230802095737.3957587-1-liaochang1@huawei.com> <20230802095737.3957587-9-liaochang1@huawei.com> <20230804221644.cqmoin6u22mxvouk@intel.intel> <758b882e-31a5-1f73-7fd2-945a8a2e9558@huawei.com> <20230807081725.fmjvdp3gxjs2ijee@intel.intel> <042c6eb7-cf31-79e1-51c7-c229e2582c0c@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <042c6eb7-cf31-79e1-51c7-c229e2582c0c@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_045509_432183_22BD18BF X-CRM114-Status: GOOD ( 32.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMDcsIDIwMjMgYXQgMDY6NDQ6MjNQTSArMDgwMCwgTGlhbywgQ2hhbmcgd3Jv dGU6Cj4gSGksIEFuZGkKPiAKPiDlnKggMjAyMy84LzcgMTY6MTcsIEFuZGkgU2h5dGkg5YaZ6YGT Ogo+ID4gT24gTW9uLCBBdWcgMDcsIDIwMjMgYXQgMTA6MTM6MzBBTSArMDgwMCwgTGlhbywgQ2hh bmcgd3JvdGU6Cj4gPj4gSGksIEFuZGkKPiA+Pgo+ID4+IOWcqCAyMDIzLzgvNSA2OjE2LCBBbmRp IFNoeXRpIOWGmemBkzoKPiA+Pj4gT24gV2VkLCBBdWcgMDIsIDIwMjMgYXQgMDU6NTc6MzZQTSAr MDgwMCwgTGlhbyBDaGFuZyB3cm90ZToKPiA+Pj4+IFVzZSB0aGUgZGV2X2Vycl9wcm9iZSBmdW5j dGlvbiBpbnN0ZWFkIG9mIGRldl9lcnIgaW4gdGhlIHByb2JlIGZ1bmN0aW9uCj4gPj4+PiBzbyB0 aGF0IHRoZSBwcmludGVkIG1lc3NnZSBpbmNsdWRlcyB0aGUgcmV0dXJuIHZhbHVlIGFuZCBhbHNv IGhhbmRsZXMKPiA+Pj4+IC1FUFJPQkVfREVGRVIgbmljZWx5Lgo+ID4+Pj4KPiA+Pj4+IFNpZ25l ZC1vZmYtYnk6IExpYW8gQ2hhbmcgPGxpYW9jaGFuZzFAaHVhd2VpLmNvbT4KPiA+Pj4+IC0tLQo+ ID4+Pj4gIGRyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtaW14LWxwaTJjLmMgfCAxMiArKysrLS0tLS0t LS0KPiA+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygt KQo+ID4+Pj4KPiA+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWlteC1s cGkyYy5jIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1pbXgtbHBpMmMuYwo+ID4+Pj4gaW5kZXgg YzMyODdjODg3YzZmLi5iZmE3ODhiMzc3NWIgMTAwNjQ0Cj4gPj4+PiAtLS0gYS9kcml2ZXJzL2ky Yy9idXNzZXMvaTJjLWlteC1scGkyYy5jCj4gPj4+PiArKysgYi9kcml2ZXJzL2kyYy9idXNzZXMv aTJjLWlteC1scGkyYy5jCj4gPj4+PiBAQCAtNTY5LDEwICs1NjksOCBAQCBzdGF0aWMgaW50IGxw aTJjX2lteF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4+Pj4gIAkJc2l6 ZW9mKGxwaTJjX2lteC0+YWRhcHRlci5uYW1lKSk7Cj4gPj4+PiAgCj4gPj4+PiAgCXJldCA9IGRl dm1fY2xrX2J1bGtfZ2V0X2FsbCgmcGRldi0+ZGV2LCAmbHBpMmNfaW14LT5jbGtzKTsKPiA+Pj4+ IC0JaWYgKHJldCA8IDApIHsKPiA+Pj4+IC0JCWRldl9lcnIoJnBkZXYtPmRldiwgImNhbid0IGdl dCBJMkMgcGVyaXBoZXJhbCBjbG9jaywgcmV0PSVkXG4iLCByZXQpOwo+ID4+Pj4gLQkJcmV0dXJu IHJldDsKPiA+Pj4+IC0JfQo+ID4+Pj4gKwlpZiAocmV0IDwgMCkKPiA+Pj4+ICsJCXJldHVybiBk ZXZfZXJyX3Byb2JlKCZwZGV2LT5kZXYsIHJldCwgImNhbid0IGdldCBJMkMgcGVyaXBoZXJhbCBj bG9ja1xuIik7Cj4gPj4+Cj4gPj4+IHlvdSBjdXQgb24gdGhpcyBiZWNhdXNlIHRoZSBsaW5lIHdh cyBnb2luZyBvdmVyIDEwMCBjaGFyYWN0ZXJzPyA6KQo+ID4+Pgo+ID4+PiBJbiB0aGVvcnkgeW91 IHNob3VsZG4ndCBjaGFuZ2UgdGhlIHByaW50IG1lc3NhZ2Ugd2hlbiBkb2luZyBzdWNoCj4gPj4+ IGNoYW5nZXMgYW5kIHlvdSBjYW4gc3RpbGwgc3BsaXQgaXQgYXM6Cj4gPj4+Cj4gPj4+IAkJcmV0 dXJuIGRldl9lcnJfcHJvYmUoJnBkZXYtPmRldiwgcmV0LAo+ID4+PiAJCQkJICAgICAiY2FuJ3Qg Z2V0IEkyQyBwZXJpcGhlcmFsIGNsb2NrLCByZXQ9JWRcbiIsCj4gPj4+IAkJCQkgICAgIHJldCk7 Cj4gPj4+Cj4gPj4+IGFuZCB5b3UncmUgZXZlbiB3aXRoaW4gdGhlIDgwIGNoYXJhY3RlcnMuCj4g Pj4KPiA+PiBTaW5jZSBkZXZfZXJyX3Byb2JlIGFsd2F5cyBwcmludCB0aGUgc2Vjb25kIHBhcmFt ZXRlciB0aGF0IGhhcHBlbnMgdG8gYmUgdGhlIHJldHVybiB2YWx1ZSwKPiA+PiBJIHJlbW92ZSB0 aGUgInJldD0lZCIgZnJvbSB0aGUgb3JpZ2luYWwgbWVzc2FnZSB0byBhdm9pZCBhIHJlZHVuZGFu dCBlcnJvciBtZXNzYWdlLgo+ID4+Cj4gPj4gU28gaXMgaXQgYmV0dGVyIHRvIGtlZXAgdGhlIG9y aWdpbmFsIG1lc3NhZ2UgdW5jaGFuZ2VkLCBldmVuIHRob3VnaCBkZXZfZXJyX3Byb2JlIGFsc28g cHJpbnRzCj4gPj4gdGhlIHJldHVybiBlcnJvciB2YWx1ZT8gT3IgaXMgaXQgYmV0dGVyIHRvIG1h a2UgdGhpcyBjaGFuZ2Ugc28gdGhhdCBhbGwgZXJyb3IgbWVzc2FnZXMgcHJpbnRlZAo+ID4+IGlu IHRoZSBwcm9iZSBmdW5jdGlvbiBpbmNsdWRlIHRoZSByZXR1cm4gdmFsdWUgaW4gYSBjb25zaXN0 ZW50IHN0eWxlPwo+ID4gCj4gPiB5ZXMsIHlvdSBhcmUgcmlnaHQhIFRoZW4gcGxlYXNlIGlnbm9y ZSB0aGlzIGNvbW1lbnQsIGJ1dC4uLgo+ID4gCj4gPj4+ICAgCXJldCA9IGRldm1fcmVxdWVzdF9p cnEoJnBkZXYtPmRldiwgaXJxLCBscGkyY19pbXhfaXNyLCAwLAo+ID4+PiAgIAkJcGRldi0+bmFt ZSwgbHBpMmNfaW14KTsKPiA+Pj4gLSAJaWYgKHJldCkgewo+ID4+PiAtIAkJZGV2X2VycigmcGRl di0+ZGV2LCAiY2FuJ3QgY2xhaW0gaXJxICVkXG4iLCBpcnEpOwo+ID4+PiAtIAkJcmV0dXJuIHJl dDsKPiA+Pj4gLSAJfQo+ID4+PiArIAlpZiAocmV0KQo+ID4+PiArIAkJcmV0dXJuIGRldl9lcnJf cHJvYmUoJnBkZXYtPmRldiwgcmV0LCAiY2FuJ3QgY2xhaW0gaXJxICVkXG4iLCBpcnEpOwo+ID4g Cj4gPiBwbGVhc2UgbWFrZSBpdCBjb2hlcmVudCB0byB0aGlzIHNlY29uZCBwYXJ0LCBhcyB3ZWxs LCB3aGVyZSB0aGUKPiA+IGVycm9yIG51bWJlciBpcyBwcmludGVkLgo+IAo+IERvIHlvdSBtZWFu IHRvIGNvbnZlcnQgaXQgdG8gdGhlIGZvbGxvd2luZz8KPiAKPiAgICAgaWYgKHJldCkKPiAgICAg ICAgIHJldHVybiBkZXZfZXJyX3Byb2JlKCZwZGV2LT5kZXYsIHJldCwgImNhbid0IGNsYWltIGly cVxuIik7Cj4gCj4gSSB1bmRlcnN0YW5kIHRoYXQgdGhlIHN0eWxlIG9mIGVycm9yIG1lc3NhZ2Ug cHJpbnRlZCBieSBkZXZfZXJyX3Byb2JlIGlzIGxpa2UKPiAiZXJyb3IgW0VSUk5PXTogW2N1c3Rv bWl6ZWQgbWVzc2FnZV0iLCB0aGUgW0VSUk5PXSBjb21lcyBmcm9tIDJuZCBwYXJhbWV0ZXIsCj4g W2N1c3RvbWl6ZWQgbWVzc2FnZV0gY29tZXMgZnJvbSAzcmQgcGFyYW10ZXIsIGlmIHRoZSBvcmln aW5hbCBbY3VzdG9taXplZCBtZXNzYWdlXWl0Cj4gYWxzbyBwcmludCBFUlJOTywgaSBpbnRlbmQg dG8gcmVtb3ZlIGl0IGluIHRoaXMgcGF0Y2gsIG90aGVyd2lzZSwgSSB3aWxsIGp1c3Qga2VlcCBp dC4KPiBJbiB0aGUgYWJvdmUgY29kZSwgW2N1c3RvbWl6ZWQgbWVzc2FnZV0gaW50ZW5kIHRvIHBy aW50IGlycSBidXQgcmV0dXJuIHZhbHVlLCBzbyBpdCBpcwo+IGJldHRlciB0byBrZWVwIHRoZSBv cmlnaW5hbCBtZXNzYWdlLCByaWdodD8KCnNvcnJ5Li4uIEkganVzdCBnb3QgY29uZnVzZWQgYW5k IHJlYWQgd3JvbmcgdGhlIGNvZGUuIFBsZWFzZQppZ25vcmUgbXkgY29tbWVudHMgb24gdGhpcyBw YXRjaCwgeW91IGFyZSByaWdodCBoZXJlLiBGZWVsIGZyZWUKdG8gYWRkLgoKUmV2aWV3ZWQtYnk6 IEFuZGkgU2h5dGkgPGFuZGkuc2h5dGlAa2VybmVsLm9yZz4gCgpBbmRpCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==