From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8420C001B0 for ; Mon, 7 Aug 2023 19:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x8+SZYEuPwCdNrv8nkFheKPpgirxlGReIxrggSIRudM=; b=dDqm83YyQVkfKo eAaXAM5EdhRTTm3xJhfe+MoqPhx4s13JlF0Cb3M2+AkBOxJZlaFytnV5rIqd+c502kBizjCuSudGa fjdFNNUy4NmpL8DiPh8xeh9DiyoHcdFOIizP16lxSMhz/LBTLRXGynJw3cS94eKLv7TCY6CdQsJq/ MlgKoca1dOL/tveKpOkB+fgMCTzmQIQ6sARHt70LmO4skMXq1Rtt2sX8OfHKz117WRAwXIeUEJsS2 GI/7fEbRTIdtif77UG9lJrWxGAoUyWiAozRXM73DRk9WK6D6N9HiWaYxJHtlmNf4jcq4oJuyIlBWJ 1sdt3/KBmo5dRTGfEEvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qT5a0-000TQM-0Z; Mon, 07 Aug 2023 19:07:48 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qT5Zw-000TPf-1P for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 19:07:46 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 377J7dFs098704; Mon, 7 Aug 2023 14:07:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691435259; bh=KxazVsFzy03RD30/1KgFYKMblJSqL3Mk1P2zfXt/Zzk=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=jZAYllSvkSKt9QkIrwVZn/LtZUjqz+5O6qOC1joDD1BQWzDQRoJUNfUAGlQ//hiv5 EzrVAXHhksso9HhM9/YZWSgaDyRjqvO44KSfwfxk1qe+DnqZuAJxv8dbVUBrsd4DBn BDlLOpa9ADhmL9Wa47rNp7K2DiS96NrNEWYdwlBY= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 377J7dfZ118355 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 7 Aug 2023 14:07:39 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 7 Aug 2023 14:07:39 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 7 Aug 2023 14:07:39 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 377J7d7j092863; Mon, 7 Aug 2023 14:07:39 -0500 Date: Mon, 7 Aug 2023 14:07:39 -0500 From: Nishanth Menon To: Apurva Nandan CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Udit Kumar , Hari Nagalla , Dasnavis Sabiya , Tom Rini Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: Add bootph-pre-ram property for SPL nodes Message-ID: <20230807190739.a33f5piskapfphxh@blatantly> References: <20230807185645.128751-1-a-nandan@ti.com> <20230807185645.128751-2-a-nandan@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230807185645.128751-2-a-nandan@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_120744_597535_1B6DA5B9 X-CRM114-Status: GOOD ( 17.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 00:26-20230808, Apurva Nandan wrote: > Add bootph-pre-ram property for all the nodes used in SPL stage, > for syncing it later to u-boot j784s4 dts. > > Signed-off-by: Apurva Nandan > --- We need to rework this a little more: The approach taken in this series is enable pre-ram for everything. I am not sure that is the right direction. https://github.com/devicetree-org/dt-schema/blob/e87ba2f515392c2a4694642063efb43023331ff6/dtschema/schemas/bootph.yaml#L70 patch #1: board generic changes: patch #1 patch #2-: board specific change (per board) Make sure you use the correct property and document why this is needed in the section added as well - esp for board generic changes introduced into SoC.dtsi files. > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > index 2ea0adae6832..aaec569fe91a 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > @@ -6,6 +6,7 @@ > */ > > &cbass_main { > + bootph-pre-ram; Is this better done where the node is defined? > msmc_ram: sram@70000000 { > compatible = "mmio-sram"; > reg = <0x00 0x70000000 0x00 0x800000>; > @@ -670,6 +671,7 @@ main_sdhci1: mmc@4fb0000 { > }; > > main_navss: bus@30000000 { > + bootph-pre-ram; > compatible = "simple-bus"; > #address-cells = <2>; > #size-cells = <2>; > @@ -705,6 +707,7 @@ main_udmass_inta: msi-controller@33d00000 { > }; > > secure_proxy_main: mailbox@32c00000 { > + bootph-pre-ram; > compatible = "ti,am654-secure-proxy"; > #mbox-cells = <1>; > reg-names = "target_data", "rt", "scfg"; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel