linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Anton Eliasson <anton.eliasson@axis.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH] tty: serial: samsung: Set missing PM ops for hibernation support
Date: Mon, 7 Aug 2023 23:34:52 +0200	[thread overview]
Message-ID: <20230807213452.aev2ubalxvydmxjv@intel.intel> (raw)
In-Reply-To: <1dbc24c4-b057-0e71-432a-a7d0ce2df2dc@axis.com>

Hi Anton,

On Mon, Aug 07, 2023 at 11:57:04AM +0200, Anton Eliasson wrote:
> On 05/08/2023 23.38, Andi Shyti wrote:
> > Hi Anton,
> > 
> > On Thu, Aug 03, 2023 at 01:26:42PM +0200, Anton Eliasson wrote:
> > > At least freeze, restore and thaw need to be set in order for the driver
> > > to support system hibernation. The existing suspend/resume functions can
> > > be reused since those functions don't touch the device's power state or
> > > wakeup capability. Use the helper macros SET_SYSTEM_SLEEP_PM_OPS and
> > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for symmetry with similar drivers.
> > and why do we need hibernation in this device?
> > 
> > Andi
> 
> Hi!
> 
> I wanted to test whether hibernation is possible on our SoC, even though it
> is not a common feature on embedded ARM systems. This is the only mainline
> driver that I found that needed modification, for my proof-of-concept
> anyway, and I couldn't see any harm in the change.

Thanks, makes sense, mine was just curiosity, can I know which
SoC you are testing that is using the samsung serial device?

You can add my r-b, anyway:

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Thanks,
Andi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-07 21:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03 11:26 [PATCH] tty: serial: samsung: Set missing PM ops for hibernation support Anton Eliasson
2023-08-05 21:38 ` Andi Shyti
2023-08-07  9:57   ` Anton Eliasson
2023-08-07 21:34     ` Andi Shyti [this message]
2023-08-09 13:57       ` Anton Eliasson
2023-08-07 13:50 ` Krzysztof Kozlowski
2023-08-09 13:19   ` Anton Eliasson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230807213452.aev2ubalxvydmxjv@intel.intel \
    --to=andi.shyti@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=anton.eliasson@axis.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kernel@axis.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).